All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nogah Frankel <nogahf@mellanox.com>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, roopa@cumulusnetworks.com,
	roszenrami@gmail.com, jbenc@redhat.com,
	sergei.shtylyov@cogentembedded.com, jiri@mellanox.com,
	eladr@mellanox.com, idosch@mellanox.com, yotamg@mellanox.com,
	ogerlitz@mellanox.com, Nogah Frankel <nogahf@mellanox.com>
Subject: [PATCH iproute2 v5 0/4] update ifstat for new stats
Date: Thu, 26 Jan 2017 14:44:37 +0200	[thread overview]
Message-ID: <1485434681-33947-1-git-send-email-nogahf@mellanox.com> (raw)

Previously stats were gotten by RTM_GETLINK which returns 32 bits based
statistics. It supports only one type of stats.
Lately, a new method to get stats was added - RTM_GETSTATS. It supports
ability to choose stats type. The basic stats were changed from 32 bits
based to 64 bits based.

This patchset adds ifstat the ability to get extended stats (xstats) by
this method. Its adds xstat of cpu_hits - for packets that hit cpu.

---
v4->v5:
 - remove patch 3/4 that added 64 based "normal" stats
 - add a new patch 4/4 that updates ifstat man page

v3->v4:
- patch 2/4:
 - change xstat name read to avoid redundant copy.
 - delete extra line
- patch 4/4:
 - change xstat name.

v2->v3:
- patch 1/4:
 - add a new patch to reorder includes in misc/ifstat.c
- patch 2/4: (previously 1/3)
 - fix typos.
 - change error print to use fprintf.

v1->v2:
 - change from using RTM_GETSTATS always to using it only for extended
   stats.
 - Add 64bits extended stats type.

Nogah Frankel (4):
  ifstat: Includes reorder
  ifstat: Add extended statistics to ifstat
  ifstat: Add "sw only" extended statistics to ifstat
  ifstat: Add xstat to ifstat man page

 man/man8/Makefile |   3 +-
 man/man8/ifstat.8 |  12 +++-
 misc/ifstat.c     | 168 ++++++++++++++++++++++++++++++++++++++++++++++++------
 3 files changed, 163 insertions(+), 20 deletions(-)

-- 
2.4.3

             reply	other threads:[~2017-01-26 12:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 12:44 Nogah Frankel [this message]
2017-01-26 12:44 ` [PATCH iproute2 v5 1/4] ifstat: Includes reorder Nogah Frankel
2017-01-26 12:44 ` [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat Nogah Frankel
2017-01-30  4:34   ` Stephen Hemminger
2017-02-02  8:53     ` Nogah Frankel
2017-02-03 18:07   ` Stephen Hemminger
2017-02-07 12:59     ` Nogah Frankel
2017-02-07 16:48       ` Stephen Hemminger
2017-01-26 12:44 ` [PATCH iproute2 v5 3/4] ifstat: Add "sw only" " Nogah Frankel
2017-01-26 12:44 ` [PATCH iproute2 v5 4/4] ifstat: Add xstat to ifstat man page Nogah Frankel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485434681-33947-1-git-send-email-nogahf@mellanox.com \
    --to=nogahf@mellanox.com \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=jbenc@redhat.com \
    --cc=jiri@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=roszenrami@gmail.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=stephen@networkplumber.org \
    --cc=yotamg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.