From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58582) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWlgV-0006Yz-Q9 for qemu-devel@nongnu.org; Thu, 26 Jan 2017 10:10:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWlgU-0004so-Oh for qemu-devel@nongnu.org; Thu, 26 Jan 2017 10:09:59 -0500 From: Markus Armbruster Date: Thu, 26 Jan 2017 16:09:44 +0100 Message-Id: <1485443388-27253-5-git-send-email-armbru@redhat.com> In-Reply-To: <1485443388-27253-1-git-send-email-armbru@redhat.com> References: <1485443388-27253-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org, Peter Maydell , "Edgar E. Iglesias" , Alistair Francis , qemu-arm@nongnu.org Block backends defined with -drive if=scsi are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=scsi drives not picked up that way can still be used with -device as if they had if=none, but that's unclean and best avoided. Unused ones produce an "Orphaned drive without device" warning. A few machine types default to if=scsi, even though they don't actually have a SCSI HBA. This makes no sense. Change their default to if=none. Affected machines: * aarch64/arm: realview-pbx-a9 vexpress-a9 vexpress-a15 xilinx-zynq-a9 Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: qemu-arm@nongnu.org Signed-off-by: Markus Armbruster --- hw/arm/realview.c | 1 - hw/arm/vexpress.c | 1 - hw/arm/xilinx_zynq.c | 1 - 3 files changed, 3 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 8eafcca..8c11c7a 100644 --- a/hw/arm/realview.c +++ b/hw/arm/realview.c @@ -443,7 +443,6 @@ static void realview_pbx_a9_class_init(ObjectClass *oc, void *data) mc->desc = "ARM RealView Platform Baseboard Explore for Cortex-A9"; mc->init = realview_pbx_a9_init; - mc->block_default_type = IF_SCSI; mc->max_cpus = 4; } diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index 58760f4..5756470 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -751,7 +751,6 @@ static void vexpress_class_init(ObjectClass *oc, void *data) mc->desc = "ARM Versatile Express"; mc->init = vexpress_common_init; - mc->block_default_type = IF_SCSI; mc->max_cpus = 4; } diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 7dac20d..3985356 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc) { mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9"; mc->init = zynq_init; - mc->block_default_type = IF_SCSI; mc->max_cpus = 1; mc->no_sdcard = 1; } -- 2.7.4