Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present

From: Joe Perches <joe@perches.com>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Darren Hart" <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org,
	acpi4asus-user@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux@endlessm.com,
	"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present
Date: Thu, 26 Jan 2017 14:45:41 -0800	[thread overview]
Message-ID: <1485470741.12563.104.camel@perches.com> (raw)
In-Reply-To: <20170126153013.12753-9-jprvita@endlessm.com>

On Thu, 2017-01-26 at 10:30 -0500, João Paulo Rechi Vita wrote:
> Some Asus laptops that have an airplane-mode indicator LED, also have
> the WMI WLAN user bit set, and the following bits in their DSDT:

style trivia:

> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
[]
> @@ -2051,6 +2052,16 @@ static int asus_wmi_fan_init(struct asus_wmi *asus)
>  	return 0;
>  }
>  
> +static bool ashs_present(void)
> +{
> +	int i;
> +
> +	for (i = 0; strcmp(asus_wireless_ids[i].id, ""); i++)
> +		if (acpi_dev_found(asus_wireless_ids[i].id))
> +			return true;

The for loop would commonly have braces because of the
internal if.