From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752709AbdA1X0I (ORCPT <rfc822;w@1wt.eu>);
        Sat, 28 Jan 2017 18:26:08 -0500
Received: from smtprelay0003.hostedemail.com ([216.40.44.3]:39069 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751947AbdA1X0B (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 28 Jan 2017 18:26:01 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:2895:3138:3139:3140:3141:3142:3352:3622:3868:3870:3871:4250:4321:5007:7875:7903:8603:10004:10400:10848:11026:11232:11473:11658:11914:12438:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21433:21451:30054:30056:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: meal59_31d520d06fd57
X-Filterd-Recvd-Size: 2154
Message-ID: <1485644341.6833.3.camel@perches.com>
Subject: Re: [PATCH 22/50] x86/boot/e820: Convert printk(KERN_* ...) to
 pr_*()
From: Joe Perches <joe@perches.com>
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@alien8.de>,
        "H . Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, Yinghai Lu <yinghai@kernel.org>
Date: Sat, 28 Jan 2017 14:59:01 -0800
In-Reply-To: <1485641531-22124-23-git-send-email-mingo@kernel.org>
References: <1485641531-22124-1-git-send-email-mingo@kernel.org>
         <1485641531-22124-23-git-send-email-mingo@kernel.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.22.3-0ubuntu0.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 2017-01-28 at 23:11 +0100, Ingo Molnar wrote:
> No change in functionality.

Not true.

> @@ -419,11 +419,11 @@ __e820_update_range(struct e820_table *table, u64 start, u64 size, unsigned old_
>  		size = ULLONG_MAX - start;
>  
>  	end = start + size;
> -	printk(KERN_DEBUG "e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);
> +	pr_debug("e820: update [mem %#010Lx-%#010Lx] ", start, end - 1);

#define DEBUG is not set here so this conversion is
not equivalent.

pr_debug will be removed unless CONFIG_DYNAMIC_DEBUG
is enabled and also will not be enabled by default.

>  	e820_print_type(old_type);
> -	printk(KERN_CONT " ==> ");
> +	pr_cont(" ==> ");

This will always be emitted.

> @@ -495,10 +495,10 @@ u64 __init e820_remove_range(u64 start, u64 size, unsigned old_type, int checkty
>  		size = ULLONG_MAX - start;
>  
>  	end = start + size;
> -	printk(KERN_DEBUG "e820: remove [mem %#010Lx-%#010Lx] ", start, end - 1);
> +	pr_debug("e820: remove [mem %#010Lx-%#010Lx] ", start, 

etc...