From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbdA3FDx (ORCPT ); Mon, 30 Jan 2017 00:03:53 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:59597 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbdA3FDg (ORCPT ); Mon, 30 Jan 2017 00:03:36 -0500 X-AuditID: b6c32a46-f79536d000001a0a-df-588ec5e72049 From: Shailendra Verma To: Zhou Wang , Gabriele Paoloni , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Pci: host - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:19:35 +0530 Message-id: <1485751775-29126-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWy7bCmqe7zo30RBsuuaFvcn/aN3WJJU4bF 1dW/GC0u75rDZnF23nE2ix1TWlksbs2byWax6NsrZotH1+YwOXB67Jx1l91jwaZSj8dzN7J7 tBx5y+rRt2UVo8fnTXIBbFFcNimpOZllqUX6dglcGXuX/WAsaGWrmPH2OnMDYwtrFyMnh4SA icS92ZOZIGwxiQv31rN1MXJxCAnsYJRof3uLGcL5zCixZ/50dpiOsyvfsUMkVjJKHFz8jg0k wSZgKPG67y8TSEJE4CKTxOfpy8E6hAWsJJZPmMoIYrMIqEp8WPAPKM7BwSvgIbFpiTCIKSGg IDFnkg1Iq4TAdTaJ6a//MULEZSU2HWCG2OsisWbjAxYIW1ji1fEtUPdISbzacY0ZovcYo8Tj 54uZIJzLjBJbTi+DqrKXuHbrNZjNLMAn0XH4LzvEAl6JjjYhiBIPiYW3v7NBhB0l9k2LAzGF BGIlvt+PncAouYCRYRWjWGpBcW56arFRgZFecWJucWleul5yfu4mRnBEarntYFxyzucQowAH oxIP7w3hvggh1sSy4srcQ4wSHMxKIrzlO4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEef+ts44Q EkhPLEnNTk0tSC2CyTJxcEo1MG7QLK/Wu8w4ffZL1rb0F06uS4wYuv62hDMHGXBw1EvlVBSv iUho9X2i8CNe77DkMuO1/5KlBHOmNXZLLHhx4mzazvApvMsyjhzdlbmN4ZHoZMbkS+9/rrMM 312b97724LuO1TFzXQNVI7ZP99z43jbj6IQdqYeeaGhltgQU7X6kXidced3jrhJLcUaioRZz UXEiAEwN86DEAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsWSnbNCVffZ0b4Ig8ULZS3uT/vGbrGkKcPi 6upfjBaXd81hszg77zibxY4prSwWt+bNZLNY9O0Vs8Wja3OYHDg9ds66y+6xYFOpx+O5G9k9 Wo68ZfXo27KK0ePzJrkAtig3m4zUxJTUIoXUvOT8lMy8dFul0BA3XQslhbzE3FRbpQhd35Ag JYWyxJxSIM/IAA04OAe4Byvp2yW4Zexd9oOxoJWtYsbb68wNjC2sXYycHBICJhJnV75jh7DF JC7cW8/WxcjFISSwnFFi0fIHbCAJNgFDidd9f5lAEiIC15kkHh3eyQKSEBawklg+YSojiM0i oCrxYcE/oEkcHLwCHhKblgiDmBICChJzJtlMYORcwMiwilEstaA4Nz23uMDASK84Mbe4NC9d Lzk/dxMjMAy3HVYS38E4a4XXIUYBDkYlHl6LjL4IIdbEsuLK3EOMEhzMSiK85TuBQrwpiZVV qUX58UWlOanFhxhNgZZPZJYSTc4HxkheSbyhiamFhYWJpbGxsYWJkjhv7PRn4UIC6Yklqdmp qQWpRTB9TBycUg2Mk6a1Kye/8i19b5B6ITQ++lm12qYXC9ncjJSCHR2uMTHYWAoZ5XQ+bH05 s4dh+fTr5R6GuYe751Yr7ap7dHxCsGxbgnHDj5scHos2ivoyJTgmM035/G9/TdxppsXceyJE psyqmH9g/lbrlz96fjSoybbfcJJXuDi/w7ecsSn72NJVK85IbJVRYinOSDTUYi4qTgQAdHkm DFkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130044942epcas2p4c3e879675c189ff46c27b5f35bbc350f X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130044942epcas2p4c3e879675c189ff46c27b5f35bbc350f X-RootMTR: 20170130044942epcas2p4c3e879675c189ff46c27b5f35bbc350f References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/pci/host/pcie-hisi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/host/pcie-hisi.c b/drivers/pci/host/pcie-hisi.c index 56154c2..3256f8f 100644 --- a/drivers/pci/host/pcie-hisi.c +++ b/drivers/pci/host/pcie-hisi.c @@ -174,6 +174,10 @@ static int hisi_pcie_probe(struct platform_device *pdev) driver = dev->driver; match = of_match_device(driver->of_match_table, dev); + if (!match) { + dev_err(dev, "Error: No device match found\n"); + return -ENODEV; + } hisi_pcie->soc_ops = (struct pcie_soc_ops *) match->data; hisi_pcie->subctrl = -- 1.7.9.5