From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751960AbdA3E6t (ORCPT ); Sun, 29 Jan 2017 23:58:49 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:39261 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdA3E6p (ORCPT ); Sun, 29 Jan 2017 23:58:45 -0500 X-AuditID: b6c32a45-f79966d000001a3f-96-588ec8029135 From: Shailendra Verma To: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Arch: arm: plat-pxa - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:28:31 +0530 Message-id: <1485752311-29754-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMIsWRmVeSWpSXmKPExsWy7bCmmS7Tib4Ig9VfTS3uT/vGbrHp8TVW i8u75rBZHJq6l9Fix5RWFotb82ayWSz69orZgd3j8rWLzB47Z91l99i8pN6jb8sqRo/Pm+QC WKO4bFJSczLLUov07RK4Mu4+vM9S0MFWMWX1U7YGxu8sXYwcHBICJhLH95h1MXICmWISF+6t Z+ti5OIQEtjBKLF/4S1WCOczo8TmO1tZIapMJFZtmsUIYgsJrGSU2LiVCcRmEzCUeN33lwmk QUSgjUli/t+3TCAbhAVcJOYcVASpYRFQlThw/R47iM0r4CFx+8UqqCMUJOZMsgFplRA4wCZx 9PI0Joi4rMSmA8wQa10kzn1eywZhC0u8Or6FHcKWkni14xozRO8xRonHzxczQTiXGSW2nF4G VWUvce3WazCbWYBPouPwX3aIBbwSHW1CECUeEveP9UItc5TYMHEtO8SPsRJvmnsZJzBKLmBk WMUollpQnJueWmxUYKhXnJhbXJqXrpecn7uJERx1Wq47GGec8znEKMDBqMTDe0O4L0KINbGs uDL3EKMEB7OSCG/5TqAQb0piZVVqUX58UWlOavEhRmkOFiVx3n/rrCOEBNITS1KzU1MLUotg skwcnFINjBGHMtqfOW/0EGj5lFImydZlLbeoNX5nZa1JiOu++522Gq+NWrabBj5bs2Ne8Dr5 W+LN79s7XKIe6PVYvg/jMF10Mcrp8vnYv3JmD/O976VWXjZfc/H5ZsuHnS/yPIOUz9zUFrrv /1+1hP9lTPA7bavpfVf9llUaWTzpmFwVIyvZNGPFSvbJSizFGYmGWsxFxYkAwzMTELYCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOLMWRmVeSWpSXmKPExsWSnbNCVZfpRF+EwfP5ihb3p31jt9j0+Bqr xeVdc9gsDk3dy2ixY0ori8WteTPZLBZ9e8XswO5x+dpFZo+ds+6ye2xeUu/Rt2UVo8fnTXIB rFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFBSgpliTmlQJ6RARpwcA5w D1bSt0twy7j78D5LQQdbxZTVT9kaGL+zdDFyckgImEis2jSLEcIWk7hwbz0biC0ksJxR4vRs QRCbTcBQ4nXfX6YuRi4OEYEuJom+882sXYwcHMICLhJzDiqC1LAIqEocuH6PHcTmFfCQuP1i FQtIiYSAgsScSTYTGDkXMDKsYhRLLSjOTc8tLjAw0itOzC0uzUvXS87P3cQIDLRth5XEdzDO WuF1iFGAg1GJh9cioy9CiDWxrLgy9xCjBAezkghv+U6gEG9KYmVValF+fFFpTmrxIUZToO0T maVEk/OBUZBXEm9oYmphYWFiaWxsbGGiJM4bO/1ZuJBAemJJanZqakFqEUwfEwenVAOjTvOO c2YHPqZPKnK4tf/Kj/bf8+qbnCYUzd0e2Tp/aqqj9ZbYrXwnbK7bf+islW7MDwjMU13qUaLy 7vUn3r632ZcMd/4SKJteXe/bmhqXXeMSIbAtxtm5/9HM14dmhTqG5vxYu+yUStl5d+n4oybO u61sDn/zOvFPZ+Pe68u9szgzJr9919yqxFKckWioxVxUnAgARWiKTUoCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130045842epcas2p274b2125a1f158e4d656096bdf3a3a1d9 X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130045842epcas2p274b2125a1f158e4d656096bdf3a3a1d9 X-RootMTR: 20170130045842epcas2p274b2125a1f158e4d656096bdf3a3a1d9 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- arch/arm/plat-pxa/ssp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index ba13f79..7d1cd51 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -204,6 +204,10 @@ static int pxa_ssp_probe(struct platform_device *pdev) if (dev->of_node) { const struct of_device_id *id = of_match_device(of_match_ptr(pxa_ssp_of_ids), dev); + if (!id) { + dev_err(dev, "Error: No device match found\n"); + return -ENODEV; + } ssp->type = (int) id->data; } else { const struct platform_device_id *id = -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: shailendra.v@samsung.com (Shailendra Verma) Date: Mon, 30 Jan 2017 10:28:31 +0530 Subject: [PATCH] Arch: arm: plat-pxa - Fix possible NULL derefrence. References: Message-ID: <1485752311-29754-1-git-send-email-shailendra.v@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- arch/arm/plat-pxa/ssp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index ba13f79..7d1cd51 100644 --- a/arch/arm/plat-pxa/ssp.c +++ b/arch/arm/plat-pxa/ssp.c @@ -204,6 +204,10 @@ static int pxa_ssp_probe(struct platform_device *pdev) if (dev->of_node) { const struct of_device_id *id = of_match_device(of_match_ptr(pxa_ssp_of_ids), dev); + if (!id) { + dev_err(dev, "Error: No device match found\n"); + return -ENODEV; + } ssp->type = (int) id->data; } else { const struct platform_device_id *id = -- 1.7.9.5