From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752033AbdA3FMZ (ORCPT ); Mon, 30 Jan 2017 00:12:25 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:57363 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbdA3FMT (ORCPT ); Mon, 30 Jan 2017 00:12:19 -0500 X-AuditID: b6c32a47-f79116d000001a32-90-588ec87f6d8a From: Shailendra Verma To: Alexandre Belloni , Paul Gortmaker , Nicolas Ferre , LABBE Corentin , linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Memory - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:30:05 +0530 Message-id: <1485752405-29885-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsWy7bCmuW79ib4IgyWnWCw6ri1msrg/7Ru7 xd+/lRaXd81hs/h2uZndYseUVhaLa3uPM1vcmjeTzWLRt1fMDpweC35tZfF4sukio8fOWXfZ Pfq2rGL0+LxJzmP9lq1MAWxRXDYpqTmZZalF+nYJXBm9rVEFX1krtu26zt7A+I2li5GTQ0LA RGLdxN9MELaYxIV769m6GLk4hAR2MEq8PnWGCcL5zCixumE6G0zHz0cnwLqFBFYySpy/LA1i swkYSrzu+wvWICLwi0ni5c1NYA3CAuYSJ6d8AbNZBFQlTkxaydzFyMHBK+AhsXtZNYgpIaAg MWeSDUirhMBlNomXjTOYIeKyEpsOMEOsdZF4uegBO4QtLPHq+BYoW0ri1Y5rzBC9xxglHj9f zAQ1iFFiy+llUFX2EtduvQazmQX4JDoO/2WHWMAr0dEmBFHiIfHs7CSoZY4Sj3ZuYwMpERKI lZi2znQCo+QCRoZVjGKpBcW56anFRgXGesWJucWleel6yfm5mxjBEanlvoNx2zmfQ4wCHIxK PLw3hPsihFgTy4orcw8xSnAwK4nwlu8ECvGmJFZWpRblxxeV5qQWH2KU5mBREuf9t846Qkgg PbEkNTs1tSC1CCbLxMEp1cAoo70oZP+K1vl3Q6QEAmM+ej2sfLa8J7OU8eHDXUzcReez9i5h eru2R17oW/RhN4a98oFTMhRbvhS4PTVTZ7p1XunWqYmCKxS/3xPKTGqKf/RApz/y4gouC1Ul e7kOhb3viy1+cZ/QW3F+8UR5VcXoWd5CvW2TXhUon71cP+nR93NN/uyrtscosRRnJBpqMRcV JwIAvcrdLsQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsWSnbNCVbfuRF+Ewcx2U4uOa4uZLO5P+8Zu 8fdvpcXlXXPYLL5dbma32DGllcXi2t7jzBa35s1ks1j07RWzA6fHgl9bWTyebLrI6LFz1l12 j74tqxg9Pm+S81i/ZStTAFuUm01GamJKapFCal5yfkpmXrqtUmiIm66FkkJeYm6qrVKErm9I kJJCWWJOKZBnZIAGHJwD3IOV9O0S3DJ6W6MKvrJWbNt1nb2B8RtLFyMnh4SAicTPRyegbDGJ C/fWs3UxcnEICSxnlFj24y4TSIJNwFDidd9fMFtEoIFZ4lpDPogtLGAucXLKFzYQm0VAVeLE pJXMXYwcHLwCHhK7l1WDmBICChJzJtlMYORcwMiwilEstaA4Nz23uMDASK84Mbe4NC9dLzk/ dxMjMAi3HVYS38E4a4XXIUYBDkYlHl6LjL4IIdbEsuLK3EOMEhzMSiK85TuBQrwpiZVVqUX5 8UWlOanFhxhNgZZPZJYSTc4HRkheSbyhiamFhYWJpbGxsYWJkjhv7PRn4UIC6YklqdmpqQWp RTB9TBycUg2MWy4bBS3dei15w7xaz3+iJ3fN2vn/wvlzzA8Nd8+pW8HPqFMx79y/D+zXLcPV hBdenXnloH9giV3BG221pfHn8uK2qKh7VEVGTVt3bnNmfkHovJneBiy7ZYIFpAJbShKYPrkl ltlfe/huUaFp6uI9AeG9J01PtC1eHXQvYXt1RIPI1ociDx1UlViKMxINtZiLihMB25TQDlgC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130050046epcas2p381ef5bb7c8a1df4b8c7e37a93e168630 X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130050046epcas2p381ef5bb7c8a1df4b8c7e37a93e168630 X-RootMTR: 20170130050046epcas2p381ef5bb7c8a1df4b8c7e37a93e168630 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/memory/atmel-sdramc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/memory/atmel-sdramc.c b/drivers/memory/atmel-sdramc.c index 12080b0..cb63fbe 100644 --- a/drivers/memory/atmel-sdramc.c +++ b/drivers/memory/atmel-sdramc.c @@ -57,6 +57,10 @@ static int atmel_ramc_probe(struct platform_device *pdev) struct clk *clk; caps = of_device_get_match_data(&pdev->dev); + if (!caps) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } if (caps->has_ddrck) { clk = devm_clk_get(&pdev->dev, "ddrck"); -- 1.7.9.5