From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shailendra Verma Subject: [PATCH] Usb: host - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:36:29 +0530 Message-ID: <1485752789-30374-1-git-send-email-shailendra.v@samsung.com> References: Return-path: Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mathias Nyman , Greg Kroah-Hartman , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, p.shailesh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, ashish.kalra-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Shailendra Verma , Shailendra Verma List-Id: linux-tegra@vger.kernel.org of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/usb/host/xhci-tegra.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index a59fafb..890c778 100644 --- a/drivers/usb/host/xhci-tegra.c +++ b/drivers/usb/host/xhci-tegra.c @@ -903,6 +903,10 @@ static int tegra_xusb_probe(struct platform_device *pdev) return -ENOMEM; tegra->soc = of_device_get_match_data(&pdev->dev); + if (!tegra->soc) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } mutex_init(&tegra->lock); tegra->dev = &pdev->dev; -- 1.7.9.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbdA3FKg (ORCPT ); Mon, 30 Jan 2017 00:10:36 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:59280 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbdA3FK3 (ORCPT ); Mon, 30 Jan 2017 00:10:29 -0500 X-AuditID: b6c32a47-f79116d000001a32-98-588ec9e13b78 From: Shailendra Verma To: Mathias Nyman , Greg Kroah-Hartman , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Usb: host - Fix possible NULL derefrence. Date: Mon, 30 Jan 2017 10:36:29 +0530 Message-id: <1485752789-30374-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRmVeSWpSXmKPExsWy7bCmhe7Dk30RBhM/slrcn/aN3eLcq0cs Fs2L17NZXN41h82i88ssNotFy1qZLZo3TWG12DGllcXi1ryZQLFvr5gtXh1sY7H4uWseiwOP x85Zd9k9Fu95yeSxf+4ado++LasYPT5vkvPYODc0gC2KyyYlNSezLLVI3y6BK+P27jbGgq+s Fa0Hn7A1MP5i6WLk5JAQMJHY+H4LK4QtJnHh3nq2LkYuDiGBHYwSq3/PZ4RwPjNKbG+8zdzF yAHWsbAzBSK+klGi6+lqNpBuNgFDidd9f5lAEiICJ5klNp17wAySEBawkji87AjYChYBVYmb rw6CNfAKeEhMPnucHWKogsScSTYgvRICr9kkfu1fzgYRl5XYdIAZ4joXiRf71zFC2MISr45v YYewpSRe7bjGDNF7jFHi8fPFTBDOZUaJLaeXQVXZS1y79RrMZhbgk+g4/BdqMa9ER5sQRImH xKIXR5kgbEeJiRPOgy0WEoiVmLHzG+sERskFjAyrGMVSC4pz01OLjQqM9YoTc4tL89L1kvNz NzGCo1bLfQfjtnM+hxgFOBiVeHhvCPdFCLEmlhVX5h5ilOBgVhLhLd8JFOJNSaysSi3Kjy8q zUktPsQozcGiJM77b511hJBAemJJanZqakFqEUyWiYNTqoFxNtMVjbOfrLhYpatTtj1x6Y6V iPd6bCb9uGTWQoa/5tc2MV61K+aUK5/auYq/K4WdqYvXO+OCnUzJ7qnpm4W4PTSPVwjb3Do7 /9LZqX8aEpYqTTU91bTlk7i454ZSkxkLVkS9NZaP2Scf5fJ46ncpbtuKqUpMx086GJ88flG2 y8b4G19V+HYlluKMREMt5qLiRAASQUKz1gIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRmVeSWpSXmKPExsWSnbNCVffByb4Ig9drZSzuT/vGbnHu1SMW i+bF69ksLu+aw2bR+WUWm8WiZa3MFs2bprBa7JjSymJxa95MoNi3V8wWrw62sVj83DWPxYHH Y+esu+wei/e8ZPLYP3cNu0ffllWMHp83yXlsnBsawBblZpORmpiSWqSQmpecn5KZl26rFBri pmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZGaABB+cA92AlfbsEt4zbu9sYC76yVrQefMLWwPiL pYuRg0NCwERiYWdKFyMnkCkmceHeerYuRi4OIYHljBKfj7WwgSTYBAwlXvf9ZQJJiAhcZpZY dvEMI0hCWMBK4vCyI6wgNouAqsTNVwfBGngFPCQmnz3ODrFAQWLOJJsJjJwLGBlWMYqlFhTn pucWFxgY6RUn5haX5qXrJefnbmIEhum2w0riOxhnrfA6xCjAwajEw2uR0RchxJpYVlyZe4hR goNZSYS3fCdQiDclsbIqtSg/vqg0J7X4EKMp0PaJzFKiyfnAGMoriTc0MbWwsDCxNDY2tjBR EueNnf4sXEggPbEkNTs1tSC1CKaPiYNTqoGRz/L37FvPHP+oP7mcNlH6rsNcpszXfFclj5X8 Crlol71LPnt93H0LqReKF0t9vX6mb7EVU72R2BL8rze0RuqspP3aLIfTkyfVlky79tcr4cTx 3duNFNPU9audmJ74/I0QlzUpeLKlfG7eoxeb851fft9v1ucxfUrpgzdvjr3ZJHj8QOaUDc07 lFiKMxINtZiLihMBQxMfamkCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130050640epcas2p1f856bc12df5d1ee6b9e0c66cf9dd6339 X-Msg-Generator: CA X-Sender-IP: 182.195.34.23 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 102P X-HopCount: 7 X-CMS-RootMailID: 20170130050640epcas2p1f856bc12df5d1ee6b9e0c66cf9dd6339 X-RootMTR: 20170130050640epcas2p1f856bc12df5d1ee6b9e0c66cf9dd6339 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_device_get_match_data could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/usb/host/xhci-tegra.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c index a59fafb..890c778 100644 --- a/drivers/usb/host/xhci-tegra.c +++ b/drivers/usb/host/xhci-tegra.c @@ -903,6 +903,10 @@ static int tegra_xusb_probe(struct platform_device *pdev) return -ENOMEM; tegra->soc = of_device_get_match_data(&pdev->dev); + if (!tegra->soc) { + dev_err(&pdev->dev, "no device match found\n"); + return -ENODEV; + } mutex_init(&tegra->lock); tegra->dev = &pdev->dev; -- 1.7.9.5