From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751976AbdAaMHg (ORCPT ); Tue, 31 Jan 2017 07:07:36 -0500 Received: from smtprelay0102.hostedemail.com ([216.40.44.102]:42480 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751908AbdAaMHI (ORCPT ); Tue, 31 Jan 2017 07:07:08 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:334:355:368:369:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6691:7875:10004:10400:10450:10455:10848:11232:11658:11783:11914:12555:12740:12895:13069:13161:13229:13311:13357:13439:13894:14659:19904:19999:21080:21451:30012:30054:30070:30089:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: toy05_3dfc1bb7fe011 X-Filterd-Recvd-Size: 2334 Message-ID: <1485864424.20550.28.camel@perches.com> Subject: Re: [PATCH 001] staging: wlan-ng: Add tabstop preceding the statement From: Joe Perches To: Maksymilian Piechota Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Date: Tue, 31 Jan 2017 04:07:04 -0800 In-Reply-To: <20170131113332.GA12148@maks-debian.localdomain> References: <20170130163142.GA9425@maks-debian.localdomain> <20170130164423.GA12941@kroah.com> <1485835236.20550.20.camel@perches.com> <20170131110358.GA11278@maks-debian.localdomain> <1485861525.20550.26.camel@perches.com> <20170131113332.GA12148@maks-debian.localdomain> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-01-31 at 06:33 -0500, Maksymilian Piechota wrote: > On Tue, Jan 31, 2017 at 03:18:45AM -0800, Joe Perches wrote: > > checkpatch is just a guide, it's brainless. > > > > The reason these lines are > 80 columns is > > overly long/verbose identifiers. > > > > If you really want to clean up the code here, > > the P90211ENUM_ prefixes are a bit misleading > > as they all are #define and not enums at all. > > > But would you like me to remove this prefixes for all of the enums from > p80211types.h? Are you sure it won't cause any symbol conflicts? No, I don't want that, I'd prefer you think about it. Also, a useful effort would be to (from the README) TODO: []         - move to use the in-kernel wireless stack where most all of the P80211 code would be removed. Anyway, sure, use checkpatch as a tool to help when learning the process of how to submit patches properly. Then move on to more thoroughly understand a block of code in the kernel that can be improved with cleaner style and logic and bug fixes you could submit. That's be much more appreciated than random 80 column fixups and strict checkpatch compliance done without a thorough understanding of the code. In any case, welcome, hope you stick around.