From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 03/10] mmc: remove pointless request type check in mmc_prep_request
Date: Tue, 31 Jan 2017 16:57:24 +0100 [thread overview]
Message-ID: <1485878251-6107-4-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1485878251-6107-1-git-send-email-hch@lst.de>
The block layer won't send requests the driver isn't asking for,
so remove this check.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/mmc/core/queue.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
index a6496d8..033f641 100644
--- a/drivers/mmc/core/queue.c
+++ b/drivers/mmc/core/queue.c
@@ -30,15 +30,6 @@ static int mmc_prep_request(struct request_queue *q, struct request *req)
{
struct mmc_queue *mq = q->queuedata;
- /*
- * We only like normal block requests and discards.
- */
- if (req->cmd_type != REQ_TYPE_FS && req_op(req) != REQ_OP_DISCARD &&
- req_op(req) != REQ_OP_SECURE_ERASE) {
- blk_dump_rq_flags(req, "MMC bad request");
- return BLKPREP_KILL;
- }
-
if (mq && (mmc_card_removed(mq->card) || mmc_access_rpmb(mq)))
return BLKPREP_KILL;
--
2.1.4
next prev parent reply other threads:[~2017-01-31 15:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 15:57 remove the cmd_type field from struct request Christoph Hellwig
2017-01-31 15:57 ` [PATCH 01/10] scm_blk: remove unneeded REQ_TYPE_FS check Christoph Hellwig
2017-01-31 15:57 ` [PATCH 02/10] ѕd: remove pointless " Christoph Hellwig
2017-01-31 15:57 ` Christoph Hellwig [this message]
2017-01-31 15:57 ` [PATCH 04/10] ms_block: remove pointless prep_fn Christoph Hellwig
2017-01-31 15:57 ` [PATCH 05/10] mspro_block: " Christoph Hellwig
2017-01-31 15:57 ` [PATCH 06/10] nbd: remove REQ_TYPE_DRV_PRIV leftovers Christoph Hellwig
2017-01-31 15:57 ` [PATCH 07/10] nbd: move request validity checking into nbd_send_cmd Christoph Hellwig
2017-01-31 15:57 ` [PATCH 08/10] block: introduce blk_rq_is_passthrough Christoph Hellwig
2017-01-31 15:57 ` [PATCH 09/10] ide: don't abuse cmd_type Christoph Hellwig
2017-01-31 16:11 ` David Miller
2017-01-31 15:57 ` [PATCH 10/10] block: fold cmd_type into the REQ_OP_ space Christoph Hellwig
2017-01-31 18:02 ` remove the cmd_type field from struct request Jens Axboe
2017-01-31 18:51 ` James Bottomley
2017-01-31 18:58 ` Sergei Shtylyov
2017-01-31 21:09 ` Jens Axboe
2017-02-01 6:53 ` Hannes Reinecke
2017-02-01 6:53 ` Hannes Reinecke
2017-02-01 10:55 ` Sergei Shtylyov
[not found] ` <CGME20170201103729epcas1p12708473d0e5257bef65e1d92712af885@epcas1p1.samsung.com>
2017-02-01 10:37 ` Bartlomiej Zolnierkiewicz
2017-01-31 21:07 ` Jens Axboe
2017-02-01 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485878251-6107-4-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.