All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Subject: Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 31 Jan 2017 19:32:10 +0000	[thread overview]
Message-ID: <1485891116.3113.2.camel@sandisk.com> (raw)
In-Reply-To: <E1cYdxN-0000Wr-AS@rmk-PC.armlinux.org.uk>

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declara=
tion of function 'try_module_get' [-Werror=3Dimplicit-function-declaration]
>=20
> Add linux/module.h to iscsi_target_login.c.
>=20
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/i=
scsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ***********************************************************************=
*******/
> =20
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>=

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org"
	<linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
	"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org"
	<rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	"linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org"
	<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	"f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org"
	<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
Subject: Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 31 Jan 2017 19:32:10 +0000	[thread overview]
Message-ID: <1485891116.3113.2.camel@sandisk.com> (raw)
In-Reply-To: <E1cYdxN-0000Wr-AS-eh5Bv4kxaXIk46pC+1QYvQNdhmdF6hFW@public.gmane.org>

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Subject: Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 31 Jan 2017 19:32:10 +0000	[thread overview]
Message-ID: <1485891116.3113.2.camel@sandisk.com> (raw)
In-Reply-To: <E1cYdxN-0000Wr-AS@rmk-PC.armlinux.org.uk>

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
From Anna.Schumaker@netapp.com Tue Jan 31 20:49:19 2017
Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 31 Jan 2017 20:49:27 +0100 (CET)
Received: from mx144.netapp.com ([216.240.21.25]:30617 "EHLO mx144.netapp.com"
        rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP
        id S23993899AbdAaTtTu5Hxi (ORCPT <rfc822;linux-mips@linux-mips.org>);
        Tue, 31 Jan 2017 20:49:19 +0100
X-IronPort-AV: E=Sophos;i="5.33,315,1477983600"; 
   d="scan'208";a="174051109"
Received: from vmwexchts01-prd.hq.netapp.com ([10.122.105.12])
  by mx144-out.netapp.com with ESMTP; 31 Jan 2017 11:40:54 -0800
Received: from VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) by
 VMWEXCHTS01-PRD.hq.netapp.com (10.122.105.12) with Microsoft SMTP Server
 (TLS) id 15.0.1210.3; Tue, 31 Jan 2017 11:48:12 -0800
Received: from NAM02-CY1-obe.outbound.protection.outlook.com (10.120.60.153)
 by VMWEXCCAS03-PRD.hq.netapp.com (10.122.105.19) with Microsoft SMTP Server
 (TLS) id 15.0.1210.3 via Frontend Transport; Tue, 31 Jan 2017 11:48:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netapp.onmicrosoft.com; s=selector1-netapp-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=uOWCiHoJOkeJ03T4mq0DkYm1YX/LM+dO6vMB4b4yogo=;
 b=ol0wo4fSJiK9ThT5aRZzpKEfdIMlk3oOq2hVjsGGH5cB8RvD0evUS3Rd+bd6P79YOdedQzTjOZbnvMA6Vkp1Cuz32mD4CUgmpIldMDVS9cbU1T3iav5x4hBPocr9jbxDnHDHYgCAkphs+kXVAQ723EPvkCqNQHvhqCzrKJJQUKQ=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Anna.Schumaker@netapp.com; 
Received: from gouda.nowheycreamery.com (68.40.188.1) by
 BLUPR0601MB1635.namprd06.prod.outlook.com (10.163.212.141) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12; Tue, 31
 Jan 2017 19:48:07 +0000
Subject: Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when
 linux/phy*.h is removed from net/dsa.h
To:     Russell King <rmk+kernel@armlinux.org.uk>,
        <linux-mips@linux-mips.org>, <linux-nfs@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
        <target-devel@vger.kernel.org>
References: <20170131191704.GA8281@n2100.armlinux.org.uk>
 <E1cYdwi-0000Vs-97@rmk-PC.armlinux.org.uk>
CC:     "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Jeff Layton <jlayton@poochiereds.net>,
        Trond Myklebust <trond.myklebust@primarydata.com>
From:   Anna Schumaker <Anna.Schumaker@Netapp.com>
Message-ID: <52ceb082-1e0a-7210-833a-f4ac22df4b8c@Netapp.com>
Date:   Tue, 31 Jan 2017 14:48:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <E1cYdwi-0000Vs-97@rmk-PC.armlinux.org.uk>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [68.40.188.1]
X-ClientProxiedBy: MWHPR14CA0052.namprd14.prod.outlook.com (10.173.97.142) To
 BLUPR0601MB1635.namprd06.prod.outlook.com (10.163.212.141)
X-MS-Office365-Filtering-Correlation-Id: 0b097ef3-bc3b-4f54-2fb0-08d44a12156a
X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BLUPR0601MB1635;
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;3:pqQdKQnggVpXZO9kxDGGHXk3jnYxph8zNcHgN123tPYZ6V21FkmUKK0KLfpFZbd+MDx48Y0ZQpEnYayQEqbYLIkxb7/pSsJp3oY5Bhd+WbIJ0q3evXFvZdFo3FjGg4WAq5/JqKpcF7V0bqktVaq//9kN78GINRzSysWksyulT3TfakRpmVsM36PjLeZSP/4cLUUi5Kzzn1skeyeYJWvtzZp73Nx/AOAljKKRPlEiRUDnt1dHDecckXOis6u0phWDVu08AwmgkFAdIiINYOrkZw==;25:H7evsomXQrGUJrzkwAjsHBn39ESJypT6h+oQ+JNNzHEslcZvDqHRnC2tk9i4xWdrrvNG9wh4wcGOHqNqCnHeP6e9gYLkkjj9bTIbJAUmcpcL09H1OH7UdlAdr6wrUdcgT7dSyk5LMslrROICSbXM4dDjzhX1+yPj8s9lB0B3jvFNH0l5bWGFlpnl3NrBNHq19gOTlqnWTSHtQ4apE15BGNQEFZNDWMMlRYMuZic6gea+oTDiqzO2Quc74TdaA8Xt9RrzZjdWkWU4IRD+XpE144MAyHFxSkXClXdfQdrM/F4mixCqJVwGPwIJX3VfsUyMBQEUClXefVyqxw7Xi6B72Luc5Nj0i8zqy4h0uHjhwrbIgUMbMUt+KfY4YtK7l3gbXLhWN/7+XQJIYnDyk3jxrslCa0L+d1zQY2pCDLuRshKuyQeZgbzQ90iwKYcsrPt1zu7bN7c3J3a0pPBVUehDzQ==
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;31:FPynjvJrN9BMI8B3BNKoHQkq1MZPPqM9Mif8RRC77N4dy/1NVfuzSCbBPJYGZxYQfB35q8mJQr8+wQMIURjD8hck35fQcmnHgXOtwuiI90Bv8C2Wc5N1G6505tSQ5ZxLCA2DeFILxXP1EzReathqsjxXM9411zYE/+hRo/96CobErHkKQAaOQ4U98daErgLDyxfkzOgDJcagj6ez8EggXhEXWq5iTp9xPdyuORAKOIjADnlwM+sMXNr+CNw/OueblnlA2UPQprhodUnwmwBwFw==;20:xVlh5kgHDL3g/cNSrQRJrpzu52Dk4hxyD2EiNs8FNLwfYYTFGTUKZhOnIs/+ft1bP6Biqs1UOV6MuXEb6uF+6OBYYy9BnC/yR/ActKjccGVN1jfBmDHvpPr68hklyHGKYRA4WYnW3UDCywPy31Af7MuKIJFlmOlhvLLgWBD8Dpxy8L+tJPCHVigb5ABrGrIxDmtSfXLJ1CcvBHDtaueLCFcnZ7GKTldFgZz3oWSMFoueivz6+gWTTlaX0cAZVRNTQo1Be+kabWW/EXiObi2tLeNfrW/MjpKdie3GEt2EopCIhtS9JNI5SkSW8Inf4AxxJcz+91rTAqz0g0WqpNSZe3I2i/7smCTmGUUvUsRlNGcmUa1WL/F//xFIyq5sHWNCDQ7GUAM1hwEbNYYK91EP5hmoG5KUCpgtfPGuP46xmZ7tgUtzZx664uTwUfUYrqujW6KVpn9A9ebV1rnx6NnoW1Z5v4rjB05ESqmoFAfEQJTaZh8hfftrcxHjQlMgGfEu
X-Microsoft-Antispam-PRVS: <BLUPR0601MB1635ECE13E0623F977ABE259F84A0@BLUPR0601MB1635.namprd06.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:;
X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:BLUPR0601MB1635;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0601MB1635;
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;4:WQ7hukXGogirq7lIFOPEnAoI8nYeiVQTHRF99OC/Sqdesvzz3Db5RBEQyDc1X+Z1oaFO88whk5vJ9CLLTfJfqu8R1auysiV+GLuxQkA/de715ZF1L6heZV7rTK+IlpUB08sBInyIEEC/1W6EEWYnCoqrSaBaGisyPouSPv1tmdpAz5RlgXS2ayDnihpnydFI6QBzDh6w8bd4jSASZZAbrepu+CnYajsWP/OuUzroj/AgEZ3EEKA4lKZ749ozJTZaHwbkBTnuNt5xhmSkUl2WBGWuNgRde6Dtg3utXQOcUqrzj2k0Q7azJqoVXjI5S4RXpRaVeqOfrLuq1WEk+QJvEwuszcfbrlyu5FqSlwB2DyRlICzL+yEPCQ0okUwUImwMiVOJW+Oz8cz0aNeqIw/RXq64qCoydJWU6zoDlPiM+QxhbJ096LAqkH8wSaDJgXsuMfIPybA9L2l6Bz+PvAr9/uRXkBgZcJEfROCiFXDmXwrBIklyk67YFLqdChSNc1Xjzd4qlzcF6U2W/U4gEgEt79/WndCJhlWxeoSMFMRVvSFrwHya2i2/2FuJyYTfcO/74VjNYS5Wjw00QFP/v/+G4w==
X-Forefront-PRVS: 0204F0BDE2
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(377454003)(24454002)(189002)(199003)(6506006)(39060400001)(97736004)(42186005)(229853002)(38730400001)(4001350100001)(31686004)(54906002)(6512007)(92566002)(83506001)(36756003)(3846002)(6486002)(53936002)(69596002)(101416001)(189998001)(81166006)(76176999)(54356999)(64126003)(8676002)(50986999)(50466002)(81156014)(25786008)(47776003)(4326007)(2906002)(6666003)(106356001)(68736007)(5001770100001)(6116002)(53416004)(105586002)(66066001)(305945005)(33646002)(7736002)(5660300001)(31696002)(23676002)(86362001)(65826007)(2201001)(2950100002)(7416002)(65956001)(230700001)(65806001)(2101003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0601MB1635;H:gouda.nowheycreamery.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en;
Received-SPF: None (protection.outlook.com: netapp.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA2MDFNQjE2MzU7MjM6S1UrUys0dElrLzNLSC90RWxFUjJvNy83?=
 =?utf-8?B?WDhHRHcxaDBSVDV2STBKWGg3LzFMOWdHOGwzc3E3WWVlakpnRkV1STFmWmcw?=
 =?utf-8?B?dmdyZFhrczZGRGRuM0pQQzU2bCs3L2E3M0IzV09HWkFmK1JWenVHQ3FiRzJH?=
 =?utf-8?B?UlVQVGFNdW1vT1VVZWJxWWRZYUJhakhlVDd3NTRnU09wU3FFdXdROWkwWHhV?=
 =?utf-8?B?QTYwazdpU1NhdTlZcDErZCtDVVRNblYwY1dOUU1HY0dPcTd3U3BpNW5XdlI4?=
 =?utf-8?B?eHJlRGN3RGFiRHNEblQzcXhTc0FyZm5kdGxpUW0xbWlIeDRtSkpJWmI5MXlm?=
 =?utf-8?B?QU0ycFJuOHg4bTc4dTAyTmUxOXlKYzRFeEdrdktoQjhOUzJ4SmE1NTRiUnFY?=
 =?utf-8?B?QjMwMTRzZjBsWFd2ZDFmSFZlby81OVdQc0tPQUsyait4ZXl6cWNtdEk2OU5B?=
 =?utf-8?B?VVVubElKOGtCU1d5R3FJa3hNR2toajlKRTNKZGhsVm9haHYrdzFYMUgyUDJw?=
 =?utf-8?B?UGVidjAvNDNveklLUHg4enJJY21DbzRubWZLVnNDWWQ5bTFFQ0NoQ1VTdm8y?=
 =?utf-8?B?blRLK3dsWUZlVGtvSmZwZnJmeWpEVXFVZEViRm9ma0psb0RnKzYrQ0d0dTFz?=
 =?utf-8?B?MVFxS3lFbG9ZL0U4OE9tZVNhZkVSZThkRWptWi9lMDJKYTlvbUYyQkhKRWx4?=
 =?utf-8?B?YXlBK0ZDNkowLzZBN1RiMW5SSU9MbG5XWFd2ZXhVaG9xZG9ob2JXcUl5UDl3?=
 =?utf-8?B?SldUR25EendDamQ4U3B4L0pGWlhoYm9HVEpIUEVxSVJwYkFxbE8xcWprTllS?=
 =?utf-8?B?ajV4cW9qbnR2VXBaQ01MK3RMODNlWitvb0VuZ3B6bTRKSFdKTmsvZ1pOTisz?=
 =?utf-8?B?Sy9zZVFYYTgxTWhrT0Y2Z1lRc1d3SWV1cFJNZm1MTU5DMEpLZkpLekUyM2FX?=
 =?utf-8?B?L3dVa3FoVlNIdllOZFhmK3JkS3JOZEswdXV1RU5sVTZaR1NqM3AwSlg0NHpx?=
 =?utf-8?B?amF2bkFXSzVIVi9HSFl6RkUzRGpHK1U3UzVsNjd6bi92ZUNFc2NsV29WVzdY?=
 =?utf-8?B?RU4yV3BYZ1RQcEg0V3duMFpaeXlZODRmZnlQdEVPOXVLYklQSHY5U0lOaGRY?=
 =?utf-8?B?Y1ErdlZ4TFlLeERzMm5SOTkwMmYxL2ZNWVNxRk1UYjVRZGkvNHp4d2FvUmlv?=
 =?utf-8?B?bDZBTWpXdHpIaWdxVHp2UThoRG1KQzdVbG9sRkRnSWExYzd1L1JyUUYzVW83?=
 =?utf-8?B?aStWbW9lZjNqWThkSGxUZmllaGgvOXRzS0Zka2g3N08yT2NmQzZpWExiS1BN?=
 =?utf-8?B?SU9mWlp1eWlJRmc0dURuU2Y2WmhvSmNCcVFXV1BWUDdtekozaDRlNHRrWVVu?=
 =?utf-8?B?SSszeVllb2dISVJEUUF0Q0RqeWpieDR0M0oyYUk0cXJVL05BR2V3Z05tU0pp?=
 =?utf-8?B?SXVsZzNkUEVjVmZ4eDE2SlpudjlVVGx4NWQzSDRXbWVwNTIrVHhQbXlrQnZY?=
 =?utf-8?B?cDNnL0E0dmpxSHVra3NRS3UwSy85R3hZYklMaFNCV01FRzNFQlZzL05zM0Q4?=
 =?utf-8?B?Ulc2UXRhVmhzd0VhQ2VLZWN1NzNYWjVNL1pPMFZFSmsrU3RQaWZXYi90YlN4?=
 =?utf-8?B?dHFCQnhxTnEzeVBaZkJHSnp2bFM2djhXaDBiWE96Z1FabXZUMVR4SkFsNXpZ?=
 =?utf-8?B?WUJUZGlickl5VWNjREYwQ3ByVUd2NW9GYVhzTjllQy8vaVZhSTh5MUhJUkIw?=
 =?utf-8?B?RGFXWE1VV1hWU2tUMXpoUFpCS3ozbDFJcnpGbzVuelRHR2FWS0RmdUNCZ3gw?=
 =?utf-8?B?d214L0FQZDg5SzVMeFRFVUN1MWlSM1BmNjRVUFJBZERCUWora2lYWE1iV3FJ?=
 =?utf-8?B?ZEZ6UFh1blF1WlUzY0ZLcHV5Q1NKQy9sNWNJbGVEYmNwejl6bXhMdTNkalBo?=
 =?utf-8?B?dUNsdVQxWFQ3ODgyQk81UHhOWlJCNy80S2dXN2hZWS84ZFU0T0VXdFdGcHA4?=
 =?utf-8?B?cEJYMmdodnp2M0ExL0VwVVEvWDg0SXQvbDNRNkdBPT0=?=
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;6:WBLtr3MXXwoiHkSwhKjB673n8OX329kgpwwMBXNqeCS/EQFBbUGHSsuqSk92sCCl2+JLRhBvCPJVKpDnluqxe7eIitEzjXfXh4mOW8U01bMeJovtsel8plK7iNeiw0+bRIpoLZi47r5AGXsxs/dmZXNRupF5ZK9F6suMm7OGKTbpHX0HyNZFESYLtBYP9agxizQkubL6c4gIh1/Yybom+vTlYV8SI+MHj7iJFYOmb+3QmtMvgf31vNll54wNpfyJgFbTnC0EhJy8byMN46lvfYLIsAILmr6trcwWxClGPxfS6clss2KZK/r3q0xkpzWNAH8m7ZBT0c65+enFhrJh7tbEXGvyS+J9jtmjqahPAkhzQXi3UqL76Q8ZbAcMJ09611t3mR1YC7rEpRQbEegkaxSnijiJ0u9NGm5cp2yUEII=;5:pzqEmbfXD1634cfC2rXSM9Esk+gpX9gLy0mBHGt1rCJgtjKgIhLKsHMeJhV9OVJsBhGKMweyrCiL4SHbK5CNwaSvWJU/ar1zjwYSoQaTjvAfMYHQ8beQC5FlSPXKD3WxSb0U5mjnfxF9q9bnzSLMfAf6WgiTrGChx9K9Y18SrBs=;24:FjvrVeHw1jlBi2zVZGiMJxIh0Rd1Giet37EvGDiMeDJJTHTGj8yitNhlxclTSa41EVFMsgjneP81dvWtuaN5qocnwo5FOjPscWHu4c6oj0k=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1;BLUPR0601MB1635;7:7BaS/kk9Q5ZaK3Y3BVeMBlAsV0tO/bcGbrxXHcz5ZMLMNXoVd2BiOe4Fgq+IgUQAhntgcK6XzHuJ42cwuYpF6aVjDo1jBhdG62EtEECrEcMUFRGpGCTLD82ljyFtNBtnsLGRp6J9qSG+q4Ky5tdTBv8Pm3pMUAcWnQzWA/QsUpm1NV1cDB4mUFrw2jjHdZOf5YpZ7mq45xxJSm9A3j1Em8zdiaR3x2bUf+PD1Em+EZ5GGTm392gP+Fh1Q2b5Rp+6RFTvGgP32xOM+OrPGJBr9F3wlJRskmupi4nBXr3DjHEx/KVXGbzT4y5IH3/oQrNRYMIGFDs+LBx03uIHMqiiTX692AbQF8+czBtVsfrOnq0QsSgPacFUb/+uVcEkdz6eFldr4BmCu28qkU7obFBYLvxR7o2sHKrJPAlI1nkOGG2/ep2s2tOJXUiDiLKSzjQfuxRUlqgB4zAVINN0aPoY1TzfHg7h4o7KbpJBMbu64Cu+nBnsGZ56G+ZSjFcO9ytbLiyt7V21TnSd6uoU9hVn+q7ikeNkYxyU6a7ppEPi9YVUJbbEnRofJ4n505T1KvhL
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2017 19:48:07.4192 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0601MB1635
X-OriginatorOrg: netapp.com
Return-Path: <Anna.Schumaker@netapp.com>
X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0)
X-Orcpt: rfc822;linux-mips@linux-mips.org
Original-Recipient: rfc822;linux-mips@linux-mips.org
X-archive-position: 56566
X-ecartis-version: Ecartis v1.0.0
Sender: linux-mips-bounce@linux-mips.org
Errors-to: linux-mips-bounce@linux-mips.org
X-original-sender: Anna.Schumaker@Netapp.com
Precedence: bulk
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
List-software: Ecartis version 1.0.0
List-Id: linux-mips <linux-mips.eddie.linux-mips.org>
X-List-ID: linux-mips <linux-mips.eddie.linux-mips.org>
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
X-list: linux-mips
Content-Length: 1346
Lines: 36

Hi Russell,

On 01/31/2017 02:18 PM, Russell King wrote:
> Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc
> code:
> 
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_setup_rdma_bc':
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c:348:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Fix this by adding linux/module.h to svc_rdma_backchannel.c
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>

This patch looks okay to me:

Acked-by: Anna Schumaker <Anna.Schumaker@Netapp.com>

> ---
>  net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> index 288e35c2d8f4..cb1e48e54eb1 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_backchannel.c
> @@ -4,6 +4,7 @@
>   * Support for backward direction RPCs on RPC/RDMA (server-side).
>   */
>  
> +#include <linux/module.h>
>  #include <linux/sunrpc/svc_rdma.h>
>  #include "xprt_rdma.h"
>  
> 

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"rmk+kernel@armlinux.org.uk" <rmk+kernel@armlinux.org.uk>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Subject: Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 31 Jan 2017 19:32:10 +0000	[thread overview]
Message-ID: <1485891116.3113.2.camel@sandisk.com> (raw)
Message-ID: <20170131193210.GyZ8pQ-NDxBxM78vGjvGRvyuO1Mzw8SZ1hwIIjlLiHc@z> (raw)
In-Reply-To: <E1cYdxN-0000Wr-AS@rmk-PC.armlinux.org.uk>

On Tue, 2017-01-31 at 19:19 +0000, Russell King wrote:
> drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration]
> 
> Add linux/module.h to iscsi_target_login.c.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  drivers/target/iscsi/iscsi_target_login.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c
> index 450f51deb2a2..eab274d17b5c 100644
> --- a/drivers/target/iscsi/iscsi_target_login.c
> +++ b/drivers/target/iscsi/iscsi_target_login.c
> @@ -17,6 +17,7 @@
>   ******************************************************************************/
>  
>  #include <crypto/hash.h>
> +#include <linux/module.h>
>  #include <linux/string.h>
>  #include <linux/kthread.h>
>  #include <linux/idr.h>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>

  reply	other threads:[~2017-01-31 19:32 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  0:14 [PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
2017-01-18  1:11 ` Vivien Didelot
2017-01-18  1:13 ` Florian Fainelli
2017-01-18 21:37 ` David Miller
2017-01-18 21:46   ` Russell King - ARM Linux
2017-01-18 21:48     ` David Miller
2017-01-18 21:47   ` David Miller
2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] " Russell King - ARM Linux
2017-01-31 19:17   ` Russell King - ARM Linux
2017-01-31 19:17   ` Russell King - ARM Linux
2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-01-31 19:48     ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:18   ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
2017-02-01  9:40     ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-01-31 19:18   ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 05/13] net: bgmac: " Russell King
2017-02-01  9:55     ` Rafał Miłecki
2017-01-31 19:18   ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
2017-02-01 10:27     ` Thomas Petazzoni
2017-02-01 10:27       ` Thomas Petazzoni
2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
2017-01-31 20:15     ` Timur Tabi
2017-01-31 20:15       ` Timur Tabi
2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
2017-01-31 19:32     ` Bart Van Assche [this message]
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:19   ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-02-01 19:07     ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
2017-02-01  5:34     ` Kalle Valo
2017-01-31 19:19   ` [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes Russell King
2017-02-01  2:42   ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-01  2:42     ` Florian Fainelli
2017-02-01  2:42     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485891116.3113.2.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.