From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751071AbdBBNX1 (ORCPT ); Thu, 2 Feb 2017 08:23:27 -0500 Received: from www262.sakura.ne.jp ([202.181.97.72]:14237 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbdBBNXZ (ORCPT ); Thu, 2 Feb 2017 08:23:25 -0500 From: Tetsuo Handa To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, Tetsuo Handa , Oleg Nesterov Subject: [PATCH 2/2] pid: Use for_each_thread() in do_each_pid_thread() Date: Thu, 2 Feb 2017 22:22:59 +0900 Message-Id: <1486041779-4401-2-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1486041779-4401-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> References: <1486041779-4401-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org while_each_pid_thread() is using while_each_thread(), which is unsafe under RCU lock according to commit 0c740d0afc3bff0a ("introduce for_each_thread() to replace the buggy while_each_thread()"). Use for_each_thread() in do_each_pid_thread() which is safe under RCU lock. Link: http://lkml.kernel.org/r/201702011947.DBD56740.OMVHOLOtSJFFFQ@I-love.SAKURA.ne.jp Signed-off-by: Tetsuo Handa Cc: Oleg Nesterov --- include/linux/pid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pid.h b/include/linux/pid.h index 23705a5..298ead55 100644 --- a/include/linux/pid.h +++ b/include/linux/pid.h @@ -191,10 +191,10 @@ static inline pid_t pid_nr(struct pid *pid) #define do_each_pid_thread(pid, type, task) \ do_each_pid_task(pid, type, task) { \ struct task_struct *tg___ = task; \ - do { + for_each_thread(tg___, task) { #define while_each_pid_thread(pid, type, task) \ - } while_each_thread(tg___, task); \ + } \ task = tg___; \ } while_each_pid_task(pid, type, task) #endif /* _LINUX_PID_H */ -- 1.8.3.1