From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH iproute2] ip route: Make name of protocol 0 consistent Date: Thu, 2 Feb 2017 09:22:06 -0800 Message-ID: <1486056126-23900-1-git-send-email-dsa@cumulusnetworks.com> Cc: David Ahern To: netdev@vger.kernel.org, stephen@networkplumber.org Return-path: Received: from mail-pg0-f45.google.com ([74.125.83.45]:34098 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdBBRWe (ORCPT ); Thu, 2 Feb 2017 12:22:34 -0500 Received: by mail-pg0-f45.google.com with SMTP id 14so7274214pgg.1 for ; Thu, 02 Feb 2017 09:22:34 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: iproute2 can inconsistently show the name of protocol 0 if a route with a custom protocol is added. For example: dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' local ::1 dev lo table local proto none metric 0 pref medium local fe80::225:90ff:fecb:1c18 dev lo table local proto none metric 0 pref medium local fe80::92e2:baff:fe5c:da5d dev lo table local proto none metric 0 pref medium protocol 0 is pretty printed as "none". Add a route with a custom protocol: dsa@cartman:~$ sudo ip -6 ro add 2001:db8:200::1/128 dev eth0 proto 123 And now display has switched from "none" to "unspec": dsa@cartman:~$ ip -6 ro ls table all | egrep 'proto none|proto unspec' local ::1 dev lo table local proto unspec metric 0 pref medium local fe80::225:90ff:fecb:1c18 dev lo table local proto unspec metric 0 pref medium local fe80::92e2:baff:fe5c:da5d dev lo table local proto unspec metric 0 pref medium The rt_protos file has the id to name mapping as "unspec" while rtnl_rtprot_tab[0] has "none". The presence of a custom protocol id triggers reading the rt_protos file and overwriting the string in rtnl_rtprot_tab. All of this is logic from 2004 and earlier. The simplest change to achieve consistency is to update the rt_protos file to use "none" instead of "unspec". Signed-off-by: David Ahern --- etc/iproute2/rt_protos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/iproute2/rt_protos b/etc/iproute2/rt_protos index 82cf9c46cf6f..21af85b9d7e1 100644 --- a/etc/iproute2/rt_protos +++ b/etc/iproute2/rt_protos @@ -1,7 +1,7 @@ # # Reserved protocols. # -0 unspec +0 none 1 redirect 2 kernel 3 boot -- 2.1.4