From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZcVQ-0007LT-M9 for qemu-devel@nongnu.org; Fri, 03 Feb 2017 06:58:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZcVN-0004Lw-Kl for qemu-devel@nongnu.org; Fri, 03 Feb 2017 06:58:20 -0500 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:34893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZcVN-0004LW-Eq for qemu-devel@nongnu.org; Fri, 03 Feb 2017 06:58:17 -0500 Received: by mail-wm0-x243.google.com with SMTP id u63so3899295wmu.2 for ; Fri, 03 Feb 2017 03:58:17 -0800 (PST) From: Pradeep Jagadeesh Date: Fri, 3 Feb 2017 06:57:21 -0500 Message-Id: <1486123043-26493-1-git-send-email-pradeep.jagadeesh@huawei.com> Subject: [Qemu-devel] [PATCH 0/2 v16] fsdev: add IO throttle support to fsdev devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" , Greg Kurz Cc: Pradeep Jagadeesh , Alberto Garcia , qemu-devel@nongnu.org This patch set adds the IO throttling functionality to fsdev/9p devices. So far cgroups were used for throttling IO opertions on the fsdev/9p devices. It is difficult to use cgroups for throttling because we have to set up cgroups externally before we start the qemu process. Qemu provides the throttling apis for implementing the throttling. Block devices already make use of these APIs for throtting the IO operations. So, we use the same APIs to enable the throttling functionality for fsdevices.As of now the feature is enabled only on 9p-local driver. This feature can be used as shown in the below example: -fsdev local,id=sdb1,path=PATH_TO_DEVICE,security_model=none,writeout=immediate, throttling.bps-read=4194304,throttling.bps-write=4194304 -device virtio-9p-pci,fsdev=sdb1,mount_tag=sdb1 The main advantages are: - Easy to use because the throttling options are part of qemu cli options - Provides a uniform way of using throttling options across block and fsdev/9p devices - No need to setup cgroup to provide throttling functionality for the fsdev devices. - Removes the redundant throttling code that was present in block and fsdev files Missing features: -QMP support -Throttling support for other fsdev/9p drivers. Thanks, Pradeep Pradeep Jagadeesh (2): fsdev: add IO throttle support to fsdev devices throttle: factor out duplicate code blockdev.c | 81 ++------------------------- fsdev/Makefile.objs | 2 +- fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 3 + fsdev/qemu-fsdev-throttle.c | 118 ++++++++++++++++++++++++++++++++++++++++ fsdev/qemu-fsdev-throttle.h | 39 +++++++++++++ hw/9pfs/9p-local.c | 8 +++ hw/9pfs/9p.c | 5 ++ hw/9pfs/cofile.c | 2 + include/qemu/throttle-options.h | 92 +++++++++++++++++++++++++++++++ 10 files changed, 275 insertions(+), 78 deletions(-) create mode 100644 fsdev/qemu-fsdev-throttle.c create mode 100644 fsdev/qemu-fsdev-throttle.h create mode 100644 include/qemu/throttle-options.h -- 1.8.3.1