From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbdBFI5U (ORCPT ); Mon, 6 Feb 2017 03:57:20 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:53646 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbdBFI5Q (ORCPT ); Mon, 6 Feb 2017 03:57:16 -0500 X-AuditID: b6c32a29-f79336d000001919-5f-58983a6036de Subject: Re: [PATCH 06/11] [media] videodev2.h: Add v4l2 definition for HEVC From: Smitha T Murthy To: Andrzej Hajda Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com, s.nawrocki@samsung.com In-reply-to: Content-type: text/plain; charset=UTF-8 Date: Mon, 06 Feb 2017 14:11:41 +0530 Message-id: <1486370501.16927.84.camel@smitha-fedora> MIME-version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-1.fc12) Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH++1uu3fm4teWdVgvuSCh5drGnHeSPUhkZX8o/mOF2kV/TMk9 2N16kbWydyH2IrWVJWVlqGOWmVio2YsehlnRSyoLek0Do6D3rteo/z6/c77f8zvncBhKU6HU McVOL/E4+RJWGSVvuRLPJq5IqcwxlF3ScU8a7yq47oYHMq7qxnYF19MTpLk7mz/SXGjgoYK7 3xZQcnuC5xVcQ/dzmqsL/ZBxtec/09yVj9sV86NtofqdSlvziY228nP1yDYcmmbr695EZyqW kTlFhC8knljiLHAVFjvtqWxGdv7C/CSLwZhotHLJbKyTd5BUNm1JZmJ6cUmkPTZ2FV/ii4Qy eUFgZ8+d43H5vCS2yCV4U9nlRqNJbzQk600mk95syk0xJUUkK0hRw9sPcnd79Jrmq4PIjz6p diEVA9gMV081KCWeCPf6myIcxWjwSQSP2sNIegwjGN72SfnXEfKXjSaCCM7uEy0Mo8VL4OlF u6hR4lnwZejWiH4CngGHbz6jRD2Fj8ogXNeExIQKz4P9xwMKkSkcD1svfKdFluM4+BYIUyKr cRK0170Zqa/G4+Fnq1bqYSY0+m/LJet0uBAOUFL8Gg0nbmwU5YCnQqiDkjANeptXSgotvL9+ jpZYBzcPv6DFzgCXITjSUiaXEhUIzmz1STwPOvoCo1+Ng8DuTplUUw07tmkkiQ0GB2pHay6A 0/cqKWk7O2TQ8fsxXYGmVf83ZPW/Yar/G+AYourRROIWHHYimN1WvcA7BJ/Tri9wOUJo5BoT 4ltR+fGMLoQZxEarg5mHcjQKfpWw1tGFgKHYCeosa2WORl3Ir11HPK58j6+ECF0oKbLTvZQu psAVuW2nN99othjNJqvFYrEaktlJ6qWGvTkabOe9ZCUhbuL565MxKp0f5ZZql71Pz8hLuZZi O91COrVVVa9jEty+ob7sp+UPB+6OmULCremvsmuOHKxqkvW2PTvpL03LQouKl+8ZvpOujdNn 53m+3v51UPW6rXHhIN7wq6K/d2leVtut2pral8dswaa4nhpSujqmc0vUkH3cO/2DsZdz1+Gv lesdBxZP3pfWz8qFIt6YQHkE/g9DCyybowMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLIsWRmVeSWpSXmKPExsWSnRNsqBtvNSPC4N42bYtb686xWhxZe5XJ YuaJdlaL8+c3sFucbXrDbrHp8TVWi8u75rBZ9GzYymqx9shddotlm/4wWSza+oXd4vCbdlYH Ho9NqzrZPDYvqffo27KK0ePzJjmPK0ca2QNYo9xsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU 8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CWsfbFa5aCPTwVm4++Y2xg/MDZxcjJ ISFgIrGpoZkRwhaTuHBvPVsXIxeHkMA6RokTv6azdDFycAgL+Ejc3pkOUsMmoCPx7f1pNhBb REBdYvbJO8wg9cwCM5kk/u75xgyS4BSwl5i8cA4rxKBuJomFJ3czgSSYBTQlWrf/ZgexWQRU JX7NeQvWwCtgKrFn2VM2kGW8AoISf3cIQxykLbGu4QwLRKu8xPa3c5gnMPLPQjJpFkLHLCRV CxiZVzGKpRYU56bnFhcYmOgVJ+YWl+al6yXn525iBEbdtsNKkjsYV63wOsQowMGoxMMbMGl6 hBBrYllxZe4hRgkOZiUR3kDLGRFCvCmJlVWpRfnxRaU5qcWHGE2BDp/ILCWanA9MCHkl8YYm phYWFiaWxsbGFiZK4ryx05+FCwmkJ5akZqemFqQWwfQxcXBKNTCa3PQ4fqNK37NI7trUb0+4 pq2sOn902b0JnNEFlduWv94pfkzx+I0Cq8d7upqElNvqpqiseu2SvmRHeH5kqblY88czOYEX lvU8Fct7MmGicYaSk7aMc5HRoid7PVJk35jVP7v/p/LYCgO2WIu/x248WR49bdlHH/XVHmrs nU92H5b+2TW7t+OfEktxRqKhFnNRcSIA1po7Y9ACAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170206085703epcas4p25d3e611957b7db12090a9209cc63ac31 X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG+yCvOyEseyghOyekBtMZWFkIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U21pdGhhIFQgTXVydGh5G1NTSVItVHVybiBLZXkgU29sdXRp?= =?UTF-8?B?b25zG1NhbXN1bmcgRWxlY3Ryb25pY3MbTGVhZCBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= CMS-TYPE: 104P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170118100742epcas5p1bb390dffa4fe530d94573f41d8791ef7 X-RootMTR: 20170118100742epcas5p1bb390dffa4fe530d94573f41d8791ef7 References: <1484733729-25371-1-git-send-email-smitha.t@samsung.com> <1484733729-25371-7-git-send-email-smitha.t@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-02-02 at 09:34 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > Beside small nitpick. > > Reviewed-by: Andrzej Hajda > > > --- > > include/uapi/linux/videodev2.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 46e8a2e3..620e941 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -630,6 +630,7 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_VC1_ANNEX_L v4l2_fourcc('V', 'C', '1', 'L') /* SMPTE 421M Annex L compliant stream */ > > #define V4L2_PIX_FMT_VP8 v4l2_fourcc('V', 'P', '8', '0') /* VP8 */ > > #define V4L2_PIX_FMT_VP9 v4l2_fourcc('V', 'P', '9', '0') /* VP9 */ > > +#define V4L2_PIX_FMT_HEVC v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC */ > > I am not sure if it shouldn't be sorted alphabetically in compressed > formats stanza. > > -- > Regards > Andrzej Actually the formats are not arranged alphabetically. For example #define V4L2_PIX_FMT_XVID is added before the #define V4L2_PIX_FMT_VC1_ANNEX_G. Hence I added the definition at the end. If required, I will take this as a separate patch. Thank you for the review. Regards, Smitha > > > > > /* Vendor-specific formats */ > > #define V4L2_PIX_FMT_CPIA1 v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */ > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: smitha.t@samsung.com (Smitha T Murthy) Date: Mon, 06 Feb 2017 14:11:41 +0530 Subject: [PATCH 06/11] [media] videodev2.h: Add v4l2 definition for HEVC In-Reply-To: References: <1484733729-25371-1-git-send-email-smitha.t@samsung.com> <1484733729-25371-7-git-send-email-smitha.t@samsung.com> Message-ID: <1486370501.16927.84.camel@smitha-fedora> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2017-02-02 at 09:34 +0100, Andrzej Hajda wrote: > On 18.01.2017 11:02, Smitha T Murthy wrote: > > Add V4L2 definition for HEVC compressed format > > > > Signed-off-by: Smitha T Murthy > Beside small nitpick. > > Reviewed-by: Andrzej Hajda > > > --- > > include/uapi/linux/videodev2.h | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index 46e8a2e3..620e941 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -630,6 +630,7 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_VC1_ANNEX_L v4l2_fourcc('V', 'C', '1', 'L') /* SMPTE 421M Annex L compliant stream */ > > #define V4L2_PIX_FMT_VP8 v4l2_fourcc('V', 'P', '8', '0') /* VP8 */ > > #define V4L2_PIX_FMT_VP9 v4l2_fourcc('V', 'P', '9', '0') /* VP9 */ > > +#define V4L2_PIX_FMT_HEVC v4l2_fourcc('H', 'E', 'V', 'C') /* HEVC */ > > I am not sure if it shouldn't be sorted alphabetically in compressed > formats stanza. > > -- > Regards > Andrzej Actually the formats are not arranged alphabetically. For example #define V4L2_PIX_FMT_XVID is added before the #define V4L2_PIX_FMT_VC1_ANNEX_G. Hence I added the definition at the end. If required, I will take this as a separate patch. Thank you for the review. Regards, Smitha > > > > > /* Vendor-specific formats */ > > #define V4L2_PIX_FMT_CPIA1 v4l2_fourcc('C', 'P', 'I', 'A') /* cpia1 YUV */ > > >