* [PATCH v3] staging: lustre: align else if statement to coding standard
@ 2017-02-06 12:26 Maksymilian Piechota
2017-02-06 12:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Maksymilian Piechota @ 2017-02-06 12:26 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Maksymilian Piechota, linux-kernel, devel
- move logical continuations at the end of line
- move else if statement to a single line
- Replace spaces with tabstop.
Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
---
drivers/staging/wlan-ng/prism2mgmt.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
index 16fb2d3..5277f36 100644
--- a/drivers/staging/wlan-ng/prism2mgmt.c
+++ b/drivers/staging/wlan-ng/prism2mgmt.c
@@ -1307,10 +1307,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
&& (msg->prismheader.data == P80211ENUM_truth_true)) {
hw->sniffhdr = 0;
wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
- } else
- if ((msg->wlanheader.status ==
- P80211ENUM_msgitem_status_data_ok)
- && (msg->wlanheader.data == P80211ENUM_truth_true)) {
+ } else if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) &&
+ (msg->wlanheader.data == P80211ENUM_truth_true)) {
hw->sniffhdr = 1;
wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
} else {
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: lustre: align else if statement to coding standard
2017-02-06 12:26 [PATCH v3] staging: lustre: align else if statement to coding standard Maksymilian Piechota
@ 2017-02-06 12:50 ` Greg Kroah-Hartman
2017-02-06 12:56 ` Maksymilian Piechota
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-06 12:50 UTC (permalink / raw)
To: Maksymilian Piechota; +Cc: linux-kernel, devel
On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> - move logical continuations at the end of line
> - move else if statement to a single line
> - Replace spaces with tabstop.
That's a lot of different things, happening all at once. Please break
this up into multiple patches, each one only doing one thing, and send a
patch series.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: lustre: align else if statement to coding standard
2017-02-06 12:50 ` Greg Kroah-Hartman
@ 2017-02-06 12:56 ` Maksymilian Piechota
2017-02-06 13:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Maksymilian Piechota @ 2017-02-06 12:56 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Maksymilian Piechota, linux-kernel, devel
On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > - move logical continuations at the end of line
> > - move else if statement to a single line
> > - Replace spaces with tabstop.
>
> That's a lot of different things, happening all at once. Please break
> this up into multiple patches, each one only doing one thing, and send a
> patch series.
>
> thanks,
>
> greg k-h
Fixing two lines of code in three patches?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: lustre: align else if statement to coding standard
2017-02-06 12:56 ` Maksymilian Piechota
@ 2017-02-06 13:03 ` Greg Kroah-Hartman
2017-02-06 14:50 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-06 13:03 UTC (permalink / raw)
To: Maksymilian Piechota; +Cc: linux-kernel, devel
On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > - move logical continuations at the end of line
> > > - move else if statement to a single line
> > > - Replace spaces with tabstop.
> >
> > That's a lot of different things, happening all at once. Please break
> > this up into multiple patches, each one only doing one thing, and send a
> > patch series.
> >
> > thanks,
> >
> > greg k-h
>
> Fixing two lines of code in three patches?
Yes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] staging: lustre: align else if statement to coding standard
2017-02-06 13:03 ` Greg Kroah-Hartman
@ 2017-02-06 14:50 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-02-06 14:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Maksymilian Piechota; +Cc: linux-kernel, devel
On Mon, 2017-02-06 at 14:03 +0100, Greg Kroah-Hartman wrote:
> On Mon, Feb 06, 2017 at 07:56:39AM -0500, Maksymilian Piechota wrote:
> > On Mon, Feb 06, 2017 at 01:50:02PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 06, 2017 at 07:26:56AM -0500, Maksymilian Piechota wrote:
> > > > - move logical continuations at the end of line
> > > > - move else if statement to a single line
> > > > - Replace spaces with tabstop.
> > >
> > > That's a lot of different things, happening all at once. Please break
> > > this up into multiple patches, each one only doing one thing, and send a
> > > patch series.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Fixing two lines of code in three patches?
>
> Yes.
Greg is also sometimes completely crazy.
I think he's only doing this because you are a
relatively new patch submitter and he wants you
to go through some linux-kernel process hazing.
It'd be more efficient as a single patch and better
overall to avoid descriptions with multiple
characteristics that elicit Greg's somewhat OCD
reflexes.
If this commit log was merely described as "use a
normal kernel style" for the else if and nothing
else was mentioned, this would likely have been
accepted.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-06 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 12:26 [PATCH v3] staging: lustre: align else if statement to coding standard Maksymilian Piechota
2017-02-06 12:50 ` Greg Kroah-Hartman
2017-02-06 12:56 ` Maksymilian Piechota
2017-02-06 13:03 ` Greg Kroah-Hartman
2017-02-06 14:50 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.