All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: rth@twiddle.net
Cc: famz@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PULL 0/5] target/hppa patch queue
Date: Mon, 6 Feb 2017 18:42:54 -0800 (PST)	[thread overview]
Message-ID: <148643537388.42.7004700064168762288@eba24e3a0d7f> (raw)
In-Reply-To: <20170207023229.29431-1-rth@twiddle.net>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PULL 0/5] target/hppa patch queue
Message-id: 20170207023229.29431-1-rth@twiddle.net

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/1486110164-13797-1-git-send-email-peterx@redhat.com -> patchew/1486110164-13797-1-git-send-email-peterx@redhat.com
 * [new tag]         patchew/20170207023229.29431-1-rth@twiddle.net -> patchew/20170207023229.29431-1-rth@twiddle.net
Switched to a new branch 'test'
ce2db6b target/hppa: Fix gdb_write_register
dfb4b9c target/hppa: Tidy do_cbranch
b17ea53 linux-user: define correct UTS machine name for hppa
84e4ae2 linux-user: fix "apt-get update" on linux-user hppa
a2cb156 linux-user: add hppa magic numbers in qemu-binfmt-conf.sh

=== OUTPUT BEGIN ===
Checking PATCH 1/5: linux-user: add hppa magic numbers in qemu-binfmt-conf.sh...
ERROR: line over 90 characters
#36: FILE: scripts/qemu-binfmt-conf.sh:95:
+hppa_magic='\x7f\x45\x4c\x46\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x0f'

ERROR: line over 90 characters
#37: FILE: scripts/qemu-binfmt-conf.sh:96:
+hppa_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff'

total: 2 errors, 0 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: linux-user: fix "apt-get update" on linux-user hppa...
Checking PATCH 3/5: linux-user: define correct UTS machine name for hppa...
Checking PATCH 4/5: target/hppa: Tidy do_cbranch...
Checking PATCH 5/5: target/hppa: Fix gdb_write_register...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2017-02-07  2:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07  2:32 [Qemu-devel] [PULL 0/5] target/hppa patch queue Richard Henderson
2017-02-07  2:32 ` [Qemu-devel] [PULL 1/5] linux-user: add hppa magic numbers in qemu-binfmt-conf.sh Richard Henderson
2017-02-07  2:32 ` [Qemu-devel] [PULL 2/5] linux-user: fix "apt-get update" on linux-user hppa Richard Henderson
2017-02-07  2:32 ` [Qemu-devel] [PULL 3/5] linux-user: define correct UTS machine name for hppa Richard Henderson
2017-02-07  2:32 ` [Qemu-devel] [PULL 4/5] target/hppa: Tidy do_cbranch Richard Henderson
2017-02-07  2:32 ` [Qemu-devel] [PULL 5/5] target/hppa: Fix gdb_write_register Richard Henderson
2017-02-07  2:42 ` no-reply [this message]
2017-02-07 15:29 ` [Qemu-devel] [PULL 0/5] target/hppa patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148643537388.42.7004700064168762288@eba24e3a0d7f \
    --to=no-reply@patchew.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.