From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Date: Tue, 07 Feb 2017 14:34:57 +0000
Subject: Re: [Intel-gfx] [patch] drm/i915/gvt/kvmgt: remove some dead code
Message-Id: <1486478097.3121.120.camel@linux.intel.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20170207131630.GA28207@mwanda>
In-Reply-To: <20170207131630.GA28207@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: Dan Carpenter <dan.carpenter@oracle.com>, Zhenyu Wang <zhenyuw@linux.intel.com>, Jike Song <jike.song@intel.com>
Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, intel-gvt-dev@lists.freedesktop.org

On ti, 2017-02-07 at 16:16 +0300, Dan Carpenter wrote:
> If "caps.buf" is already NULL then it doesn't need to be freed or set to
> NULL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

<SNIP>

> @@ -965,11 +965,8 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
>  			sparse->areas[0].offset >  					PAGE_ALIGN(vgpu_aperture_offset(vgpu));
>  			sparse->areas[0].size = vgpu_aperture_sz(vgpu);
> -			if (!caps.buf) {

Looking at the code around, the right thing would be to just remove the
negation? This currently seems like a memory leak.

> -				kfree(caps.buf);
> -				caps.buf = NULL;
> +			if (!caps.buf)
>  				caps.size = 0;
> -			}

And quickly looking, the caps is pre-initialized but unused at this
point, so the whole if could just be removed, right?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Subject: Re: [patch] drm/i915/gvt/kvmgt: remove some dead code
Date: Tue, 07 Feb 2017 16:34:57 +0200
Message-ID: <1486478097.3121.120.camel@linux.intel.com>
References: <20170207131630.GA28207@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20170207131630.GA28207@mwanda>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, Zhenyu Wang <zhenyuw@linux.intel.com>, Jike Song <jike.song@intel.com>
Cc: David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@intel.com>, intel-gvt-dev@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gdGksIDIwMTctMDItMDcgYXQgMTY6MTYgKzAzMDAsIERhbiBDYXJwZW50ZXIgd3JvdGU6Cj4g
SWYgImNhcHMuYnVmIiBpcyBhbHJlYWR5IE5VTEwgdGhlbiBpdCBkb2Vzbid0IG5lZWQgdG8gYmUg
ZnJlZWQgb3Igc2V0IHRvCj4gTlVMTC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVy
IDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+Cgo8U05JUD4KCj4gQEAgLTk2NSwxMSArOTY1LDgg
QEAgc3RhdGljIGxvbmcgaW50ZWxfdmdwdV9pb2N0bChzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYs
IHVuc2lnbmVkIGludCBjbWQsCj4gwqAJCQlzcGFyc2UtPmFyZWFzWzBdLm9mZnNldCA9Cj4gwqAJ
CQkJCVBBR0VfQUxJR04odmdwdV9hcGVydHVyZV9vZmZzZXQodmdwdSkpOwo+IMKgCQkJc3BhcnNl
LT5hcmVhc1swXS5zaXplID0gdmdwdV9hcGVydHVyZV9zeih2Z3B1KTsKPiAtCQkJaWYgKCFjYXBz
LmJ1ZikgewoKTG9va2luZyBhdCB0aGUgY29kZSBhcm91bmQsIHRoZSByaWdodCB0aGluZyB3b3Vs
ZCBiZSB0byBqdXN0IHJlbW92ZSB0aGUKbmVnYXRpb24/IFRoaXMgY3VycmVudGx5IHNlZW1zIGxp
a2UgYSBtZW1vcnkgbGVhay4KCj4gLQkJCQlrZnJlZShjYXBzLmJ1Zik7Cj4gLQkJCQljYXBzLmJ1
ZiA9IE5VTEw7Cj4gKwkJCWlmICghY2Fwcy5idWYpCj4gwqAJCQkJY2Fwcy5zaXplID0gMDsKPiAt
CQkJfQoKQW5kIHF1aWNrbHkgbG9va2luZywgdGhlIGNhcHMgaXMgcHJlLWluaXRpYWxpemVkIGJ1
dCB1bnVzZWQgYXQgdGhpcwpwb2ludCwgc28gdGhlIHdob2xlIGlmIGNvdWxkIGp1c3QgYmUgcmVt
b3ZlZCwgcmlnaHQ/CgpSZWdhcmRzLCBKb29uYXMKLS0gCkpvb25hcyBMYWh0aW5lbgpPcGVuIFNv
dXJjZSBUZWNobm9sb2d5IENlbnRlcgpJbnRlbCBDb3Jwb3JhdGlvbgpfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK