From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: [PATCH v2] xen-netfront: Improve error handling during initialization Date: Tue, 7 Feb 2017 14:55:12 +0000 Message-ID: <1486479312-18424-1-git-send-email-ross.lagerwall__37578.0439273969$1486479380$gmane$org@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb7As-0003WV-K5 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2017 14:55:18 +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: xen-devel@lists.xenproject.org Cc: Juergen Gross , wei.liu2@citrix.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ross Lagerwall , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org VGhpcyBmaXhlcyBhIGNyYXNoIHdoZW4gcnVubmluZyBvdXQgb2YgZ3JhbnQgcmVmcyB3aGVuIGNy ZWF0aW5nIG1hbnkKcXVldWVzIGFjcm9zcyBtYW55IG5ldGRldnMuCgoqIElmIGNyZWF0aW5nIHF1 ZXVlcyBmYWlscyAoaS5lLiB0aGVyZSBhcmUgbm8gZ3JhbnQgcmVmcyBhdmFpbGFibGUpLApjYWxs IHhlbmJ1c19kZXZfZmF0YWwoKSB0byBlbnN1cmUgdGhhdCB0aGUgeGVuYnVzIGRldmljZSBpcyBz ZXQgdG8gdGhlCmNsb3NlZCBzdGF0ZS4KKiBJZiBubyBxdWV1ZXMgYXJlIGNyZWF0ZWQsIGRvbid0 IGNhbGwgeGVubmV0X2Rpc2Nvbm5lY3RfYmFja2VuZCBhcwpuZXRkZXYtPnJlYWxfbnVtX3R4X3F1 ZXVlcyB3aWxsIG5vdCBoYXZlIGJlZW4gc2V0IGNvcnJlY3RseS4KKiBJZiBzZXR1cF9uZXRmcm9u dCgpIGZhaWxzLCBlbnN1cmUgdGhhdCBhbGwgdGhlIHF1ZXVlcyBjcmVhdGVkIGFyZQpjbGVhbmVk IHVwLCBub3QganVzdCB0aG9zZSB0aGF0IGhhdmUgYmVlbiBzZXQgdXAuCiogSWYgYW55IHF1ZXVl cyB3ZXJlIHNldCB1cCBhbmQgYW4gZXJyb3Igb2NjdXJzLCBjYWxsCnhlbm5ldF9kZXN0cm95X3F1 ZXVlcygpIHRvIGNsZWFuIHVwIHRoZSBuYXBpIGNvbnRleHQuCiogSWYgYW55IGZhdGFsIGVycm9y IG9jY3VycywgdW5yZWdpc3RlciBhbmQgZGVzdHJveSB0aGUgbmV0ZGV2IHRvIGF2b2lkCmxlYXZp bmcgYXJvdW5kIGEgaGFsZiBzZXR1cCBuZXR3b3JrIGRldmljZS4KClNpZ25lZC1vZmYtYnk6IFJv c3MgTGFnZXJ3YWxsIDxyb3NzLmxhZ2Vyd2FsbEBjaXRyaXguY29tPgotLS0KCkNoYW5nZWQgaW4g VjI6CiogUmV0ZXN0ZWQgb24gdG9wIG9mIHY0LjEwLXJjNyArICJ4ZW4tbmV0ZnJvbnQ6IERlbGV0 ZSByeF9yZWZpbGxfdGltZXIKICBpbiB4ZW5uZXRfZGlzY29ubmVjdF9iYWNrZW5kKCkiLgoqIERv bid0IG1vdmUgc2V0dXBfdGltZXIgYXMgaXQgaXMgbm90IG5lY2Vzc2FyeS4KCiBkcml2ZXJzL25l dC94ZW4tbmV0ZnJvbnQuYyB8IDMzICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQog MSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRmcm9udC5jIGIvZHJpdmVycy9uZXQveGVuLW5ldGZy b250LmMKaW5kZXggNzIyZmU5Zi4uNTM5OWE4NiAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQveGVu LW5ldGZyb250LmMKKysrIGIvZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMKQEAgLTE4MjMsMjcg KzE4MjMsMjMgQEAgc3RhdGljIGludCB0YWxrX3RvX25ldGJhY2soc3RydWN0IHhlbmJ1c19kZXZp Y2UgKmRldiwKIAkJeGVubmV0X2Rlc3Ryb3lfcXVldWVzKGluZm8pOwogCiAJZXJyID0geGVubmV0 X2NyZWF0ZV9xdWV1ZXMoaW5mbywgJm51bV9xdWV1ZXMpOwotCWlmIChlcnIgPCAwKQotCQlnb3Rv IGRlc3Ryb3lfcmluZzsKKwlpZiAoZXJyIDwgMCkgeworCQl4ZW5idXNfZGV2X2ZhdGFsKGRldiwg ZXJyLCAiY3JlYXRpbmcgcXVldWVzIik7CisJCWlmIChudW1fcXVldWVzID4gMCkgeworCQkJZ290 byBkZXN0cm95X3Jpbmc7CisJCX0gZWxzZSB7CisJCQlrZnJlZShpbmZvLT5xdWV1ZXMpOworCQkJ aW5mby0+cXVldWVzID0gTlVMTDsKKwkJCWdvdG8gb3V0OworCQl9CisJfQogCiAJLyogQ3JlYXRl IHNoYXJlZCByaW5nLCBhbGxvYyBldmVudCBjaGFubmVsIC0tIGZvciBlYWNoIHF1ZXVlICovCiAJ Zm9yIChpID0gMDsgaSA8IG51bV9xdWV1ZXM7ICsraSkgewogCQlxdWV1ZSA9ICZpbmZvLT5xdWV1 ZXNbaV07CiAJCWVyciA9IHNldHVwX25ldGZyb250KGRldiwgcXVldWUsIGZlYXR1cmVfc3BsaXRf ZXZ0Y2huKTsKLQkJaWYgKGVycikgewotCQkJLyogc2V0dXBfbmV0ZnJvbnQoKSB3aWxsIHRpZHkg dXAgdGhlIGN1cnJlbnQKLQkJCSAqIHF1ZXVlIG9uIGVycm9yLCBidXQgd2UgbmVlZCB0byBjbGVh biB1cAotCQkJICogdGhvc2UgYWxyZWFkeSBhbGxvY2F0ZWQuCi0JCQkgKi8KLQkJCWlmIChpID4g MCkgewotCQkJCXJ0bmxfbG9jaygpOwotCQkJCW5ldGlmX3NldF9yZWFsX251bV90eF9xdWV1ZXMo aW5mby0+bmV0ZGV2LCBpKTsKLQkJCQlydG5sX3VubG9jaygpOwotCQkJCWdvdG8gZGVzdHJveV9y aW5nOwotCQkJfSBlbHNlIHsKLQkJCQlnb3RvIG91dDsKLQkJCX0KLQkJfQorCQlpZiAoZXJyKQor CQkJZ290byBkZXN0cm95X3Jpbmc7CiAJfQogCiBhZ2FpbjoKQEAgLTE5MzMsOSArMTkyOSwxMCBA QCBzdGF0aWMgaW50IHRhbGtfdG9fbmV0YmFjayhzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LAog CXhlbmJ1c190cmFuc2FjdGlvbl9lbmQoeGJ0LCAxKTsKICBkZXN0cm95X3Jpbmc6CiAJeGVubmV0 X2Rpc2Nvbm5lY3RfYmFja2VuZChpbmZvKTsKLQlrZnJlZShpbmZvLT5xdWV1ZXMpOwotCWluZm8t PnF1ZXVlcyA9IE5VTEw7CisJeGVubmV0X2Rlc3Ryb3lfcXVldWVzKGluZm8pOwogIG91dDoKKwl1 bnJlZ2lzdGVyX25ldGRldihpbmZvLT5uZXRkZXYpOworCXhlbm5ldF9mcmVlX25ldGRldihpbmZv LT5uZXRkZXYpOwogCXJldHVybiBlcnI7CiB9CiAKLS0gCjIuNy40CgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==