All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: arekm@maven.pl
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Print text for disassociation reason.
Date: Wed, 08 Feb 2017 09:18:52 +0100	[thread overview]
Message-ID: <1486541932.4603.5.camel@sipsolutions.net> (raw)
In-Reply-To: <201702061453.08816.a.miskiewicz@gmail.com> (sfid-20170206_145427_070606_3E88921A)

> Don't know why it wasn't printed there with
> ieee80211_get_reason_code_string in first
> place. Works for me:
> 
> kernel: wlan0: disassociated from 04:b0:20:33:ff:1f (Reason:
> 34=DISASSOC_LOW_ACK)

This patch needs a "mac80211: " prefix, and I'd prefer no . at the end
(but that's not a hard rule)

> ps. can't send patch in normal way due to postmaster@vger weirdness,
> so inserted
> below
> 
> From c9b55bb44fe0b902f376a41fa930c9a67a438511 Mon Sep 17 00:00:00
> 2001
> From: =?UTF-8?q?Arkadiusz=20Mi=C5=9Bkiewicz?= <arekm@maven.pl>
> Date: Mon, 6 Feb 2017 14:45:15 +0100
> Subject: [PATCH] Print text for disassociation reason.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> When disassociation happens only numeric reason is printed
> in ieee80211_rx_mgmt_disassoc(). Add text variant, too.
> 
> Signed-off-by: Arkadiusz Miśkiewicz <arekm@maven.pl>

This is useless to me, please resubmit without all the fluff. You can
insert a "From: " line into the first line of the email *body* to get
the author correct, if you can't actually send it from the correct
email address. git send-email will even do that for you.

johannes

      reply	other threads:[~2017-02-08  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 13:53 [PATCH] Print text for disassociation reason Arkadiusz Miskiewicz
2017-02-08  8:18 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486541932.4603.5.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arekm@maven.pl \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.