All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uladzislau Rezki <urezki@gmail.com>
To: Ingo Molnar <mingo@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>
Subject: [RFC,v2 2/3] sched: set number of iterations to h_nr_running
Date: Wed,  8 Feb 2017 09:43:28 +0100	[thread overview]
Message-ID: <1486543409-11493-2-git-send-email-urezki@gmail.com> (raw)
In-Reply-To: <1486543409-11493-1-git-send-email-urezki@gmail.com>

From: Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>

It is possible that busiest run queue has multiple RT tasks,
whereas no CFS tasks, that is why it is reasonable to use
h_nr_running instead, because a load balance only applies
for CFS related tasks.

Signed-off-by: Uladzislau 2 Rezki <uladzislau2.rezki@sonymobile.com>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4be7193..232ef3c 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8081,7 +8081,7 @@ static int load_balance(int this_cpu, struct rq *this_rq,
 		 * Set loop_max when rq's lock is taken to prevent a race.
 		 */
 		env.loop_max = min(sysctl_sched_nr_migrate,
-						busiest->nr_running);
+						busiest->cfs.h_nr_running);
 
 		/*
 		 * cur_ld_moved - load moved in current iteration
-- 
2.1.4

  reply	other threads:[~2017-02-08  8:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08  8:43 [RFC,v2 1/3] sched: set loop_max after rq lock is taken Uladzislau Rezki
2017-02-08  8:43 ` Uladzislau Rezki [this message]
2017-02-09 12:20   ` [RFC,v2 2/3] sched: set number of iterations to h_nr_running Peter Zijlstra
2017-02-09 18:59     ` Uladzislau Rezki
2017-02-08  8:43 ` [RFC,v2 3/3] sched: ignore task_h_load for CPU_NEWLY_IDLE Uladzislau Rezki
2017-02-08  9:19   ` Mike Galbraith
2017-02-09 10:12     ` Uladzislau Rezki
2017-02-09 12:22   ` Peter Zijlstra
2017-02-09 18:54     ` Uladzislau Rezki
2017-02-13 13:51       ` Peter Zijlstra
2017-02-13 17:17         ` Uladzislau Rezki
2017-02-14 18:28           ` Uladzislau Rezki
2017-02-15 18:58             ` Dietmar Eggemann
2017-02-16 11:20               ` Uladzislau Rezki
2017-03-08 15:35                 ` Uladzislau Rezki
2017-02-09 12:14 ` [RFC,v2 1/3] sched: set loop_max after rq lock is taken Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1486543409-11493-2-git-send-email-urezki@gmail.com \
    --to=urezki@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=uladzislau2.rezki@sonymobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.