From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:54571 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752617AbdBILbu (ORCPT ); Thu, 9 Feb 2017 06:31:50 -0500 Message-ID: <1486638658.2284.27.camel@pengutronix.de> Subject: Re: [PATCH v2] drm/imx: imx-tve: Do not set the regulator voltage From: Philipp Zabel To: Fabio Estevam Cc: l.stach@pengutronix.de, dri-devel@lists.freedesktop.org, "# 4 . 8+" Date: Thu, 09 Feb 2017 12:10:58 +0100 In-Reply-To: <1486558069-22421-1-git-send-email-fabio.estevam@nxp.com> References: <1486558069-22421-1-git-send-email-fabio.estevam@nxp.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Wed, 2017-02-08 at 10:47 -0200, Fabio Estevam wrote: > Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by > regulator_set_voltage()") exposes the following probe issue: > > 63ff0000.tve supply dac not found, using dummy regulator > imx-drm display-subsystem: failed to bind 63ff0000.tve (ops imx_tve_ops): -22 > > When the 'dac-supply' is not passed in the device tree a dummy regulator is > used and setting its voltage is not allowed. > > To fix this issue, do not set the dac-supply voltage inside the driver > and let its voltage be specified in the device tree. > > Print a warning if the the 'dac-supply' voltage has a value different > from 2.75V. > > Fixes: deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()") > Cc: # 4.8+ > Suggested-by: Lucas Stach > Signed-off-by: Fabio Estevam Thanks, I've applied this instead of the devm_regulator_get_optional patch. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v2] drm/imx: imx-tve: Do not set the regulator voltage Date: Thu, 09 Feb 2017 12:10:58 +0100 Message-ID: <1486638658.2284.27.camel@pengutronix.de> References: <1486558069-22421-1-git-send-email-fabio.estevam@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 327EC6E184 for ; Thu, 9 Feb 2017 11:11:00 +0000 (UTC) In-Reply-To: <1486558069-22421-1-git-send-email-fabio.estevam@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabio Estevam Cc: "# 4 . 8+" , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMDE3LTAyLTA4IGF0IDEwOjQ3IC0wMjAwLCBGYWJpbyBFc3RldmFtIHdyb3RlOgo+ IENvbW1pdCBkZWI2NTg3MGI1ZDlkICgiZHJtL2lteDogaW14LXR2ZTogY2hlY2sgdGhlIHZhbHVl IHJldHVybmVkIGJ5Cj4gcmVndWxhdG9yX3NldF92b2x0YWdlKCkiKSBleHBvc2VzIHRoZSBmb2xs b3dpbmcgcHJvYmUgaXNzdWU6Cj4gCj4gNjNmZjAwMDAudHZlIHN1cHBseSBkYWMgbm90IGZvdW5k LCB1c2luZyBkdW1teSByZWd1bGF0b3IKPiBpbXgtZHJtIGRpc3BsYXktc3Vic3lzdGVtOiBmYWls ZWQgdG8gYmluZCA2M2ZmMDAwMC50dmUgKG9wcyBpbXhfdHZlX29wcyk6IC0yMgo+IAo+IFdoZW4g dGhlICdkYWMtc3VwcGx5JyBpcyBub3QgcGFzc2VkIGluIHRoZSBkZXZpY2UgdHJlZSBhIGR1bW15 IHJlZ3VsYXRvciBpcwo+IHVzZWQgYW5kIHNldHRpbmcgaXRzIHZvbHRhZ2UgaXMgbm90IGFsbG93 ZWQuCj4gCj4gVG8gZml4IHRoaXMgaXNzdWUsIGRvIG5vdCBzZXQgdGhlIGRhYy1zdXBwbHkgdm9s dGFnZSBpbnNpZGUgdGhlIGRyaXZlcgo+IGFuZCBsZXQgaXRzIHZvbHRhZ2UgYmUgc3BlY2lmaWVk IGluIHRoZSBkZXZpY2UgdHJlZS4KPiAKPiBQcmludCBhIHdhcm5pbmcgaWYgdGhlIHRoZSAnZGFj LXN1cHBseScgdm9sdGFnZSBoYXMgYSB2YWx1ZSBkaWZmZXJlbnQKPiBmcm9tIDIuNzVWLgo+IAo+ IEZpeGVzOiBkZWI2NTg3MGI1ZDlkICgiZHJtL2lteDogaW14LXR2ZTogY2hlY2sgdGhlIHZhbHVl IHJldHVybmVkIGJ5IHJlZ3VsYXRvcl9zZXRfdm9sdGFnZSgpIikKPiBDYzogPHN0YWJsZUB2Z2Vy Lmtlcm5lbC5vcmc+ICMgNC44Kwo+IFN1Z2dlc3RlZC1ieTogTHVjYXMgU3RhY2ggPGwuc3RhY2hA cGVuZ3V0cm9uaXguZGU+Cj4gU2lnbmVkLW9mZi1ieTogRmFiaW8gRXN0ZXZhbSA8ZmFiaW8uZXN0 ZXZhbUBueHAuY29tPgoKVGhhbmtzLCBJJ3ZlIGFwcGxpZWQgdGhpcyBpbnN0ZWFkIG9mIHRoZSBk ZXZtX3JlZ3VsYXRvcl9nZXRfb3B0aW9uYWwKcGF0Y2guCgpyZWdhcmRzClBoaWxpcHAKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=