From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 1/2] mm: Handle prefault for size >= 2GB
Date: Mon, 13 Feb 2017 12:58:43 +0200 [thread overview]
Message-ID: <1486983523.3223.27.camel@linux.intel.com> (raw)
In-Reply-To: <1486982918.3223.23.camel@linux.intel.com>
On ma, 2017-02-13 at 12:48 +0200, Joonas Lahtinen wrote:
> On ma, 2017-02-13 at 12:14 +0530, Sagar Arun Kamble wrote:
> > -static inline int fault_in_pages_writeable(char __user *uaddr, int size)
> > +static inline int fault_in_pages_writeable(char __user *uaddr,
> > + unsigned long size)
> > {
> > char __user *end = uaddr + size - 1;
>
> ptrdiff_t would be more appropriate for both functions. With those and
> correct "From:", this is;
Actually, size_t would be more appropriate, I don't think anybody is
using those negative values.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-02-13 10:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 6:44 [PATCH 1/2] mm: Handle prefault for size >= 2GB Sagar Arun Kamble
2017-02-13 6:44 ` [PATCH 2/2] drm/i915: Handle validation of relocation object with length >=2GB Sagar Arun Kamble
2017-02-13 10:58 ` Joonas Lahtinen
2017-02-13 11:02 ` Chris Wilson
2017-02-13 12:25 ` Joonas Lahtinen
2017-02-13 12:33 ` Chris Wilson
2017-02-13 16:05 ` Kamble, Sagar A
2017-02-13 7:21 ` ✓ Fi.CI.BAT: success for series starting with [1/2] mm: Handle prefault for size >= 2GB Patchwork
2017-02-13 10:48 ` [PATCH 1/2] " Joonas Lahtinen
2017-02-13 10:58 ` Joonas Lahtinen [this message]
2017-02-13 15:53 ` Kamble, Sagar A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486983523.3223.27.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.