All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC V2 1/5] nl80211: allow multiple active scheduled scan requests
Date: Tue, 14 Feb 2017 14:34:42 +0100	[thread overview]
Message-ID: <1487079282.4705.16.camel@sipsolutions.net> (raw)
In-Reply-To: <fbaa960e-b14a-e50c-c49e-913e823b1e74@broadcom.com> (sfid-20170214_143342_105651_593FDD48)

On Tue, 2017-02-14 at 14:33 +0100, Arend Van Spriel wrote:
> On 24-1-2017 10:40, Johannes Berg wrote:
> > > +	/* leave request id zero for legacy request
> > > +	 * or if driver does not support multi-scheduled scan
> > > +	 */
> > > +	if (want_multi && rdev->wiphy.max_sched_scan_reqs > 1) {
> > 
> > Why do the >1 check here? It probably doesn't really make a
> > difference
> > since only one can be running at a time, but it might be nicer - at
> > least for debug in userspace - to have a real value for all multi
> > scans?
> 
> I added the check, because drivers not supporting multi-scheduled
> scan might not bother using the request id in event reporting.

Ok, that's a good point.

johannes

  reply	other threads:[~2017-02-14 13:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 11:42 [RFC V2 0/5] cfg80211: support multiple scheduled scans Arend van Spriel
2017-01-16 11:42 ` [RFC V2 1/5] nl80211: allow multiple active scheduled scan requests Arend van Spriel
2017-01-24  9:40   ` Johannes Berg
2017-02-14 12:35     ` Arend Van Spriel
2017-02-14 12:51       ` Johannes Berg
2017-02-14 13:07         ` Arend Van Spriel
2017-02-14 13:12           ` Johannes Berg
2017-02-14 20:09             ` Arend Van Spriel
2017-02-14 20:11               ` Johannes Berg
2017-02-15 10:55                 ` Arend Van Spriel
2017-02-15 10:59                   ` Johannes Berg
2017-02-14 13:33     ` Arend Van Spriel
2017-02-14 13:34       ` Johannes Berg [this message]
2017-01-16 11:42 ` [RFC V2 2/5] nl80211: include request id in scheduled scan event messages Arend van Spriel
2017-01-16 11:42 ` [RFC V2 3/5] cfg80211: add request id parameter to .sched_scan_stop() signature Arend van Spriel
2017-01-16 11:42 ` [RFC V2 4/5] cfg80211: add request id to cfg80211_sched_scan_results() api Arend van Spriel
2017-01-16 11:42 ` [RFC V2 5/5] cfg80211: add request id in cfg80211_sched_scan_stopped{,_rtnl}() api Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487079282.4705.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.