All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: xgifb: add braces around if statement
@ 2017-02-16  9:53 Gargi Sharma
  2017-02-16  9:58 ` [Outreachy kernel] " Julia Lawall
  2017-02-16 18:10 ` Greg KH
  0 siblings, 2 replies; 3+ messages in thread
From: Gargi Sharma @ 2017-02-16  9:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: arnaud.patard, gregkh, Gargi Sharma

add braces around if statment to fix the checkpatch issue, braces {}
should be used on all arms of this statement.

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
 drivers/staging/xgifb/XGI_main_26.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7e..6d8120d 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -178,8 +178,9 @@ static int XGIfb_mode_rate_to_ddata(struct vb_device_info *XGI_Pr,
 		*sync |= FB_SYNC_HOR_HIGH_ACT;
 
 	*vmode = FB_VMODE_NONINTERLACED;
-	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080)
+	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080) {
 		*vmode = FB_VMODE_INTERLACED;
+	}
 	else {
 		j = 0;
 		while (XGI330_EModeIDTable[j].Ext_ModeID != 0xff) {
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: xgifb: add braces around if statement
  2017-02-16  9:53 [PATCH] staging: xgifb: add braces around if statement Gargi Sharma
@ 2017-02-16  9:58 ` Julia Lawall
  2017-02-16 18:10 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2017-02-16  9:58 UTC (permalink / raw)
  To: Gargi Sharma; +Cc: outreachy-kernel, arnaud.patard, gregkh



On Thu, 16 Feb 2017, Gargi Sharma wrote:

> add braces around if statment to fix the checkpatch issue, braces {}
> should be used on all arms of this statement.
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>

Looks good.  Congratulations on sending the first patch of this round :)

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>  drivers/staging/xgifb/XGI_main_26.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7e..6d8120d 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -178,8 +178,9 @@ static int XGIfb_mode_rate_to_ddata(struct vb_device_info *XGI_Pr,
>  		*sync |= FB_SYNC_HOR_HIGH_ACT;
>
>  	*vmode = FB_VMODE_NONINTERLACED;
> -	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080)
> +	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080) {
>  		*vmode = FB_VMODE_INTERLACED;
> +	}
>  	else {
>  		j = 0;
>  		while (XGI330_EModeIDTable[j].Ext_ModeID != 0xff) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1487238803-24600-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: xgifb: add braces around if statement
  2017-02-16  9:53 [PATCH] staging: xgifb: add braces around if statement Gargi Sharma
  2017-02-16  9:58 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-16 18:10 ` Greg KH
  1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-02-16 18:10 UTC (permalink / raw)
  To: Gargi Sharma; +Cc: outreachy-kernel, arnaud.patard

On Thu, Feb 16, 2017 at 03:23:23PM +0530, Gargi Sharma wrote:
> add braces around if statment to fix the checkpatch issue, braces {}
> should be used on all arms of this statement.
> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/xgifb/XGI_main_26.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7e..6d8120d 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -178,8 +178,9 @@ static int XGIfb_mode_rate_to_ddata(struct vb_device_info *XGI_Pr,
>  		*sync |= FB_SYNC_HOR_HIGH_ACT;
>  
>  	*vmode = FB_VMODE_NONINTERLACED;
> -	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080)
> +	if (XGI330_RefIndex[RefreshRateTableIndex].Ext_InfoFlag & 0x0080) {
>  		*vmode = FB_VMODE_INTERLACED;
> +	}
>  	else {

That line really should look like:
	} else {
right?

Can you please fix that up and send a "v2" of this patch?

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-16 18:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-16  9:53 [PATCH] staging: xgifb: add braces around if statement Gargi Sharma
2017-02-16  9:58 ` [Outreachy kernel] " Julia Lawall
2017-02-16 18:10 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.