From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Egbert Eich <eich@suse.com>
Subject: Re: [PATCH 2/2] drm/ast: Support AST2500
Date: Fri, 17 Feb 2017 08:16:15 +1100 [thread overview]
Message-ID: <1487279775.23576.87.camel@kernel.crashing.org> (raw)
In-Reply-To: <CACvgo53uiGxGRRteGGCaGMDyYsyEi3j8CZeVszFdthAU0iXfcQ@mail.gmail.com>
On Thu, 2017-02-16 at 17:33 +0000, Emil Velikov wrote:
> "Water is wet" type of comment. Worth mentioning why it's so large -
> mentioned in the documentation, experimental result, other ?
> Same suggestion goes for the other mdelay(100) instances.
Ah I removed most of those useless comments, I must have missed
that one. As for why 100ms, that's aspeed code. The init sequence
per-se isn't documented well, so I assume they know what they are doing
:-)
Keep in mind that this code is almost never used. It's only used
if the BMC is running no code at all, to "remotely" initialize its
memory controller.
Cheers,
Ben.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-16 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 9:09 [PATCH 2/2] drm/ast: Support AST2500 Benjamin Herrenschmidt
2017-02-16 11:40 ` Benjamin Herrenschmidt
2017-02-16 17:33 ` Emil Velikov
2017-02-16 21:09 ` Benjamin Herrenschmidt
2017-02-17 21:27 ` Emil Velikov
2017-02-17 21:36 ` Benjamin Herrenschmidt
2017-02-18 14:55 ` Emil Velikov
2017-02-18 3:41 ` Benjamin Herrenschmidt
2017-02-18 15:43 ` Emil Velikov
2017-02-18 22:22 ` Benjamin Herrenschmidt
2017-02-20 15:21 ` Emil Velikov
2017-02-16 21:12 ` Benjamin Herrenschmidt
2017-02-16 21:14 ` Benjamin Herrenschmidt
2017-02-16 21:16 ` Benjamin Herrenschmidt [this message]
2017-02-16 21:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487279775.23576.87.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eich@suse.com \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.