From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices Date: Thu, 16 Feb 2017 22:17:35 +0100 Message-ID: <1487279855.4629.8.camel@suse.com> References: <1487228041-1228-1-git-send-email-tang.junhui@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1487228041-1228-1-git-send-email-tang.junhui@zte.com.cn> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: tang.junhui@zte.com.cn, christophe.varoqui@opensvc.com, bmarzins@redhat.com, hare@suse.de, bart.vanassche@sandisk.com Cc: zhang.kai16@zte.com.cn, dm-devel@redhat.com, tang.wenjun3@zte.com.cn List-Id: dm-devel.ids SGVsbG8gVGFuZywKCkknbSBzb3JyeSB0byByZXBseSBzbyBsYXRlLiBUaGFua3MgYSBsb3QgZm9y IHlvdXIgd29yaywgSSBhZ3JlZSB3aXRoCkJlbiB0aGF0IHRoZSBwYXRjaCBpcyBpbiBwcmV0dHkg Z29vZCBzaGFwZSBub3cuIEJ1dCBJIGhhdmUgc29tZQpyZW1hcmtzwqBsZWZ0LCBwbGVhc2Ugc2Vl IGJlbG93LiAKIAo+ICtib29sCj4gK3VldmVudF9jYW5fZGlzY2FyZChzdHJ1Y3QgdWV2ZW50ICp1 ZXYpCj4gK3sKPiArCWNoYXIgKnRtcDsKPiArCWNoYXIgYVsxMV0sIGJbMTFdOwo+ICsJc3RydWN0 IGNvbmZpZyAqIGNvbmY7Cj4gKwo+ICsJLyoKPiArCcKgKiBrZWVwIG9ubHkgYmxvY2sgZGV2aWNl cywgZGlzY2FyZCBwYXJ0aXRpb25zCj4gKwnCoCovCj4gKwl0bXAgPSBzdHJzdHIodWV2LT5kZXZw YXRoLCAiL2Jsb2NrLyIpOwo+ICsJaWYgKHRtcCA9PSBOVUxMKXsKPiArCQljb25kbG9nKDQsICJu byAvYmxvY2svIGluICclcyciLCB1ZXYtPmRldnBhdGgpOwo+ICsJCXJldHVybiB0cnVlOwo+ICsJ fQo+ICsJaWYgKHNzY2FuZih0bXAsICIvYmxvY2svJTEwcyIsIGEpICE9IDEgfHwKPiArCcKgwqDC oMKgc3NjYW5mKHRtcCwgIi9ibG9jay8lMTBbXi9dLyUxMHMiLCBhLCBiKSA9PSAyKSB7Cj4gKwkJ Y29uZGxvZyg0LCAiZGlzY2FyZCBldmVudCBvbiAlcyIsIHVldi0+ZGV2cGF0aCk7Cj4gKwkJcmV0 dXJuIHRydWU7Cj4gKwl9CgpJJ2QgbGlrZSB0aGUgZm9sbG93aW5nIGJldHRlciBmb3IgdGhpcyBj aGVjay4gSXQgdXNlcyBtdWNoIGxlc3MgY3ljbGVzLgoKc3RhdGljIGJvb2wKY2FuX2Rpc2NhcmRf YnlfZGV2cGF0aChjb25zdCBjaGFyICpkZXZwYXRoKQp7CglzdGF0aWMgY29uc3QgY2hhciBCTE9D S1tdID0gIi9ibG9jay8iOwoJY29uc3QgY2hhciAqcDsKCglwID0gc3Ryc3RyKHBhdGhzdHIsIEJM T0NLKTsKCWlmIChwID09IE5VTEwpCgkJLyogbm90IGEgYmxvY2sgZGV2aWNlICovCgkJcmV0dXJu IHRydWU7CglwICs9IHNpemVvZihCTE9DSykgLSAxOwoJcCA9IHN0cmNocihwLCAnLycpOwoJaWYg KHAgPT0gTlVMTCkKCQkvKiBleGFjdGx5IG9uZSBwYXRoIGVsZW1lbnQgYWZ0ZXIgIi9ibG9jay8i ICovCgkJcmV0dXJuIGZhbHNlOwoJLyogSWYgdGhlcmUgYXJlIG1vcmUgcGF0aCBlbGVtZW50cywg aXQncyBhIHBhcnRpdGlvbiAqLwoJcmV0dXJuIHRydWU7Cn0KCj4gK2Jvb2wKPiArdWV2ZW50X2Nh bl9maWx0ZXIoc3RydWN0IHVldmVudCAqZWFybGllciwgc3RydWN0IHVldmVudCAqbGF0ZXIpCj4g K3sKPiArCj4gKwkvKgo+ICsJwqAqIGZpbHRlciBlYXJsaWVyIHV2ZW50cyBpZiBwYXRoIGhhcyBy ZW1vdmVkIGxhdGVyLiBFZzoKPiArCcKgKiAiYWRkIHBhdGgxIHxjaGFuZyBwYXRoMSB8YWRkIHBh dGgyIHxyZW1vdmUgcGF0aDEiCj4gKwnCoCogY2FuIGZpbHRlciBhczoKPiArCcKgKiAiYWRkIHBh dGgyIHxyZW1vdmUgcGF0aDEiCj4gKwnCoCogdWV2ZW50cyAiYWRkIHBhdGgxIiBhbmQgImNoYW5n IHBhdGgxIiBhcmUgZmlsdGVyZWQgb3V0Cj4gKwnCoCovCj4gKwlpZiAoIXN0cmNtcChlYXJsaWVy LT5rZXJuZWwsIGxhdGVyLT5rZXJuZWwpICYmCj4gKwkJIXN0cmNtcChsYXRlci0+YWN0aW9uLCAi cmVtb3ZlIikgJiYKPiArCQlzdHJuY21wKGxhdGVyLT5rZXJuZWwsICJkbS0iLCAzKSkgewo+ICsJ CXJldHVybiB0cnVlOwo+ICsJfQo+ICsKPiArCS8qCj4gKwnCoCogZmlsdGVyIGNoYW5nZSB1dmVu dHMgaWYgYWRkIHVldmVudHMgZXhpc3QuIEVnOgo+ICsJwqAqICJjaGFuZ2UgcGF0aDF8IGFkZCBw YXRoMSB8YWRkIHBhdGgyIgo+ICsJwqAqIGNhbiBmaWx0ZXIgYXM6Cj4gKwnCoCogImFkZCBwYXRo MSB8YWRkIHBhdGgyIgo+ICsJwqAqIHVldmVudCAiY2hhbmcgcGF0aDEiIGlzIGZpbHRlcmVkIG91 dAo+ICsJwqAqLwo+ICsJaWYgKCFzdHJjbXAoZWFybGllci0+a2VybmVsLCBsYXRlci0+a2VybmVs KSAmJgo+ICsJCSFzdHJjbXAoZWFybGllci0+YWN0aW9uLCAiY2hhbmdlIikgJiYKPiArCQkhc3Ry Y21wKGxhdGVyLT5hY3Rpb24sICJhZGQiKSAmJgo+ICsJCXN0cm5jbXAobGF0ZXItPmtlcm5lbCwg ImRtLSIsIDMpKSB7Cj4gKwkJcmV0dXJuIHRydWU7Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIGZhbHNl Owo+ICt9CgpUaGlzIHdvdWxkIGJlIGJldHRlciByZWFkYWJsZSBhbmQgZmFzdGVyIGlmIHlvdSdk IHB1dCB0aGUgImtlcm5lbCIKdGVzdHMgZmlyc3Qgc28gdGhhdCB5b3UgbmVlZCB0byBjaGVjayBv bmx5ICJhY3Rpb24iIGxhdGVyOgoKCWlmICghc3RybmNtcChsYXRlci0+a2VybmVsLCAiZG0tIiwg MykgfHwKCcKgwqDCoMKgc3RyY21wKGVhcmxpZXItPmtlcm5lbCwgbGF0ZXItPmtlcm5lbCkpCgkJ cmV0dXJuIGZhbHNlOwoKPiArCj4gK2Jvb2wKPiArbWVyZ2VfbmVlZF9zdG9wKHN0cnVjdCB1ZXZl bnQgKmVhcmxpZXIsIHN0cnVjdCB1ZXZlbnQgKmxhdGVyKQo+ICt7Cj4gKwkvKgo+ICsJwqAqIGRt IHVldmVudCBkbyBub3QgdHJ5IHRvIG1lcmdlIHdpdGggbGVmdCB1ZXZlbnRzCj4gKwnCoCovCj4g KwlpZiAoIXN0cm5jbXAobGF0ZXItPmtlcm5lbCwgImRtLSIsIDMpKQo+ICsJCXJldHVybiB0cnVl Owo+ICsKPiArCS8qCj4gKwnCoCogd2UgY2FuIG5vdCBtYWtlIGEganVnZW1lbnQgd2l0aG91dCB3 d2lkLAo+ICsJwqAqIHNvIGl0IGlzIHNlbnNpYmxlIHRvIHN0b3AgbWVyZ2luZwo+ICsJwqAqLwo+ ICsJaWYgKCFlYXJsaWVyLT53d2lkIHx8ICFsYXRlci0+d3dpZCkKPiArCQlyZXR1cm4gdHJ1ZTsK PiArCS8qCj4gKwnCoCogdWV2ZW50cyBtZXJnaW5nIHN0b3BlZAo+ICsJwqAqIHdoZW4gd2UgbWVl dCBhbiBvcHBvc2l0ZSBhY3Rpb24gdWV2ZW50IGZyb20gdGhlIHNhbWUgTFVOCj4gdG8gQVZPSUQK PiArCcKgKiAiYWRkIHBhdGgxIHxyZW1vdmUgcGF0aDEgfGFkZCBwYXRoMiB8cmVtb3ZlIHBhdGgy IHxhZGQKPiBwYXRoMyIKPiArCcKgKiB0byBtZXJnZSBhcyAicmVtb3ZlIHBhdGgxLCBwYXRoMiIg YW5kICJhZGQgcGF0aDEsIHBhdGgyLAo+IHBhdGgzIgo+ICsJwqAqIE9SCj4gKwnCoCogInJlbW92 ZSBwYXRoMSB8YWRkIHBhdGgxIHxyZW1vdmUgcGF0aDIgfGFkZCBwYXRoMiB8cmVtb3ZlCj4gcGF0 aDMiCj4gKwnCoCogdG8gbWVyZ2UgYXMgImFkZCBwYXRoMSwgcGF0aDIiIGFuZCAicmVtb3ZlIHBh dGgxLCBwYXRoMiwKPiBwYXRoMyIKPiArCcKgKiBTTwo+ICsJwqAqIHdoZW4gd2UgbWVldCBhIG5v bi1jaGFuZ2UgdWV2ZW50IGZyb20gdGhlIHNhbWUgTFVOCj4gKwnCoCogd2l0aCB0aGUgc2FtZSB3 d2lkIGFuZCBkaWZmZXJlbnQgYWN0aW9uCj4gKwnCoCogaXQgd291bGQgYmUgYmV0dGVyIHRvIHN0 b3AgbWVyZ2luZy4KPiArCcKgKi8KPiArCWlmICghc3RyY21wKGVhcmxpZXItPnd3aWQsIGxhdGVy LT53d2lkKSAmJgo+ICsJwqDCoMKgwqBzdHJjbXAoZWFybGllci0+YWN0aW9uLCBsYXRlci0+YWN0 aW9uKSAmJgo+ICsJwqDCoMKgwqBzdHJjbXAoZWFybGllci0+YWN0aW9uLCAiY2hhbmdlIikgJiYK PiArCcKgwqDCoMKgc3RyY21wKGxhdGVyLT5hY3Rpb24sICJjaGFuZ2UiKSkKPiArCQlyZXR1cm4g dHJ1ZTsKPiArCj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KCkkga25vdyB5b3UgZGlzY3Vzc2VkIHRo aXMgd2l0aCBCZW4gYmVmb3JlLCBidXQgc3RpbGwgaGF2ZSBzb21lIHRyb3VibGUKd2l0aCBpdC7C oAoKVGhlIGZpcnN0IGNhc2Ugc2hvdWxkIGhhdmUgYmVlbiByZWR1Y2VkIHRvICJyZW1vdmUgcGF0 aDEgfCByZW1vdmUgcGF0aDIKfCBhZGQgcGF0aDMiIGJ5IGZpbHRlcmluZyBiZWZvcmVoYW5kLsKg SSBzdXBwb3NlIHlvdSB3YW50IHRvIGF2b2lkIHRoaXMKc2VxdWVuY2UgYmVjYXVzZSBpdCBjb3Vs ZCBsZWF2ZSB1cyB3aXRob3V0IHBhdGhzIHRlbXBvcmFyaWx5LCBjYXVzaW5nCm11bHRpcGF0aGQg dG8gZGVzdHJveSB0aGUgbWFwLiBCdXQgSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgInN0b3AKbWVy Z2luZyIgYnV5cyB5b3UgaGVyZSAtIGlmIHlvdSBwcm9jZXNzIHRoZSBldmVudHMgb25lLWJ5LW9u ZSwgeW91IG1heQphbHNvIGhhdmUgMCBwYXRocyBhdCBzb21lIHBvaW50LiAKCkluIHRoZSBzZWNv bmQgY2FzZSwgd2Uga25vdyBhbGwgZXZlbnRzIGluIHRoZSBzZXF1ZW5jZSBoYXZlIHRoZSBzYW1l CldXSUQ7IGluIHRoaXMgY2FzZSBJIHRoaW5rIGl0IHdvdWxkIGJlIHNhZmUgdG8gZmlsdGVyIGF3 YXkgInJlbW92ZSIKZXZlbnRzIGJ5IHN1YnNlcXVlbnQgImFkZCIgZXZlbnRzLCBlbmRpbmcgdXAg d2l0aCAiYWRkIHBhdGgxfCBhZGQKcGF0aDJ8IHJlbW92ZSBwYXRoMyIuIEJ1dCBJIG1heSBiZSBv dmVybG9va2luZyBzb21ldGhpbmcgaGVyZS4KClRoZSBkYW5nZXJvdXMgdGhpbmcgaWYgeW91IGhh dmUgc2ltdWx0YW5lb3VzIHJlbW92ZSBhbmQgYWRkIGV2ZW50cyBmb3IKdGhlIHNhbWUgTFVOIGlz IHRoYXQgcHJvY2Vzc2luZyB0aGUgImFkZCIgZXZlbnRzIGlzIGxpa2VseSB0byBmYWlsIGluCmRv bWFwKCkuIElmIHlvdSBnZXQgImFkZCBwYXRoMSB8IHJlbW92ZSBwYXRoMiIsIG9uY2UgeW91IHBy b2Nlc3MgImFkZApwYXRoMSIsICJwYXRoMiIgbWF5IG5vdCBleGlzdCBpbiB0aGUga2VybmVsIGFu eSBtb3JlLCBhbmQgImRvbWFwIiB3aWxsCmZhaWwgaWYgeW91IHRyeSB0byBzZXQgdXAgYm90aDsg eW91IG1heSBlbmQgdXAgcmVtb3ZpbmcgdGhlIG1hcApjb21wbGV0ZWx5LiBJTUhPIHRoZSBvbmx5 IHNhZmUgd2F5IHRvIHByb2Nlc3MgZXZlbnRzIGluIHRoaXMgc2l0dWF0aW9uCmlzIHRvIG1lcmdl IHRoZSBldmVudHMgaW50byBhIHNpbmdsZSBkb21hcCgpIGNhbGwuCgpJIGtub3cgeW91IHdhbnQg dG8gYXZvaWQgdGhhdCBpbiB0aGlzIHBhdGNoLCBidXQgSSB0aGluayBpdCB3aWxsIGJlIGEKbG9n aWNhbCBmdXJ0aGVyIGltcHJvdmVtZW50LgoKQW55d2F5LCBBRkFJQ1MgeW91ciBwYXRjaCBkb2Vz bid0IGludHJvZHVjZSBhIHJlZ3Jlc3Npb24gd3J0IHRoZQpjdXJyZW50IGNvZGUgaGVyZTsgdW5s ZXNzIEknbSBvdmVybG9va2luZyBzb21ldGhpbmcsIG15IGFyZ3VtZW50cyB3b3VsZAphcHBseSB0 byBzZXF1ZW50aWFsIGV2ZW50IHByb2Nlc3NpbmcgYXMgd2VsbC4KClJlZ2FyZHMKTWFydGluCgot LSAKRHIuIE1hcnRpbiBXaWxjayA8bXdpbGNrQHN1c2UuY29tPiwgVGVsLsKgKzQ5ICgwKTkxMSA3 NDA1MyAyMTA3ClNVU0UgTGludXggR21iSCwgR0Y6IEZlbGl4IEltZW5kw7ZyZmZlciwgSmFuZSBT bWl0aGFyZCwgR3JhaGFtIE5vcnRvbgpIUkIgMjEyODQgKEFHIE7DvHJuYmVyZykKCi0tCmRtLWRl dmVsIG1haWxpbmcgbGlzdApkbS1kZXZlbEByZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5j b20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZlbA==