From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934144AbdBQOBr (ORCPT ); Fri, 17 Feb 2017 09:01:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60030 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933832AbdBQOBI (ORCPT ); Fri, 17 Feb 2017 09:01:08 -0500 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: David Ahern , Namhyung Kim , Peter Zijlstra , Borislav Petkov , lkml , Ingo Molnar Subject: [PATCH 4/5] perf stat: Add -a as a default target Date: Fri, 17 Feb 2017 15:00:57 +0100 Message-Id: <1487340058-10496-5-git-send-email-jolsa@kernel.org> In-Reply-To: <1487340058-10496-1-git-send-email-jolsa@kernel.org> References: <1487340058-10496-1-git-send-email-jolsa@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 17 Feb 2017 14:01:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Boris asked for default -a option in case we monitor only uncore events. While implementing that I thought it might be actually useful to make it overall default. # perf stat Warning: No target specified, setting system-wide collection (-a). ... Requested-by: Borislav Petkov Signed-off-by: Jiri Olsa Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Borislav Petkov Link: http://lkml.kernel.org/n/tip-tq11of2qlz8kxpxzva05d54l@git.kernel.org --- tools/perf/Documentation/perf-stat.txt | 2 +- tools/perf/builtin-stat.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt index d96ccd4844df..aecf2a87e7d6 100644 --- a/tools/perf/Documentation/perf-stat.txt +++ b/tools/perf/Documentation/perf-stat.txt @@ -63,7 +63,7 @@ report:: -a:: --all-cpus:: - system-wide collection from all CPUs + system-wide collection from all CPUs (default if no target is specified) -c:: --scale:: diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index f28719178b51..0d09ec7029d3 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2445,8 +2445,10 @@ int cmd_stat(int argc, const char **argv, const char *prefix __maybe_unused) } else if (big_num_opt == 0) /* User passed --no-big-num */ big_num = false; - if (!argc && target__none(&target)) - usage_with_options(stat_usage, stat_options); + if (!argc && target__none(&target)) { + pr_warning("Warning: No target specified, setting system-wide collection (-a).\n"); + target.system_wide = true; + } if (run_count < 0) { pr_err("Run count must be a positive number\n"); -- 2.7.4