From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752820AbdBRBif (ORCPT ); Fri, 17 Feb 2017 20:38:35 -0500 Received: from smtprelay0090.hostedemail.com ([216.40.44.90]:38195 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752552AbdBRBid (ORCPT ); Fri, 17 Feb 2017 20:38:33 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:2895:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:5007:6742:8957:10004:10400:10848:11232:11658:11914:12740:12760:12895:13161:13229:13255:13439:14096:14097:14181:14659:14721:21080:21433:30012:30029:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: top19_8464ab3c9d160 X-Filterd-Recvd-Size: 3412 Message-ID: <1487381908.2198.14.camel@perches.com> Subject: Re: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue From: Joe Perches To: Adan Hawthorn Cc: Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stephen Warren , Lee Jones , Eric Anholt , Michael Zoran , devel@driverdev.osuosl.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 17 Feb 2017 17:38:28 -0800 In-Reply-To: References: <1487362603-15967-1-git-send-email-adanhawthorn@gmail.com> <1487362603-15967-5-git-send-email-adanhawthorn@gmail.com> <1487380676.2198.11.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-02-17 at 20:32 -0500, Adan Hawthorn wrote: > Thanks, Joe. > > Is this to say that scripts/checkpatch.pl should be updated to some > higher column limit? I have made these cleanup changes before in a > like manner. Hard to say. There could be some sensitivity to long identifier name lengths added to checkpatch, but < 80 column line length is still currently "strongly preferred". I don't care much one way or another if it's 80 or 100 or something else as long as it's context appropriate. Awhile ago, Linus Torvalds wrote: On Thu, 2016-12-15 at 18:10 -0800, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 5:57 PM, Joe Perches wrote: > > > > > > In fact, I thought we already upped the check-patch limit to 100? > > > > Nope, CodingStyle neither. > > > > Last time I tried was awhile ago. > > Ok, it must have been just talked about, and with the exceptions for > strings etc I may not have seen as many of the really annoying line > breaks lately. > > I don't mind a 80-column "soft limit" per se: if some code > consistently goes over 80 columns, there really is something seriously > wrong there. So 80 columns may well be the right limit for that kind > of check (or even less). > > But if we have just a couple of lines that are longer (in a file that > is 3k+ lines), I'd rather not break those. > > I tend use "git grep" a lot, and it's much easier to see function > argument use if it's all on one line. > > Of course, some function calls really are *so* long that they have to > be broken up, but that's where the "if it's a couple of lines that go > a bit over the 80 column limit..." exception basically comes in. > > Put another way: long lines definitely aren't good. But breaking long > lines has some downsides too, so there should be a balance between the > two, rather than some black-and-white limit. > > In fact, we've seldom had cases where black-and-white limits work well. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: joe@perches.com (Joe Perches) Date: Fri, 17 Feb 2017 17:38:28 -0800 Subject: [PATCH 5/5] staging: bcm2835-audio: bcm2835.h: fix line length coding style issue In-Reply-To: References: <1487362603-15967-1-git-send-email-adanhawthorn@gmail.com> <1487362603-15967-5-git-send-email-adanhawthorn@gmail.com> <1487380676.2198.11.camel@perches.com> Message-ID: <1487381908.2198.14.camel@perches.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-02-17 at 20:32 -0500, Adan Hawthorn wrote: > Thanks, Joe. > > Is this to say that scripts/checkpatch.pl should be updated to some > higher column limit? I have made these cleanup changes before in a > like manner. Hard to say. There could be some sensitivity to long identifier name lengths added to checkpatch, but < 80 column line length is still currently "strongly preferred". I don't care much one way or another if it's 80 or 100 or something else as long as it's context appropriate. Awhile ago, Linus Torvalds wrote: On Thu, 2016-12-15@18:10 -0800, Linus Torvalds wrote: > On Thu, Dec 15, 2016 at 5:57 PM, Joe Perches wrote: > > > > > > In fact, I thought we already upped the check-patch limit to 100? > > > > Nope, CodingStyle neither. > > > > Last time I tried was awhile ago. > > Ok, it must have been just talked about, and with the exceptions for > strings etc I may not have seen as many of the really annoying line > breaks lately. > > I don't mind a 80-column "soft limit" per se: if some code > consistently goes over 80 columns, there really is something seriously > wrong there. So 80 columns may well be the right limit for that kind > of check (or even less). > > But if we have just a couple of lines that are longer (in a file that > is 3k+ lines), I'd rather not break those. > > I tend use "git grep" a lot, and it's much easier to see function > argument use if it's all on one line. > > Of course, some function calls really are *so* long that they have to > be broken up, but that's where the "if it's a couple of lines that go > a bit over the 80 column limit..." exception basically comes in. > > Put another way: long lines definitely aren't good. But breaking long > lines has some downsides too, so there should be a balance between the > two, rather than some black-and-white limit. > > In fact, we've seldom had cases where black-and-white limits work well. >