From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Egbert Eich <eich@suse.com>
Subject: Re: [PATCH 6/9] drm/ast: Factor mmc_test code in POST code
Date: Sun, 19 Feb 2017 09:20:46 +1100 [thread overview]
Message-ID: <1487456446.23576.155.camel@kernel.crashing.org> (raw)
In-Reply-To: <CACvgo53DiBRMJs8Oehz7qy5dbzto86rGvk_uPTWk+41sj=aYZQ@mail.gmail.com>
On Sat, 2017-02-18 at 15:28 +0000, Emil Velikov wrote:
> Original code does the following data flexing only for the mmc_*test2
> code, while this patch adds it to both test and test2.
>
> data = ast_mindwm(...);
> data = (data | (data >> 16)) & 0xffff;
> // ast_moutdwm(...);
> return data;
Actually that reading of the data isn't much of a problem from
my understanding of the spec, however it's the different exit
condition of the loop that could be.
Cheers,
Ben.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-02-18 22:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 5:32 [PATCH 1/9] drm/ast: Handle configuration without P2A bridge Benjamin Herrenschmidt
2017-02-17 5:32 ` [PATCH 2/9] drm/ast: const'ify mode setting tables Benjamin Herrenschmidt
2017-02-18 14:59 ` Emil Velikov
2017-02-17 5:32 ` [PATCH 3/9] drm/ast: Remove spurrious include Benjamin Herrenschmidt
2017-02-18 15:04 ` Emil Velikov
2017-02-17 5:32 ` [PATCH 4/9] drm/ast: Fix calculation of MCLK Benjamin Herrenschmidt
2017-02-18 15:04 ` Emil Velikov
2017-02-17 5:32 ` [PATCH 5/9] drm/ast: Base support for AST2500 Benjamin Herrenschmidt
2017-02-17 5:32 ` [PATCH 6/9] drm/ast: Factor mmc_test code in POST code Benjamin Herrenschmidt
2017-02-18 15:28 ` Emil Velikov
2017-02-18 22:20 ` Benjamin Herrenschmidt [this message]
2017-02-17 5:32 ` [PATCH 7/9] drm/ast: Rename ast_init_dram_2300 to ast_post_chip_2300 Benjamin Herrenschmidt
2017-02-17 5:32 ` [PATCH 8/9] drm/ast: POST code for the new AST2500 Benjamin Herrenschmidt
2017-02-17 5:32 ` [PATCH 9/9] drm/ast: Fixed vram size incorrect issue on POWER Benjamin Herrenschmidt
2017-02-17 7:43 ` [PATCH 1/9] drm/ast: Handle configuration without P2A bridge Benjamin Herrenschmidt
2017-02-17 10:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487456446.23576.155.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eich@suse.com \
--cc=emil.l.velikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.