From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbdBURWr (ORCPT ); Tue, 21 Feb 2017 12:22:47 -0500 Received: from smtprelay0193.hostedemail.com ([216.40.44.193]:47583 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754033AbdBURWh (ORCPT ); Tue, 21 Feb 2017 12:22:37 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2691:2828:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3870:3871:3872:4321:5007:7903:10004:10400:10848:11232:11658:11914:12049:12555:12740:12760:12895:13069:13255:13311:13357:13439:14659:14721:21080:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: skate03_6ce48916f6422 X-Filterd-Recvd-Size: 2021 Message-ID: <1487697745.2853.20.camel@perches.com> Subject: Re: [PATCH] Staging: comedi: drivers: comedi_test: Avoid multiple line dereference From: Joe Perches To: Cheah Kok Cheong , Valentin Rothberg Cc: Ian Abbott , hsweeten@visionengravers.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 21 Feb 2017 09:22:25 -0800 In-Reply-To: <20170221163141.GA22866@linux-Precision-WorkStation-T5500> References: <1487579315-14775-1-git-send-email-thrust73@gmail.com> <20170220160205.GA4017@linux-Precision-WorkStation-T5500> <675e00f6-2e6c-e486-898d-b942c76e26a0@mev.co.uk> <20170221093333.GA2775@linux-Precision-WorkStation-T5500> <4b35e656-8fc2-13a5-663b-c8db45bed832@mev.co.uk> <20170221102008.GA9653@costa.sra.uni-hannover.de> <20170221163141.GA22866@linux-Precision-WorkStation-T5500> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.3-0ubuntu0.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2017-02-22 at 00:31 +0800, Cheah Kok Cheong wrote: > > Another option could be using the typedefs from include/linux/types.h, > > e.g. ushort. However, this might require changing other declarations as > > well to keep consistency. > > Thanks for the idea. I counted seven instances of 'unsigned short' > in this file so it's not viable for our situation. I believe using ushort is relatively undesirable as "unsigned short" is preferred ~10:1 in the kernel $ git grep -w ushort | wc -l 1381 $ git grep -E "\bunsigned\s+short\b" | wc -l 11288 $ git grep --name-only -w "ushort" | wc -l 129 $ git grep --name-only -E "\bunsigned\s+short\b" | wc -l 2497