From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qi Zhang Subject: [PATCH v2] net/i40e: no more initial VF MAC address Date: Tue, 21 Feb 2017 17:45:29 -0500 Message-ID: <1487717129-26021-1-git-send-email-qi.z.zhang@intel.com> References: <1484703940-2967-1-git-send-email-qi.z.zhang@intel.com> Cc: dev@dpdk.org, Qi Zhang To: jingjing.wu@intel.com, helin.zhang@intel.com Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id EBA402BFF for ; Wed, 22 Feb 2017 06:50:06 +0100 (CET) In-Reply-To: <1484703940-2967-1-git-send-email-qi.z.zhang@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" During PF initialization, PF will generate an initial mac address for VFs, the purpose is to help VF keep a constant mac address between its startup/shutdown cycles. Now this is not necessary, since we already provide an API to set VF's MAC address from PF side (rte_pmd_i40e_set_vf_mac_addr). Application can use this API to lock down VF's mac address.(of course this should happen before VF init) While without this patch, we still can use rte_pmd_i40e_set_vf_mac_addr to overwrite the random one, but this patch align DPDK's default behavior with Kernel PF driver's, and this help to give an identical experience when work with kernel VF driver. Signed-off-by: Qi Zhang --- v2: add more explanation in commit log drivers/net/i40e/i40e_pf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index f771dfb..ffa8328 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -1349,7 +1349,6 @@ i40e_pf_host_init(struct rte_eth_dev *dev) ret = i40e_pf_host_vf_reset(&pf->vfs[i], 0); if (ret != I40E_SUCCESS) goto fail; - eth_random_addr(pf->vfs[i].mac_addr.addr_bytes); } /* restore irq0 */ -- 2.7.4