All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] vlc: disable on ARC
@ 2017-02-22 13:10 Vlad Zakharov
  2017-02-23 21:08 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Vlad Zakharov @ 2017-02-22 13:10 UTC (permalink / raw)
  To: buildroot

This package fails when building for ARC due to ARC toolchain issue.

Marking this with special comment "# ARC toolchain issue" as the package
is to be enabled as soon as issue with ARC toolchain is solved.

Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>
---
 package/vlc/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/vlc/Config.in b/package/vlc/Config.in
index 166e7d2..34c6cc0 100644
--- a/package/vlc/Config.in
+++ b/package/vlc/Config.in
@@ -11,6 +11,8 @@ config BR2_PACKAGE_VLC
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
+	# ARC toolchain issue
+	depends on !BR2_arc
 	select BR2_PACKAGE_LIBVORBIS if BR2_PACKAGE_OPUS
 	select BR2_PACKAGE_VLC_OPENCV_BACKEND if BR2_PACKAGE_OPENCV
 	select BR2_PACKAGE_VLC_OPENCV3_BACKEND if BR2_PACKAGE_OPENCV3
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] vlc: disable on ARC
  2017-02-22 13:10 [Buildroot] [PATCH] vlc: disable on ARC Vlad Zakharov
@ 2017-02-23 21:08 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-02-23 21:08 UTC (permalink / raw)
  To: buildroot

Hello,

On Wed, 22 Feb 2017 16:10:10 +0300, Vlad Zakharov wrote:
> This package fails when building for ARC due to ARC toolchain issue.
> 
> Marking this with special comment "# ARC toolchain issue" as the package
> is to be enabled as soon as issue with ARC toolchain is solved.
> 
> Signed-off-by: Vlad Zakharov <vzakhar@synopsys.com>

I've applied to master, but before that I had to fix two things:

 - You forgot to indicate a reference to an autobuilder failure in the
   commit log. It's very useful to have such references, so that if in
   the future we wonder in what exact configuration it was failing to
   build, we can reproduce.

 - You forgot to propagate the dependency to the Config.in comment in
   package/vlc/Config.in.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-23 21:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 13:10 [Buildroot] [PATCH] vlc: disable on ARC Vlad Zakharov
2017-02-23 21:08 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.