From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932588AbdBVOBI (ORCPT ); Wed, 22 Feb 2017 09:01:08 -0500 Received: from mail-cys01nam02on0068.outbound.protection.outlook.com ([104.47.37.68]:24992 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932334AbdBVOA6 (ORCPT ); Wed, 22 Feb 2017 09:00:58 -0500 Authentication-Results: spf=pass (sender IP is 204.128.141.24) smtp.mailfrom=infinera.com; kroah.com; dkim=none (message not signed) header.d=none;kroah.com; dmarc=bestguesspass action=none header.from=infinera.com; From: Joakim Tjernlund To: "greg@kroah.com" CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] Correct function definition for C++ Thread-Topic: [PATCH 1/2] Correct function definition for C++ Thread-Index: AQHSjFaMuPJoCVccYkCF9+ON7YxfW6F1IuUAgAALRwCAAFdVAIAAEBSA Date: Wed, 22 Feb 2017 14:00:53 +0000 Message-ID: <1487772051.5760.20.camel@infinera.com> References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> <20170222071022.GA9186@kroah.com> <1487749844.5760.17.camel@infinera.com> <20170222130318.GB15769@kroah.com> In-Reply-To: <20170222130318.GB15769@kroah.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.100.99.93] Content-Type: text/plain; charset="iso-8859-15" Content-ID: <0778F77AA2DE644193E3C22F674E8438@infinera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:204.128.141.24;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39450400003)(39830400002)(39410400002)(2980300002)(438002)(189002)(199003)(24454002)(377424004)(38730400002)(33646002)(102836003)(103116003)(2900100001)(3846002)(92566002)(6916009)(110136004)(6246003)(54356999)(2950100002)(6116002)(626004)(229853002)(47776003)(50986999)(76176999)(305945005)(54906002)(7636002)(77096006)(7736002)(5660300001)(36756003)(2501003)(53416004)(8746002)(23756003)(1730700003)(5640700003)(86362001)(8936002)(356003)(93886004)(4326007)(2906002)(2351001)(106116001)(106466001)(189998001)(246002)(50466002)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR10MB0455;H:owa.infinera.com;FPR:;SPF:Pass;PTR:outgoingmail2.infinera.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2NAM03FT016;1:TD+1ylQFu3I+AqkXsVkw0OLU13slqy4LzhzKWk1pa9ID9glWYAmJ1Yo7PVB4v6oD4qzfsASI+QfKUy8SnYPgTyBQJNDUDxrE6XF55RwzeJHwItm+5XH5BqzEEicBQQgWxCrSVL4i+xzlUnrQdRJc1LUXaicX7h+lz0GJhFE5sVPsAD0r/Sog4n0k2WtBgWwkdTr7HK+vBlb6V2ruiFGpGSz+V8fBB5OZCWmfXfPyTYQeX/JlJNrqF0g/X9wlHkW8veyuyvglc16ninz5QvA/+jHTfXh9zSUyjPC3yGNIwrugby3IByiLY43FusPDJD/laUwGjx/CrmWeCCrx6/GW4ejbBkiPJwueYl5LBpkaCmBiKOmFiV+oZvuq1y01BAOPt3iME/stmxvGMNF4xEisA3cNCqIJcC/y68EsLuLDYLWptbnZqGQN3k0XBpRYtTjlTUQrtgGOgiHtSlSrmOEcvfsPVVcRkCEGIRCKiddpim0Dc2cN5ROj65nUCkGRRdR4CGgU6Zyebw7Qk/YYLRJwvDLXQSnZOTpNW9hWHu6urWk= X-MS-Office365-Filtering-Correlation-Id: 1bbf9a98-90aa-453b-dbbd-08d45b2b384e X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(8251501002);SRVR:BY1PR10MB0455; X-Microsoft-Exchange-Diagnostics: 1;BY1PR10MB0455;3:fFJXZN6vZMVdYi+xdGpe5nT+8+9huNFEcRllVC3CMTS4kJw/AspooMxERNqgIS8DI0kICpPWSRQfKc/nENBhK73kGwWMj9cWddxMTkoXrWpb402spKUEDK94rUDg46DOWx/Vn5C0OGbAe2AVSy8bJVPy9SSECm1NhD5tMS3Xcm8yWmJPAmCJJfTtKBm2KIDEOG/glp780WQ1WUfz8R5vbL6QwXyeS58JFST+qc14XUzny8Sm9xAWfCJihTSXqliuX/IPzmhuUiSnGp3TKSLjVFJeVBvegjbjYkOhjwfbPxl45aNknvwr/VfLM6wggniLVk9RF0ZZ2lVnJ0kwn1RGpWgRCkRBjMSwM/AUtbhTuvwgMsxbYKLkBdFePF/A+sokxeVcXhjSB37e1Ip2kyL55Q==;25:a0zuETHEmZOQvxUzwZgkWLk7U75ThXT+HrNbLCmIQaz2CIWdvy3N/w6JHu+AIAVG4KHP+HKHJ7LWF/nDlCJL180A3paW1/3ao7mYJyS7zn5KhX3kYqjoNbfOFzGo9bhzbuS/5SymIrTfgCJss27BQ1IMjiN863AsKg3vIj0gp7AcmjywE2D6kbrIkLq+NcuUvuuMdT0tAaXPF4VDPhuk5uoS+zR/eEdPtvELigu6yr07Y4kLJ7Zy3VmwoxnY2FzZ/bT5pLJkLcDS+d8E/EXfBuibaTN1JI6BJIuDyWiW/KANxiKSvoRk3fbedGycp845chAm5ECC5kyBElNiAaUs93hdVEtsiEDL8tOirFoFqJBnjbuYel1KcLAnpmEsQsnj+mxhXyJeOvM9helsJz3DB8yOMLIChmF95J6YkZ1HTwz7stD92LuOl94SnfDt2ioKCJeREyKJAMIOdUjyefgXJQ== X-Microsoft-Exchange-Diagnostics: 1;BY1PR10MB0455;31:JfpS6D92dcxgowJA8RkxNMXYLOsUVcT7KhRtwPDYJ9Xayuc+Y5ztpCiOPBfRVZPpx0Lez65hjtxCK7zbBgRfR0X5sIl/mNOhI8uHTfkxSRYHFW8QTjVjeuuGP5x7ZUHJH/bF+N0rYeo5647yl6e9FgfuQkWSoPyv9JQYraKwy2ds1Sb8FcFSeVMhx0nynP6gQWJW/VVTjCVBLS3I/jMXWnhcy1oIre5ZpbffQhpljyZGfabsb6qdAHGk8GqW8ZaAEtElwOS4P2A2o2eyUK3QwA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(13015025)(5005006)(13023025)(13017025)(13024025)(13018025)(3002001)(10201501046)(6041248)(20161123560025)(20161123558025)(20161123562025)(20161123564025)(20161123555025)(6072148);SRVR:BY1PR10MB0455;BCL:0;PCL:0;RULEID:;SRVR:BY1PR10MB0455; X-Microsoft-Exchange-Diagnostics: 1;BY1PR10MB0455;4:G50qmg1IiJgF+MczbzMcSgaKBmvs16bMqiTzL6G2HSdJGfN0U9Yiu87m2jRFc3x4IuV+T9R73aHFwza9lDbuS+47DLqcq3kqRdBCxMCepAwMsDPZrBuv+SkPiWA53ajnDv5skc5uAlIUZeYmkHzMWSEJx7oQ4AU56xIGwFktUZ65FFcuF645pJKXp82Funel+bIrDOGSZ5W8+e6IlWbt3dL2wElonpG4lTZOxQBy4QjYfBK6jLF/FTXLwc7z1M9GsEaCWuy0E17y23g36X5zsIg3LUBxsBXdnP/vh5ghO4L0RdsxtpNTZc8iqKXqem9jmBdX4mpqZqQEbGJ2wYUaJ/hN+h3df52Fr3bZQ7VqZdxCi+lafeaqSZd3h42/o0Vk+CodHU/VaNy8TU1RGSVADGJ4xAsSRmPlVjocV6xxJm3y3XjwHKg+EHbyZnl3t+iTknHyIOr0d8ZdvYmBHnOLSc9QtHVZtgJA6FpbijBkGZehNSqtl7THAkhTkFzUDTYKQMeSlhc971iO7V4sTq8JOvgVT3Xkf/KX259ZykjdK+wzSq394TVhHMzY1RhOL1K7dl8W9NtmC46Ugl0hVf29cahyXHtzIkedegS1bv3KP75H9LGQ+pZFyZ28Ev0Xpx6/LNkn6wD/84X7o0t5MJ3SPBnlnBosLG/AMENIA+2CYrKOh9vJj1pbo6V2Skj5WmgTGeHvFY84aBI6mwYHWKnaug== X-Forefront-PRVS: 022649CC2C X-Microsoft-Exchange-Diagnostics: =?iso-8859-15?Q?1;BY1PR10MB0455;23:HzBIxQ6ky74Ng9fz9pTdnqj0NyxMsQQIwXRo7l?= =?iso-8859-15?Q?sb13pUFCSv8tT89LNMvfNp6ZfwXFspH9qbYZxk8el4mlRZc4kmQkwAean?= =?iso-8859-15?Q?1BPcAJd1hABC3lubPRfsXdlnXEJvLLsLyddcC/MENAFXe5YAGi7poZSly?= =?iso-8859-15?Q?z76POevP7ulKYQIn0FQ5XuArG9uwERkaIZ0MB4lo/1uyYdUz+FFFTtXO4?= =?iso-8859-15?Q?Zo//RzvaLRzH8PM6cYyEzUvtb5/iIdlO0X6biGzE05bhcFmV2FXi/XB7w?= =?iso-8859-15?Q?rEvz4vsKOpekx8TGueCrAXjkz5MyL/dsy9DfEqml8rPbIxQnFn/ZeQa4S?= =?iso-8859-15?Q?LP9KZTdl8PtVWbaHc2iPvhG0ZAoDR0c7cczXCbVcTh4ByKVUprlLq9Mjh?= =?iso-8859-15?Q?ZY1ww6aLdtWoH2FmZ/C4eObTqn+a+K5k5DnAN+ks5kGE2OOzzaQV9wV3s?= =?iso-8859-15?Q?Ier/VMIdjQZuCKY7P0DrL1qB/V2VFzdplPwnOyCiheG7Qibj3Fe9HP7hc?= =?iso-8859-15?Q?N7QbL++afahvg2IHFS5VZwqXQs9yFgJtimOEUPaDHD/tggnSTtzvajhb6?= =?iso-8859-15?Q?AsAFP/J7Ac80E+EvYWpRm6osxWg17UN+mnHtTJ8kViCxOSV7S/CfMdRN/?= =?iso-8859-15?Q?wb6KEOeTWd+vehkxUrm108hXNfGXrxhY5oPaTAMZve1utgwSPtZwZlydp?= =?iso-8859-15?Q?Ax4+cJJWx0ItUMbJ4Kkd7gZqMRV5jR6NnMtvLHCneG+9A5JMznqGUwNW9?= =?iso-8859-15?Q?08tFKvdPZc64fa0s6gyZbJEWoEtqcbXhz2DRXkIvs2NkkLaNVOEC2nE3M?= =?iso-8859-15?Q?G2PlAD77SsYTW9rBuH1Cu+tYub7YJHUSCZ5DhvaXabIg7J25S8WngOV8Z?= =?iso-8859-15?Q?hySDyAzgmOjsVulF0HP4kwJM2i5mQ10h8Jp9fvaCSqEAd4/GdX9GMzc8W?= =?iso-8859-15?Q?7c4QZbTEdSfi1hiMX0Pamw8DrZINw7PvZJLuT2Wi43wZXlN/tE6CzhiP9?= =?iso-8859-15?Q?nWTYOCmXzKnp3LbnS32ktGCyG8mrIBVBwPoyXRHVWUX3V9ii7o3PJy3Su?= =?iso-8859-15?Q?wGd2Pws3WbTAcu4Qq+tw2BNQabbWg3plttS7xsEtps/jf+Vrame3LhxwA?= =?iso-8859-15?Q?bmN1KVzu7q8ir6FSVl4oJC9EANHYiATseXpnmhYN3U/RtlqYeVP9qSweG?= =?iso-8859-15?Q?iQ5orQslx+6whf1M8BfY1wJM/6z5aIkApIxNp3c0ZS7PajFujINGvQa1m?= =?iso-8859-15?Q?NplM96CBLte3E+Xc6f5inOYUd1KBfJv3YzbGXnWOgcoY0F+Zt3Zsfh8fu?= =?iso-8859-15?Q?sm84mAcqYEJI689u3dzB4p2IOqW0+HiOcCK3kSdhm6aOh1gnjZmp3YurX?= =?iso-8859-15?Q?3xL3qH018A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR10MB0455;6:KhycHMWeCCn409n1JRWTxoR9gZqnRfPsM7mglm95r4Ah5CFbjARzwodhMyMb4fidOtu6iBhOYpBvvfLA2iVPFQqueoSDLEOwgN2hxahpOm1r7iYHo6kmk2mihfWZq1V7q6QXnleoA09yBUgHP57eUqoPr3FUqU/bCg/uKVL3Q3EUn4RRvggEwpTmtlkav59Jh4nl5sJVE1RoWP96MwpxqzsIniad1+usghFB/NLEgH1i6AF43uAd7RFAmkAbBMXsH3ic/WOo1CEKKFApACwWTmM7lK0yfwmWijnzbLAQBBR8de27/la7bOo4ymD08EqKAZVv3Poh4EBc6ntnMwXPPU/7eGptXMLzA31o+VFrNOb/aoY+AHgD7Upm9X/nfnjIemfTzSG2+SQbJYxEF7fOXg==;5:S5SZcMgnM0oe4QRNOZMnNhOZjFalQDTOnt71sQu5IanO/9zcO61WtXlR9DI9XXpD1WaTxUgsqHM5UFc8yiBxy6OkSv/f1tWwuyr0OicKxvkhEgK8qQBU4Nixm51JHypTuUwqvYc4ErreMJyH9/4WKQ==;24:YKDiVyCyKFiD7GwQ4cABRM3m/cZ6n1kEt5vJ5mMuqVpRe1edA9Juq1l6iUDJxJytZmgsX+3IHUoQpv7wnzSfju8iKYDX8Bn3hLd3t6A3cuk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY1PR10MB0455;7:P01d4ds9EYsyJinE+TR9Z0hC3uF2PGozm37878sCZZpbEx61His1ZXPEGWr4lEjwc57LL3vpZDf/eoN4cdNfIE7EsoJtfIEAT+XLKibkKwx1+NuTObf2PyPMexLzt35lgFTIjP23DEhDuYawnth7IOeDo8wE9ABdVU7KEy+8Pip5SL7aI1L3pNEDOsor+NWhJ/sV+Op1ioeDh/Ro6VeZB0bCfOAF5x37RN37nJZcedwF1y5xCuYhDnywZWzkUzCePdwSe6OlASFi9HoV7G8oawABXm2RvYPRjhgqAnOkr/SXJi0mKb77PCdLlusPJ0K5TNBG0qyIHs9uCLLdqrGcDA== X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2017 14:00:55.0933 (UTC) X-MS-Exchange-CrossTenant-Id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=285643de-5f5b-4b03-a153-0ae2dc8aaf77;Ip=[204.128.141.24];Helo=[owa.infinera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR10MB0455 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1ME1B0D011930 On Wed, 2017-02-22 at 14:03 +0100, greg@kroah.com wrote: > On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote: > > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > > > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > > > > > Signed-off-by: Joakim Tjernlund > > > > --- > > > > include/linux/printk.h | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h > > > > index 3472cc6..be823f5 100644 > > > > --- a/include/linux/printk.h > > > > +++ b/include/linux/printk.h > > > > > > > > > Why are you building this file with a C++ compiler? > > > > virtualbox uses C++ and includes various kernel headers and the build > > fails, virtualbox guest additions has not build for quite some time now and > > this is one of the problems. > > Virtualbox is a horrid pile of crap. You can quote me on that. We > don't care about out-of-tree drivers, the authors should work to get > them merged properly if they do care. Sure, I believe you :) But in this case it is not the kernel modules that fails, it is their guest additions/xf86 video driver. Seem like that these need to include some kernel herders there too. > > Kernel code should be C, not C++, and if you do want to use C++, then > you are on your own, sorry. But there are already a lot of C++ adjustments!? Just grepping for __cplusplus shows plenty of hits and what is the point of asmlinkage then: #ifdef __cplusplus #define CPP_ASMLINKAGE extern "C" #else #define CPP_ASMLINKAGE #endif #ifndef asmlinkage #define asmlinkage CPP_ASMLINKAGE #endif I read all of this that C++ code should be able to at least include kernel headers without fatal errors.  You don't agree? In that case all __cplusplus/asmlinkage should be removed? > > > > Also, this is not the correct way to submit patches for inclusion in the > > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > > for how to do this properly. > > > > Sorry, I was in a hurry(lazy:) so I just included stable directly as > > I know it needs to be fixed in 4.9 as well. > > But that's not how to get a patch into the stable tree :( > > sorry, Right, my mistake. No need to be sorry, I got what I deserved :) Jocke > > greg k-h