Re: Target name refactoring

[Andrew Jeffery <andrew@aj.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2835 bytes --]

On Thu, 2017-02-23 at 22:05 -0600, Andrew Geissler wrote:
> > On Tue, Feb 21, 2017 at 9:00 PM, Joel Stanley <joel@jms.id.au> wrote:
> > On Tue, Feb 21, 2017 at 8:50 AM, Andrew Geissler <geissonator@gmail.com> wrote:
> > > Some design decisions came out of my last set of changes in the
> > > OpenBMC state area.  There was a proposal to rename our targets
> > > responsible for booting and powering on/off the system.
> > > 
> > > Currently we have this:
> > > - PowerOn: obmc-power-chassis-on.target    obmc-chassis-start.target
> > > - PowerOff: obmc-power-chassis-off.target    obmc-chassis-stop.target
> > >   obmc-stop-host.target
> > > 
> > > The obmc-power-chassis-*.targets are responsible for doing whatever is
> > > required to apply pgood to the chassis.
> > > The obmc-chassis-*.targets are responsible for starting and stopping
> > > all host related services
> > > The obmc-stop-host.target is where we have the soft power off service
> > > (notify host of shutdown, wait for host to shutdown gracefully)
> > > 
> > > Refactoring Proposal:
> > > - First the chassis-start and chassis-stop target names don’t make
> > > sense anymore with the new bmc, chassis, and host state break down’s
> > > so:
> > >   - Rename obmc-chassis-start.target to obmc-start-host.target
> > >   - Rename obmc-chassis-stop.target to obmc-stop-host.target
> > >   - Rename the current obmc-stop-host.target to obmc-shutdown-host.target
> > 
> > Can I suggest putting the host before the action?
> > 
> > obmc-host-stop
> > obmc-host-start
> > obmc-host-shutdown
> > 
> 
> I believe Brad has a naming convention he's shooting for where the
> verb comes second.  I'm somewhat agnostic on this but we just want to
> be consistent.  With your proposal I'd probably have to rename the
> chassis one's from obmc-power-chassis-on to obmc-chassis-power-on.
> 
> Thoughts Brad?

Whatever the case, ack from me on your general proposal, so long as the
names are consistent.

Andrew

> 
> > > 
> > > The target relationships are then the following:
> > > 
> > > obmc-host-start.target requires obmc-power-chassis-on.target
> > > obmc-shutdown-host.target requires obmc-stop-host.target requires
> > > obmc-power-chassis-off.target
> > 
> > obmc-host-start requires obmc-chassis-poweron
> > 
> > obmc-host-shutdown requires obmc-host-stop requires obmc-chassis-poweroff
> > 
> > I think the rest of your proposal sounds good, from what I understand.
> > 
> > Cheers,
> > 
> > Joel
> > 
> > > 
> > > When a system goes to the quiesce target, the host state manager will
> > > call the obmc-stop-host.target.  Otherwise, the host state service
> > > will call the obmc-shutdown-host.target when power off is requested.
> > > 
> > > Thoughts/Comments?
> > > Andrew

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]