All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: eguan@redhat.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 2/4] xfs: minor fixes to the fsmap tests
Date: Fri, 24 Feb 2017 17:12:51 -0800	[thread overview]
Message-ID: <148798517171.25833.15263002232887612727.stgit@birch.djwong.org> (raw)
In-Reply-To: <148798515933.25833.2842247083803775089.stgit@birch.djwong.org>

From: Darrick J. Wong <darrick.wong@oracle.com>

Refactor the fsmap tests slightly to use new helpers, and
fix some minor output scanning issues.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/273 |    3 +--
 tests/xfs/275 |    4 +---
 tests/xfs/276 |    2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)


diff --git a/tests/xfs/273 b/tests/xfs/273
index 1a4ee93..f784a35 100755
--- a/tests/xfs/273
+++ b/tests/xfs/273
@@ -50,8 +50,7 @@ _require_xfs_io_command "fsmap"
 rm -f "$seqres.full"
 
 echo "Format and mount"
-_scratch_mkfs > "$seqres.full" 2>&1
-_scratch_populate >> $seqres.full
+_scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Compare fsmap" | tee -a $seqres.full
 _scratch_mount
diff --git a/tests/xfs/275 b/tests/xfs/275
index cc6d353..3ccfd77 100755
--- a/tests/xfs/275
+++ b/tests/xfs/275
@@ -42,11 +42,9 @@ _cleanup()
 # real QA test starts here
 _supported_os Linux
 _supported_fs xfs
+_require_logdev
 _require_scratch
 _require_xfs_io_command "fsmap"
-if [ "$USE_EXTERNAL" != "yes" ] || [ -z "$SCRATCH_LOGDEV" ]; then
-	_notrun "Need external log device"
-fi
 
 rm -f "$seqres.full"
 
diff --git a/tests/xfs/276 b/tests/xfs/276
index cea91c9..e39b5d5 100755
--- a/tests/xfs/276
+++ b/tests/xfs/276
@@ -77,7 +77,7 @@ done
 
 echo "Check device field of FS metadata and realtime file"
 data_dev=$(grep 'static fs metadata' $TEST_DIR/fsmap | head -n 1 | awk '{print $2}')
-rt_dev=$(grep "${ino}[[:space:]]*[0-9]*\.\.[0-9]*" $TEST_DIR/fsmap | head -n 1 | awk '{print $2}')
+rt_dev=$(grep "${ino}[[:space:]]*[0-9]*\.\.[0-9]*[[:space:]]*[0-9]*$" $TEST_DIR/fsmap | head -n 1 | awk '{print $2}')
 test "${data_dev}" != "${rt_dev}" || echo "data ${data_dev} realtime ${rt_dev}?"
 
 # success, all done


  parent reply	other threads:[~2017-02-25  1:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25  1:12 [PATCH 0/4] miscellaneous tests Darrick J. Wong
2017-02-25  1:12 ` [PATCH 1/4] xfs/348: classify this as a fuzzer test Darrick J. Wong
2017-02-28 14:05   ` Christoph Hellwig
2017-02-25  1:12 ` Darrick J. Wong [this message]
2017-02-25  1:12 ` [PATCH 3/4] reflink: test adjacency of reflinked blocks Darrick J. Wong
2017-02-28  8:15   ` Eryu Guan
2017-02-28 16:31     ` Darrick J. Wong
2017-03-01  3:20       ` Eryu Guan
2017-03-21  7:14   ` Qu Wenruo
2017-03-21  7:14     ` Qu Wenruo
2017-03-21 14:23     ` Darrick J. Wong
2017-03-21 14:23       ` Darrick J. Wong
2017-03-22  8:13       ` Qu Wenruo
2017-03-22  8:13         ` Qu Wenruo
2017-03-22 13:06         ` Darrick J. Wong
2017-03-22 13:06           ` Darrick J. Wong
2017-02-25  1:13 ` [PATCH 4/4] xfs: stress test xfs_scrub Darrick J. Wong
2017-02-28  8:46   ` Eryu Guan
2017-02-28 17:42     ` Darrick J. Wong
2017-02-28 20:57   ` [PATCH v2 " Darrick J. Wong
2017-03-01  3:33     ` Eryu Guan
2017-03-01  6:08       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148798517171.25833.15263002232887612727.stgit@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.