From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v4 5/7] xen: credit2: group the runq
 manipulating functions.
Date: Wed, 1 Mar 2017 18:12:08 +0100
Message-ID: <1488388328.5548.150.camel@citrix.com>
References: <148837861276.11900.8292677471375175885.stgit@Solace.fritz.box>
 <148837999639.11900.4722802322841206096.stgit@Solace.fritz.box>
 <e7f7403c-735b-f748-f897-1e4b4be8a877@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4493838362150029970=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta6.messagelabs.com ([193.109.254.103])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=226aaf366=dario.faggioli@citrix.com>)
 id 1cj7na-0005Lj-Vq
 for xen-devel@lists.xenproject.org; Wed, 01 Mar 2017 17:12:23 +0000
In-Reply-To: <e7f7403c-735b-f748-f897-1e4b4be8a877@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Anshul Makkar <anshul.makkar@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============4493838362150029970==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-9l3k6WhjWq8JCSDZlmwL"

--=-9l3k6WhjWq8JCSDZlmwL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2017-03-01 at 16:41 +0000, George Dunlap wrote:
> On 01/03/17 14:53, Dario Faggioli wrote:
> > @@ -590,7 +590,7 @@ static s_time_t c2t(struct
> > csched2_runqueue_data *rqd, s_time_t credit, struct c
> > =C2=A0}
> > =C2=A0
> > =C2=A0/*
> > - * Runqueue related code
> > + * Runqueue related code.
>=20
> You realize we changed CODING_STYLE to not require a full stop if
> there
> was only one line?=C2=A0=C2=A0This isn't a complete sentence so I would l=
eave
> the
> full stop out.
>=20
Now that you mention it, yes, I remember the thread. But my
understanding of the results of such thread was actually a bit
different from what you say and explain above.

So...

> But that's just for future reference -- I don't care enough about
> this
> in general, I just wanted to raise it to your attention.=C2=A0=C2=A0:-)
>=20
...that's been useful and much appreciated. Thanks!

Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-9l3k6WhjWq8JCSDZlmwL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJYtwDqAAoJEBZCeImluHPucY8QAOetkGftvvb1hcIYBoJ9v4mu
uYybrin11APVP4b5T8k1/SYFUiPplMD1urtsJhUHWh6UEAaYzBI5qGW06B9s/Pgq
zQVk4S3O0oTH2u+tN3AeUaCJT0F9lfYy6zxC59YTlMRkqoxma3kYHOLRJe4awgmX
FKHBIxXUrUWPSc+xpOnDBLKXg7ooOJ+COHNmLGih30UJgQ+0ZSB/Hd8gO/9zRbrG
flH1yRhYVjAHxqwsxD5ZsoaTgOafczVEJlj8CnJF9w/SbjuNs+H/bZpcNRT8vvpU
srqL+AQOQKXAoF26rJ2Q1x81fZJYji1Z/Kj0hVuC/HmDzPQr8kax6/Q5AnHtqF6R
mjYNKEgqWqq7Ra6iOaoLgc0JXcKNhB+3J1factX0SgXj4mqrgN4de+86euEL4tRc
UYgYUupyjtbnhbxLKpKmwXpD4Lt+/lk51JTBumbUpYACbAHiICH3oLYlsm2pFwoD
04Y8Qj0dE7k0OEJ37xXGZXBFVySusdY0uSO5QVwuuweovJwNdBWrGIgVrcNWxZ5s
5TbbujXzxd55JVvwOhw/ffaweqyt/r7xoXQY/g9HHXfDsJS4WHJT8QmWOUZpvDth
Cu6xRXCEAn8cfw9O2RWOvQXaS9li8PywcQXuTu+IcYZPdyndWbQHQasFbvRsKAlL
qMEhDIpTBAT6NDvKH93t
=QV9v
-----END PGP SIGNATURE-----

--=-9l3k6WhjWq8JCSDZlmwL--


--===============4493838362150029970==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============4493838362150029970==--