From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2 net] net: solve a NAPI race Date: Wed, 01 Mar 2017 09:32:39 -0800 Message-ID: <1488389559.9415.300.camel@edumazet-glaptop3.roam.corp.google.com> References: <1488032577.9415.131.camel@edumazet-glaptop3.roam.corp.google.com> <1488166294.9415.172.camel@edumazet-glaptop3.roam.corp.google.com> <1488205298.9415.180.camel@edumazet-glaptop3.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6DCFE727EB@AcuExch.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: David Laight , David Miller , netdev , Tariq Toukan , Saeed Mahameed To: Alexander Duyck Return-path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:35430 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdCARdB (ORCPT ); Wed, 1 Mar 2017 12:33:01 -0500 Received: by mail-pg0-f66.google.com with SMTP id 1so6509275pgz.2 for ; Wed, 01 Mar 2017 09:32:40 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2017-03-01 at 08:14 -0800, Alexander Duyck wrote: > What build flags are you using? With -Os or -O2 I have seen it > convert the /b * c into a single shift. > Because b & c are unsigned in our case. I presume David tried signed integers, this is why gcc does that.