From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linux-iscsi.org ([67.23.28.174]:59132 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753879AbdCBH4S (ORCPT ); Thu, 2 Mar 2017 02:56:18 -0500 Message-ID: <1488438120.21712.70.camel@haakon3.risingtidesystems.com> Subject: Re: [PATCH v6 14/33] target: Avoid that target drivers hang if a command is aborted From: "Nicholas A. Bellinger" To: Bart Van Assche Cc: "target-devel@vger.kernel.org" , "stable@vger.kernel.org" Date: Wed, 01 Mar 2017 23:02:00 -0800 In-Reply-To: <1488432232.3505.6.camel@sandisk.com> References: <20170215002612.14566-1-bart.vanassche@sandisk.com> <20170215002612.14566-15-bart.vanassche@sandisk.com> <1487626736.19491.37.camel@haakon3.risingtidesystems.com> <1D08B61A9CF0974AA09887BE32D889DA0AC669@ULS-OP-MBXIP03.sdcorp.global.sandisk.com> <1488432095.21712.8.camel@haakon3.risingtidesystems.com> <1488432232.3505.6.camel@sandisk.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2017-03-02 at 05:24 +0000, Bart Van Assche wrote: > On Wed, 2017-03-01 at 21:21 -0800, Nicholas A. Bellinger wrote: > > To reiterate the importance of having bug-fixes, especially those > > intended for stable, always be leading other patches.. > > You should know that I can't group all bugfixes at the start of the series > because some of the bugfixes depend on patches that are not bugfixes. > That makes no sense. Either it's a bug-fix to existing upstream code, or it's not. This patch was not a bug-fix to upstream, because it detailed a scenario that doesn't existing in upstream. That is, a case where ib_isert or ib_srpt calls target_generic_free_cmd() with wait_for_tasks = true or a case where wait_for_tasks = false blocks.