From: Li Qiang <liq3ea@gmail.com>
To: jsnow@redhat.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, ppandit@redhat.com, Li Qiang <liqiang6-s@360.cn>
Subject: [Qemu-devel] [PATCH 1/3] ide: qdev: register ide bus unrealize function
Date: Thu, 2 Mar 2017 02:08:11 -0800 [thread overview]
Message-ID: <1488449293-80280-2-git-send-email-liqiang6-s@360.cn> (raw)
In-Reply-To: <1488449293-80280-1-git-send-email-liqiang6-s@360.cn>
we have an idebus unrealize function, but it was being
registered as the unrealize function for the IDE Device,
so it was not getting invoked on device teardown because
nothing is "unrealizing" the IDE devices themselves.
Suggested-by: John Snow <jsnow@redhat.com>
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
---
hw/ide/qdev.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index dbaa75c..fbf7aa5 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -31,7 +31,7 @@
/* --------------------------------- */
static char *idebus_get_fw_dev_path(DeviceState *dev);
-static void idebus_unrealize(DeviceState *qdev, Error **errp);
+static void idebus_unrealize(BusState *qdev, Error **errp);
static Property ide_props[] = {
DEFINE_PROP_UINT32("unit", IDEDevice, unit, -1),
@@ -43,14 +43,15 @@ static void ide_bus_class_init(ObjectClass *klass, void *data)
BusClass *k = BUS_CLASS(klass);
k->get_fw_dev_path = idebus_get_fw_dev_path;
+ k->unrealize = idebus_unrealize;
}
-static void idebus_unrealize(DeviceState *qdev, Error **errp)
+static void idebus_unrealize(BusState *bus, Error **errp)
{
- IDEBus *bus = DO_UPCAST(IDEBus, qbus, qdev->parent_bus);
+ IDEBus *ibus = IDE_BUS(bus);
- if (bus->vmstate) {
- qemu_del_vm_change_state_handler(bus->vmstate);
+ if (ibus->vmstate) {
+ qemu_del_vm_change_state_handler(ibus->vmstate);
}
}
@@ -365,7 +366,6 @@ static void ide_device_class_init(ObjectClass *klass, void *data)
k->init = ide_qdev_init;
set_bit(DEVICE_CATEGORY_STORAGE, k->categories);
k->bus_type = TYPE_IDE_BUS;
- k->unrealize = idebus_unrealize;
k->props = ide_props;
}
--
1.8.3.1
next prev parent reply other threads:[~2017-03-02 10:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 10:08 [Qemu-devel] [PATCH 0/3] ide: ahci: fix memory leak in device unit Li Qiang
2017-03-02 10:08 ` Li Qiang [this message]
2017-03-02 23:46 ` [Qemu-devel] [PATCH 1/3] ide: qdev: register ide bus unrealize function Philippe Mathieu-Daudé
2017-03-02 10:08 ` [Qemu-devel] [PATCH 2/3] ide: core: add cleanup function Li Qiang
2017-03-02 10:08 ` [Qemu-devel] [PATCH 3/3] ide: ahci: call cleanup function in ahci unit Li Qiang
2017-03-03 22:48 ` [Qemu-devel] [PATCH 0/3] ide: ahci: fix memory leak in device unit John Snow
2017-03-14 2:41 ` Li Qiang
2017-03-14 19:03 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488449293-80280-2-git-send-email-liqiang6-s@360.cn \
--to=liq3ea@gmail.com \
--cc=jsnow@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=pbonzini@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.