From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Date: Thu, 2 Mar 2017 17:35:52 +0000 Message-ID: <1488476152.2684.10.camel@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: Jose Abreu Cc: "devicetree@vger.kernel.org" , Vineet Gupta , Carlos Palminha , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "linux-snps-arc@lists.infradead.org" List-Id: devicetree@vger.kernel.org SGkgSm9zZSwNCg0KT24gV2VkLCAyMDE3LTAyLTIyIGF0IDE4OjE5ICswMDAwLCBKb3NlIEFicmV1 IHdyb3RlOg0KPiBEZWZhdWx0IGNsb2NrIGZyZXF1ZW5jeSBmb3IgQVJDIFBHVSBkb2VzIG5vdCBt YXRjaCBhbnkNCj4gZXhpc3RpbmcgSERNSSBtb2RlLCBpbnN0ZWFkIHRoZSBkZWZhdWx0IHZhbHVl IG1hdGNoZXMgYQ0KPiBEVkkgbW9kZS4gQ2hhbmdlIHRoZSBjbG9jayBmcmVxdWVuY3kgdG8gNzQu MjVNSHogc28gdGhhdA0KPiBpdCBtYXRjaGVzIEhETUkgbW9kZSAxMjgweDcyMEA2MEh6DQo+IA0K PiBTaWduZWQtb2ZmLWJ5OiBKb3NlIEFicmV1IDxqb2FicmV1QHN5bm9wc3lzLmNvbT4NCj4gQ2M6 IENhcmxvcyBQYWxtaW5oYSA8cGFsbWluaGFAc3lub3BzeXMuY29tPg0KPiBDYzogQWxleGV5IEJy b2RraW4gPGFicm9ka2luQHN5bm9wc3lzLmNvbT4NCj4gQ2M6IFJvYiBIZXJyaW5nIDxyb2JoK2R0 QGtlcm5lbC5vcmc+DQo+IENjOiBWaW5lZXQgR3VwdGEgPHZndXB0YUBzeW5vcHN5cy5jb20+DQo+ IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZw0KPiBDYzogbGludXgtc25wcy1hcmNAbGlz dHMuaW5mcmFkZWFkLm9yZw0KPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZw0KPiAt LS0NCj4gwqBhcmNoL2FyYy9ib290L2R0cy9heHMxMHhfbWIuZHRzaSB8IDIgKy0NCj4gwqAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1n aXQgYS9hcmNoL2FyYy9ib290L2R0cy9heHMxMHhfbWIuZHRzaSBiL2FyY2gvYXJjL2Jvb3QvZHRz L2F4czEweF9tYi5kdHNpDQo+IGluZGV4IDlkODgyYjEuLjQxY2ZiMjkgMTAwNjQ0DQo+IC0tLSBh L2FyY2gvYXJjL2Jvb3QvZHRzL2F4czEweF9tYi5kdHNpDQo+ICsrKyBiL2FyY2gvYXJjL2Jvb3Qv ZHRzL2F4czEweF9tYi5kdHNpDQo+IEBAIC01MSw3ICs1MSw3IEBADQo+IMKgCQkJcGd1Y2xrOiBw Z3VjbGsgew0KPiDCoAkJCQkjY2xvY2stY2VsbHMgPSA8MD47DQo+IMKgCQkJCWNvbXBhdGlibGUg PSAiZml4ZWQtY2xvY2siOw0KPiAtCQkJCWNsb2NrLWZyZXF1ZW5jeSA9IDw3NDQ0MDAwMD47DQo+ ICsJCQkJY2xvY2stZnJlcXVlbmN5ID0gPDc0MjUwMDAwPjsNCj4gwqAJCQl9Ow0KPiDCoAkJfTsN Cg0KTG9va3MgZ29vZCB0byBtZSBidXQgSSBoYXZlIHRvIG5vdGUgdGhhdCB3aXRoIHRoaXMgY2hh bmdlIGluIHBsYWNlDQptb25pdG9ycyB0aGF0IGRvbid0IHJlcG9ydCBbY29ycmVjdF0gRURJRCB3 b24ndCB3b3JrIGp1c3QgYmVjYXVzZQ0KaWYgRURJRCBpcyBtaXNzaW5nIExpbnV4IGtlcm5lbCBj YWxjdWxhdGVzIHBpeGVsIGNsb2NrIG9uIGl0cw0Kb3duIGFuZCBmb3IgMTI4MHg3MjBANjDCoGl0 IGdldHMgNzQuNDAgTUh6IHdoaWNoIG9idmlvdXNseSBkaWZmZXJzIGZyb20NCnlvdXJzIDc0LjI1 IE1IeiBhbmQgc2/CoGFyY19wZ3VfY3J0Y19hdG9taWNfY2hlY2soKSByZXR1cm5zwqAtRUlOVkFM Lg0KDQpCdXQgd2l0aCB0aGUgZml4IEkganVzdCBzZW50LCBzZWUNCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL3BpcGVybWFpbC9saW51eC1zbnBzLWFyYy8yMDE3LU1hcmNoLzAwMjE3My5odG1s DQpldmVyeXRoaW5nIHdpbGwgd29yayBhZ2Fpbi4NCg0KQW5kIG9uY2UgVmxhZCdzIHBhdGNoIGZv ciBBWFMgUExMcyBnZXRzIGFjY2VwdGVkIHdlJ2xsIGZpbmFsbHkgZ2V0DQpzdXBwb3J0IG9mIG11 bHRpcGxlIG1vZGVzIG9uIEFYUzEweCBib2FyZHMuDQoNClRoYXQgc2FpZC4uLg0KDQpBY2tlZC1i eTogQWxleGV5IEJyb2RraW4gPGFicm9ka2luQHN5bm9wc3lzLmNvbT4KX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtc25wcy1hcmMgbWFpbGluZyBs aXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1zbnBzLWFyYw== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbdCBRjA (ORCPT ); Thu, 2 Mar 2017 12:39:00 -0500 Received: from smtprelay.synopsys.com ([198.182.60.111]:47670 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751995AbdCBRi5 (ORCPT ); Thu, 2 Mar 2017 12:38:57 -0500 From: Alexey Brodkin To: Jose Abreu CC: Carlos Palminha , "linux-kernel@vger.kernel.org" , Vineet Gupta , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Thread-Topic: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency Thread-Index: AQHSjThIHRXwbSLeikW9D7Gx9mLbl6GBy6wA Date: Thu, 2 Mar 2017 17:35:52 +0000 Message-ID: <1488476152.2684.10.camel@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> In-Reply-To: <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.102] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v22Hd3V9018917 Hi Jose, On Wed, 2017-02-22 at 18:19 +0000, Jose Abreu wrote: > Default clock frequency for ARC PGU does not match any > existing HDMI mode, instead the default value matches a > DVI mode. Change the clock frequency to 74.25MHz so that > it matches HDMI mode 1280x720@60Hz > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Rob Herring > Cc: Vineet Gupta > Cc: devicetree@vger.kernel.org > Cc: linux-snps-arc@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- >  arch/arc/boot/dts/axs10x_mb.dtsi | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index 9d882b1..41cfb29 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -51,7 +51,7 @@ >   pguclk: pguclk { >   #clock-cells = <0>; >   compatible = "fixed-clock"; > - clock-frequency = <74440000>; > + clock-frequency = <74250000>; >   }; >   }; Looks good to me but I have to note that with this change in place monitors that don't report [correct] EDID won't work just because if EDID is missing Linux kernel calculates pixel clock on its own and for 1280x720@60 it gets 74.40 MHz which obviously differs from yours 74.25 MHz and so arc_pgu_crtc_atomic_check() returns -EINVAL. But with the fix I just sent, see http://lists.infradead.org/pipermail/linux-snps-arc/2017-March/002173.html everything will work again. And once Vlad's patch for AXS PLLs gets accepted we'll finally get support of multiple modes on AXS10x boards. That said... Acked-by: Alexey Brodkin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Thu, 2 Mar 2017 17:35:52 +0000 Subject: [PATCH 2/2] arc: axs10x: Fix ARC PGU default clock frequency In-Reply-To: <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> References: <7ed6deaf1ae6d5819364c793835aa30316077a7e.1487787376.git.joabreu@synopsys.com> <16273b3a26ec770f8d169f04f7cb9eb2fac55909.1487787376.git.joabreu@synopsys.com> List-ID: Message-ID: <1488476152.2684.10.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Jose, On Wed, 2017-02-22@18:19 +0000, Jose Abreu wrote: > Default clock frequency for ARC PGU does not match any > existing HDMI mode, instead the default value matches a > DVI mode. Change the clock frequency to 74.25MHz so that > it matches HDMI mode 1280x720 at 60Hz > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Alexey Brodkin > Cc: Rob Herring > Cc: Vineet Gupta > Cc: devicetree at vger.kernel.org > Cc: linux-snps-arc at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > --- > ?arch/arc/boot/dts/axs10x_mb.dtsi | 2 +- > ?1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi > index 9d882b1..41cfb29 100644 > --- a/arch/arc/boot/dts/axs10x_mb.dtsi > +++ b/arch/arc/boot/dts/axs10x_mb.dtsi > @@ -51,7 +51,7 @@ > ? pguclk: pguclk { > ? #clock-cells = <0>; > ? compatible = "fixed-clock"; > - clock-frequency = <74440000>; > + clock-frequency = <74250000>; > ? }; > ? }; Looks good to me but I have to note that with this change in place monitors that don't report [correct] EDID won't work just because if EDID is missing Linux kernel calculates pixel clock on its own and for 1280x720 at 60?it gets 74.40 MHz which obviously differs from yours 74.25 MHz and so?arc_pgu_crtc_atomic_check() returns?-EINVAL. But with the fix I just sent, see http://lists.infradead.org/pipermail/linux-snps-arc/2017-March/002173.html everything will work again. And once Vlad's patch for AXS PLLs gets accepted we'll finally get support of multiple modes on AXS10x boards. That said... Acked-by: Alexey Brodkin