All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel J Blueman <daniel@quora.org>
Cc: Netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	Stephen Hemminger <shemminger@linux-foundation.org>
Subject: Re: [4.9.13] use after free in ipv4_mtu
Date: Mon, 06 Mar 2017 08:20:03 -0800	[thread overview]
Message-ID: <1488817203.9415.382.camel@edumazet-glaptop3.roam.corp.google.com> (raw)
In-Reply-To: <1488807904.9415.375.camel@edumazet-glaptop3.roam.corp.google.com>

On Mon, 2017-03-06 at 05:45 -0800, Eric Dumazet wrote:
> On Mon, 2017-03-06 at 14:33 +0800, Daniel J Blueman wrote:

> > I do change the network queueing discipline and related at runtime [1]
> > which may be triggering this, though I did think I saw the KASAN
> > report only after resuming from suspend. rf(un)kill and other tweaking
> > may have been involved too.
> > 
> > Thanks,
> >   Dan
> > 
> > [1] /etc/sysctl.d/90-tcp.conf
> > 
> > net.core.default_qdisc = fq_codel
> > net.ipv4.tcp_congestion_control = bbr
> > net.ipv4.tcp_slow_start_after_idle = 0
> > net.ipv4.tcp_ecn = 1

BTW, fq_codel is not suitable for BBR.

Only fq contains the needed pacing for BBR.

  reply	other threads:[~2017-03-06 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-02 12:42 [4.9.13] use after free in ipv4_mtu Daniel J Blueman
2017-03-02 13:08 ` Eric Dumazet
2017-03-02 13:28   ` Eric Dumazet
2017-03-06  6:33     ` Daniel J Blueman
2017-03-06 13:45       ` Eric Dumazet
2017-03-06 16:20         ` Eric Dumazet [this message]
2017-03-07 12:29           ` Daniel J Blueman
2017-03-07 16:29           ` Stephen Hemminger
2017-03-07 16:56             ` Eric Dumazet
2017-05-04  1:30         ` Daniel J Blueman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488817203.9415.382.camel@edumazet-glaptop3.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=daniel@quora.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.