From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:32980 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726470AbeGLDnc (ORCPT ); Wed, 11 Jul 2018 23:43:32 -0400 Subject: Re: [PATCH] f2fs: fix defined but not used build warnings To: Chao Yu , Linux FS Devel , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim References: <4463b606-3373-2e51-ad8c-3303b1ccc587@infradead.org> From: Randy Dunlap Message-ID: <14890abc-8ba5-5029-8043-6e27fd4c2b37@infradead.org> Date: Wed, 11 Jul 2018 20:35:57 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 07/09/2018 06:09 PM, Chao Yu wrote: > On 2018/7/7 11:50, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled >> by marking the unused functions as __maybe_unused. >> >> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function] >> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function] >> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function] >> >> Signed-off-by: Randy Dunlap >> Cc: Jaegeuk Kim >> Cc: Chao Yu >> Cc: linux-f2fs-devel@lists.sourceforge.net > > Reviewed-by: Chao Yu Hi, Who would you like to merge this patch? or could you do so? thanks, -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: [PATCH] f2fs: fix defined but not used build warnings Date: Wed, 11 Jul 2018 20:35:57 -0700 Message-ID: <14890abc-8ba5-5029-8043-6e27fd4c2b37@infradead.org> References: <4463b606-3373-2e51-ad8c-3303b1ccc587@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1fdSOs-0003Fo-DN for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Jul 2018 03:36:14 +0000 Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1fdSOq-001HUe-E1 for linux-f2fs-devel@lists.sourceforge.net; Thu, 12 Jul 2018 03:36:14 +0000 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Chao Yu , Linux FS Devel , linux-f2fs-devel@lists.sourceforge.net, Jaegeuk Kim On 07/09/2018 06:09 PM, Chao Yu wrote: > On 2018/7/7 11:50, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build warnings in f2fs when CONFIG_PROC_FS is not enabled >> by marking the unused functions as __maybe_unused. >> >> ../fs/f2fs/sysfs.c:519:12: warning: 'segment_info_seq_show' defined but not used [-Wunused-function] >> ../fs/f2fs/sysfs.c:546:12: warning: 'segment_bits_seq_show' defined but not used [-Wunused-function] >> ../fs/f2fs/sysfs.c:570:12: warning: 'iostat_info_seq_show' defined but not used [-Wunused-function] >> >> Signed-off-by: Randy Dunlap >> Cc: Jaegeuk Kim >> Cc: Chao Yu >> Cc: linux-f2fs-devel@lists.sourceforge.net > > Reviewed-by: Chao Yu Hi, Who would you like to merge this patch? or could you do so? thanks, -- ~Randy ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot