All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
	Alex Lemberg <alex.lemberg@sandisk.com>,
	Mateusz Nowak <mateusz.nowak@intel.com>,
	Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Dong Aisheng <dongas86@gmail.com>,
	Das Asutosh <asutoshd@codeaurora.org>,
	Zhangfei Gao <zhangfei.gao@gmail.com>,
	Dorfman Konstantin <kdorfman@codeaurora.org>,
	David Griego <david.griego@linaro.org>,
	Sahitya Tummala <stummala@codeaurora.org>,
	Harjani Ritesh <riteshh@codeaurora.org>,
	Venu Byravarasu <vbyravarasu@nvidia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH V2 20/22] mmc: block: Prepare CQE data
Date: Mon, 13 Mar 2017 14:36:51 +0200	[thread overview]
Message-ID: <1489408613-26915-21-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1489408613-26915-1-git-send-email-adrian.hunter@intel.com>

Enhance mmc_blk_data_prep() to support CQE requests.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/core/block.c | 45 ++++++++++++++++++++++++++++++++++-----------
 1 file changed, 34 insertions(+), 11 deletions(-)

diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 15a6705a81fe..105b87aa8ffc 100644
--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -36,6 +36,7 @@
 #include <linux/compat.h>
 #include <linux/pm_runtime.h>
 #include <linux/idr.h>
+#include <linux/ioprio.h>
 
 #include <linux/mmc/ioctl.h>
 #include <linux/mmc/card.h>
@@ -1434,25 +1435,27 @@ static enum mmc_blk_status mmc_blk_err_check(struct mmc_card *card,
 }
 
 static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
-			      int disable_multi, bool *do_rel_wr,
-			      bool *do_data_tag)
+			      int disable_multi, bool *do_rel_wr_p,
+			      bool *do_data_tag_p)
 {
 	struct mmc_blk_data *md = mq->blkdata;
 	struct mmc_card *card = md->queue.card;
 	struct mmc_blk_request *brq = &mqrq->brq;
 	struct request *req = mqrq->req;
+	bool do_rel_wr, do_data_tag;
 
 	/*
 	 * Reliable writes are used to implement Forced Unit Access and
 	 * are supported only on MMCs.
 	 */
-	*do_rel_wr = (req->cmd_flags & REQ_FUA) &&
-		     rq_data_dir(req) == WRITE &&
-		     (md->flags & MMC_BLK_REL_WR);
+	do_rel_wr = (req->cmd_flags & REQ_FUA) &&
+		    rq_data_dir(req) == WRITE &&
+		    (md->flags & MMC_BLK_REL_WR);
 
 	memset(brq, 0, sizeof(struct mmc_blk_request));
 
 	brq->mrq.data = &brq->data;
+	brq->mrq.tag = req->tag;
 
 	brq->stop.opcode = MMC_STOP_TRANSMISSION;
 	brq->stop.arg = 0;
@@ -1467,6 +1470,15 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
 
 	brq->data.blksz = 512;
 	brq->data.blocks = blk_rq_sectors(req);
+	brq->data.blk_addr = blk_rq_pos(req);
+
+	/*
+	 * The command queue supports 2 priorities: "high" (1) and "simple" (0).
+	 * The eMMC will give "high" priority tasks priority over "simple"
+	 * priority tasks. Here we give priority to IOPRIO_CLASS_RT.
+	 */
+	if (IOPRIO_PRIO_CLASS(req_get_ioprio(req)) == IOPRIO_CLASS_RT)
+		brq->data.flags |= MMC_DATA_PRIO;
 
 	/*
 	 * The block layer doesn't support all sector count
@@ -1496,18 +1508,23 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
 						brq->data.blocks);
 	}
 
-	if (*do_rel_wr)
+	if (do_rel_wr) {
 		mmc_apply_rel_rw(brq, card, req);
+		brq->data.flags |= MMC_DATA_REL_WR;
+	}
 
 	/*
 	 * Data tag is used only during writing meta data to speed
 	 * up write and any subsequent read of this meta data
 	 */
-	*do_data_tag = card->ext_csd.data_tag_unit_size &&
-		       (req->cmd_flags & REQ_META) &&
-		       (rq_data_dir(req) == WRITE) &&
-		       ((brq->data.blocks * brq->data.blksz) >=
-			card->ext_csd.data_tag_unit_size);
+	do_data_tag = card->ext_csd.data_tag_unit_size &&
+		      (req->cmd_flags & REQ_META) &&
+		      (rq_data_dir(req) == WRITE) &&
+		      ((brq->data.blocks * brq->data.blksz) >=
+		       card->ext_csd.data_tag_unit_size);
+
+	if (do_data_tag)
+		brq->data.flags |= MMC_DATA_DAT_TAG;
 
 	mmc_set_data_timeout(&brq->data, card);
 
@@ -1536,6 +1553,12 @@ static void mmc_blk_data_prep(struct mmc_queue *mq, struct mmc_queue_req *mqrq,
 	mqrq->areq.mrq = &brq->mrq;
 
 	mmc_queue_bounce_pre(mqrq);
+
+	if (do_rel_wr_p)
+		*do_rel_wr_p = do_rel_wr;
+
+	if (do_data_tag_p)
+		*do_data_tag_p = do_data_tag;
 }
 
 static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,
-- 
1.9.1


  parent reply	other threads:[~2017-03-13 12:44 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-13 12:36 [PATCH V2 00/22] mmc: Add Command Queue support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 01/22] mmc: block: Fix is_waiting_last_req set incorrectly Adrian Hunter
2017-03-14 16:22   ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 02/22] mmc: block: Fix cmd error reset failure path Adrian Hunter
2017-03-14 16:22   ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 03/22] mmc: block: Use local var for mqrq_cur Adrian Hunter
2017-04-08 17:37   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 04/22] mmc: block: Introduce queue semantics Adrian Hunter
2017-04-08 17:40   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 05/22] mmc: queue: Share mmc request array between partitions Adrian Hunter
2017-04-08 17:41   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 06/22] mmc: mmc: Add functions to enable / disable the Command Queue Adrian Hunter
2017-04-08 17:39   ` Linus Walleij
2017-04-10 11:01   ` Ulf Hansson
2017-04-10 11:11     ` Adrian Hunter
2017-04-10 13:02       ` Ulf Hansson
2017-03-13 12:36 ` [PATCH V2 07/22] mmc: mmc_test: Disable Command Queue while mmc_test is used Adrian Hunter
2017-04-08 17:43   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 08/22] mmc: block: Disable Command Queue while RPMB " Adrian Hunter
2017-04-08 17:44   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 09/22] mmc: block: Change mmc_apply_rel_rw() to get block address from the request Adrian Hunter
2017-04-10 13:49   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 10/22] mmc: block: Factor out data preparation Adrian Hunter
2017-04-10 13:52   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 11/22] mmc: core: Factor out debug prints from mmc_start_request() Adrian Hunter
2017-04-10 13:53   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 12/22] mmc: core: Factor out mrq preparation " Adrian Hunter
2017-04-10 13:54   ` Linus Walleij
2017-03-13 12:36 ` [PATCH V2 13/22] mmc: core: Add mmc_retune_hold_now() Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 14/22] mmc: core: Add members to mmc_request and mmc_data for CQE's Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 15/22] mmc: host: Add CQE interface Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 16/22] mmc: core: Turn off CQE before sending commands Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 17/22] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 18/22] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 19/22] mmc: mmc: Enable CQE's Adrian Hunter
2017-03-13 12:36 ` Adrian Hunter [this message]
2017-03-13 12:36 ` [PATCH V2 21/22] mmc: block: Add CQE support Adrian Hunter
2017-03-13 12:36 ` [PATCH V2 22/22] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-04-08 17:37 ` [PATCH V2 00/22] mmc: Add Command Queue support Linus Walleij
2017-04-10 13:53 ` Ulf Hansson
2017-04-22  7:45   ` Adrian Hunter
2017-04-24  8:12     ` Linus Walleij
2017-04-24  9:14       ` Bough Chen
2017-06-15 11:38         ` Adrian Hunter
2017-06-15 11:49           ` Bough Chen
2017-06-20  8:01             ` Bough Chen
2017-06-20  9:04               ` Adrian Hunter
2017-07-04 10:21                 ` Bough Chen
2017-07-06 10:48                   ` Adrian Hunter
2017-04-25 13:28       ` Paolo Valente

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489408613-26915-21-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Yuliy.Izrailov@sandisk.com \
    --cc=alex.lemberg@sandisk.com \
    --cc=asutoshd@codeaurora.org \
    --cc=david.griego@linaro.org \
    --cc=dongas86@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=kdorfman@codeaurora.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=mateusz.nowak@intel.com \
    --cc=riteshh@codeaurora.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=stummala@codeaurora.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vbyravarasu@nvidia.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.