From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Tobin C. Harding" Subject: [PATCH 10/12] staging: ks7010: fix checkpatch memset warning Date: Tue, 14 Mar 2017 09:54:08 +1100 Message-Id: <1489445650-11398-11-git-send-email-me@tobin.cc> In-Reply-To: <1489445650-11398-1-git-send-email-me@tobin.cc> References: <1489445650-11398-1-git-send-email-me@tobin.cc> List-ID: To: Greg Kroah-Hartman Cc: "Tobin C. Harding" , Wolfram Sang , driverdev-devel@linuxdriverproject.org Checkpatch emits WARNING: single byte memset is suspicious. Swapped 2nd/3rd argument? Call site in question is correct but is an unusual use of memset() to zero a single byte. The same can be achieved by assigning 0 directly to the memory location. Dereference pointer and assign 0 to that memory location. Use '\0' to make explicit that it is a char pointer. Signed-off-by: Tobin C. Harding --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index e1e4a31..bb20bb9 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -2595,7 +2595,7 @@ static int ks_wlan_data_read(struct net_device *dev, return 0; } read_length = 0; - memset(extra, 0, 1); + *extra = '\0'; dwrq->length = 0; return 0; } -- 2.7.4