From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754345AbdCPWUI (ORCPT ); Thu, 16 Mar 2017 18:20:08 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34881 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754084AbdCPWUF (ORCPT ); Thu, 16 Mar 2017 18:20:05 -0400 From: sunil.m@techveda.org To: gregkh@linuxfoundation.org, dan.carpenter@oracle.com Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, karthiknishu@yahoo.com, Suniel Mahesh Subject: [PATCH v4 0/6] staging: rtl8192e: Fix coding style, warnings and checks Date: Fri, 17 Mar 2017 03:42:15 +0530 Message-Id: <1489702341-14448-1-git-send-email-sunil.m@techveda.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20170316023641.GA6084@kroah.com> References: <20170316023641.GA6084@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suniel Mahesh Split earlier patches into multiple commits for easy review as suggested by Dan Carpenter. Modified subject, description and in few patches both for better readability as suggested by Greg KH. Dropped two patches from the earler series, as they were not adding significant value, suggested by Dan Carpenter. Fixed the following issues reported by checkpatch.pl: Block comments should align the * on each line, aligned. Block comments use * on subsequent lines, other characters are replaced by * . Removed unnecessary 'out of memory' message. Comparison's to NULL could be written '!foo' or 'foo', modified. Replaced sizeof(struct foo) into sizeof(*ptr). Spaces preferred around that 'operator', spacing provided. Logical continuations should be on the previous line, modified accordingly. Unnecessary parentheses around variables, removed. Please use a blank line after function/struct/union/enum declarations, used. Blank lines aren't necessary after an open brace '{' and before a close brace '}', removed. No space is necessary after a cast, removed. Please don't use multiple blank lines, removed. Rebased on top of next-20170310. Patches were tested and built on next-20170310 and staging-testing as suggested by Greg K-H, no errors reported. Suniel Mahesh (6): staging: rtl8192e: Fix comments as per kernel coding style staging: rtl8192e: Remove unnecessary 'out of memory' message staging: rtl8192e: Rectify pointer comparisions with NULL staging: rtl8192e: Pass a pointer as an argument to sizeof() instead of struct staging: rtl8192e: Fix issues reported by checkpatch.pl staging: rtl8192e: Fix blank lines and space after a cast drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 141 ++++++++++----------------- 1 file changed, 50 insertions(+), 91 deletions(-) -- 1.9.1