From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 04/15] power: supply: bq24190_charger: Add no_register_reset pdata flag Date: Fri, 17 Mar 2017 19:20:19 +0200 Message-ID: <1489771219.19767.71.camel@linux.intel.com> References: <20170317095527.10487-1-hdegoede@redhat.com> <20170317095527.10487-5-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170317095527.10487-5-hdegoede@redhat.com> Sender: linux-pm-owner@vger.kernel.org To: Hans de Goede , "Rafael J . Wysocki" , Len Brown , Wolfram Sang , Lee Jones , Sebastian Reichel , MyungJoo Ham , Chanwoo Choi Cc: linux-acpi@vger.kernel.org, Takashi Iwai , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On Fri, 2017-03-17 at 10:55 +0100, Hans de Goede wrote: > On some platforms the register have been setup with platform specific > values by the firmware and should not be reset. > I would not extend platform data at all. For GPIO we may use GPIO lookup tables, for the rest -- unified (built- in) device properties API. Consider to get rid of  include/linux/power/bq24190_charger.h completely. -- Andy Shevchenko Intel Finland Oy