All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Patel, Vedang" <vedang.patel@intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libxslt: Add PACKAGECONFIG support
Date: Wed, 22 Mar 2017 22:16:16 +0000	[thread overview]
Message-ID: <1490220976.15509.34.camel@intel.com> (raw)
In-Reply-To: <CAJTo0LZd1JgF+Zz_-yS5p-HeA1jxrmbxg-G9oP1maVO3rfzfVA@mail.gmail.com>

Hi Ross,

On Wed, 2017-03-22 at 20:19 +0000, Burton, Ross wrote:
> 
> On 22 March 2017 at 20:17, Patel, Vedang <vedang.patel@intel.com>
> wrote:
> > Can you elabore on your concern? I am not exactly following it.
> > 
> > the configs won't be enabled unless the corresponding features are
> > explicitly enabled in the image. I am using libxslt- prefix to make
> > sure someone does not inadvertently enables the features by using
> > the generic flags (python, debug, ... ). 
> > 
> No, you're changing the default to enable all the things that were
> previously disabled.
> 
> Also you don't need to prefix the names as they're recipe-specific
> already.
> 
> I suggest that you re-read the PACKAGECONFIG section in the manual
> and resubmit the patch.

I got my mistake. Setting PACKAGECONFIG enabled all the features by
default. Also, should I be including python as runtime dependency when
--with-python is used?

Thanks,
Vedang Patel
Software Engineer
Intel Corporation
> 
> Ross

  reply	other threads:[~2017-03-22 22:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21  0:31 [PATCH] libxslt: Add PACKAGECONFIG support Vedang Patel
2017-03-21  8:36 ` Jussi Kukkonen
2017-03-22 20:17   ` Patel, Vedang
2017-03-22 20:19     ` Burton, Ross
2017-03-22 22:16       ` Patel, Vedang [this message]
2017-03-22 22:18         ` Burton, Ross
2017-03-22 23:33           ` Patel, Vedang
2017-03-23  1:05             ` [PATCH v2] libxslt: Add PACKAGECONFIG support for python Vedang Patel
2017-03-23 19:55               ` Randy Witt
2017-03-23 21:56                 ` Patel, Vedang
2017-03-24  0:00                   ` [PATCH] " Vedang Patel
2017-03-24  1:39                     ` Andre McCurdy
2017-03-29  0:29                       ` Patel, Vedang
2017-03-23  7:37     ` [PATCH] libxslt: Add PACKAGECONFIG support Jussi Kukkonen
2017-03-23  7:41       ` Jussi Kukkonen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490220976.15509.34.camel@intel.com \
    --to=vedang.patel@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.