From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [dim PATCH 6/7] dim: make dim apply-branch subcommand return exit codes
Date: Thu, 23 Mar 2017 12:06:21 +0200 [thread overview]
Message-ID: <1490263582-6808-6-git-send-email-jani.nikula@intel.com> (raw)
In-Reply-To: <1490263582-6808-1-git-send-email-jani.nikula@intel.com>
For example, piping from emacs only pops up the stdout/stderr buffer
when the exit code is non-zero.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
dim | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/dim b/dim
index e23617c8907c..7b6275e7796f 100755
--- a/dim
+++ b/dim
@@ -667,7 +667,7 @@ dim_alias_ab=apply-branch
dim_alias_sob=apply-branch
function dim_apply_branch
{
- local branch file message_id commiter_email patch_from sob
+ local branch file message_id commiter_email patch_from sob rv
branch=$1
shift
@@ -694,13 +694,18 @@ function dim_apply_branch
if [ -n "$message_id" ]; then
dim_commit_add_tag "Link: http://patchwork.freedesktop.org/patch/msgid/$message_id"
else
- echo "No message-id found in the patch file."
+ echoerr "WARNING: No message-id found in the patch file."
+ rv=1
fi
- checkpatch_commit HEAD || true
+ if ! checkpatch_commit HEAD; then
+ rv=1
+ fi
check_maintainer $branch HEAD
eval $DRY $DIM_POST_APPLY_ACTION
+
+ return $rv
}
function dim_add_link
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-03-23 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 10:06 [dim PATCH 1/7] dim: don't fail on grep not matching Jani Nikula
2017-03-23 10:06 ` [dim PATCH 2/7] dim: abstract and fix maintainer scope check for dinq Jani Nikula
2017-03-23 10:06 ` [dim PATCH 3/7] dim: only issue warnings on new BUG macros Jani Nikula
2017-03-23 10:06 ` [dim PATCH 4/7] dim: return exit code from checkpatch_commit Jani Nikula
2017-03-23 10:06 ` [dim PATCH 5/7] dim: make dim checkpatch subcommand return exit codes Jani Nikula
2017-03-23 10:06 ` Jani Nikula [this message]
2017-03-23 10:06 ` [dim PATCH 7/7] dim: propagate errors from check_maintainer Jani Nikula
2017-03-23 14:33 ` Daniel Vetter
2017-03-23 14:31 ` [dim PATCH 1/7] dim: don't fail on grep not matching Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490263582-6808-6-git-send-email-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.