* [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments
@ 2017-03-24 14:28 sochin.jiang
2017-03-24 15:47 ` Marc-André Lureau
2017-04-23 9:15 ` Michael Tokarev
0 siblings, 2 replies; 3+ messages in thread
From: sochin.jiang @ 2017-03-24 14:28 UTC (permalink / raw)
To: berrange; +Cc: sochin, sochin.jiang, qemu-devel
From: "sochin.jiang" <sochin@aliyun.com>
fix wrong parameter comments in channel-file.h.
Signed-off-by: sochin.jiang <sochin@aliyun.com>
---
include/io/channel-file.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/io/channel-file.h b/include/io/channel-file.h
index d2462c2..79245f1 100644
--- a/include/io/channel-file.h
+++ b/include/io/channel-file.h
@@ -71,7 +71,7 @@ qio_channel_file_new_fd(int fd);
/**
* qio_channel_file_new_path:
- * @fd: the file descriptor
+ * @path: the file path
* @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc)
* @mode: the file creation mode if O_WRONLY is set in @flags
* @errp: pointer to initialized error object
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments
2017-03-24 14:28 [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments sochin.jiang
@ 2017-03-24 15:47 ` Marc-André Lureau
2017-04-23 9:15 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Marc-André Lureau @ 2017-03-24 15:47 UTC (permalink / raw)
To: sochin.jiang, berrange; +Cc: QEMU, sochin.jiang, qemu trival
On Fri, Mar 24, 2017 at 7:32 PM sochin.jiang <sochin@aliyun.com> wrote:
> From: "sochin.jiang" <sochin@aliyun.com>
>
> fix wrong parameter comments in channel-file.h.
>
> Signed-off-by: sochin.jiang <sochin@aliyun.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/io/channel-file.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/io/channel-file.h b/include/io/channel-file.h
> index d2462c2..79245f1 100644
> --- a/include/io/channel-file.h
> +++ b/include/io/channel-file.h
> @@ -71,7 +71,7 @@ qio_channel_file_new_fd(int fd);
>
> /**
> * qio_channel_file_new_path:
> - * @fd: the file descriptor
> + * @path: the file path
> * @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc)
> * @mode: the file creation mode if O_WRONLY is set in @flags
> * @errp: pointer to initialized error object
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments
2017-03-24 14:28 [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments sochin.jiang
2017-03-24 15:47 ` Marc-André Lureau
@ 2017-04-23 9:15 ` Michael Tokarev
1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-04-23 9:15 UTC (permalink / raw)
To: sochin.jiang, berrange; +Cc: qemu-devel, sochin.jiang, QEMU Trivial
24.03.2017 17:28, sochin.jiang wrote:
> From: "sochin.jiang" <sochin@aliyun.com>
>
> fix wrong parameter comments in channel-file.h.
Applied to -trivial. Please don't duplicate subject and commit comment,
it's enough to leave commit empty if everything is said in the subject :)
Thanks,
/mjt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-23 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 14:28 [Qemu-devel] [PATCH] channel-file: fix wrong parameter comments sochin.jiang
2017-03-24 15:47 ` Marc-André Lureau
2017-04-23 9:15 ` Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.